)]}'
{"manifests/storage/ceph.pp":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4506bbf58c96f2123bd84fbda6012a3bbbb03bb8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (required) Ceph username to use."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*ceph_keyring*]"},{"line_number":32,"context_line":"#   (optiional) Ceph keyring path."},{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*ceph_secret*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a18252c_98b182e4","line":32,"updated":"2016-04-13 20:34:27.000000000","message":"s/optiional/optional/","commit_id":"a2b28064a5f2e35a00ae13ad14810c65bed9cb97"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dedee31c5023f86abaabff3ace4d4e366e37f7ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (required) Ceph username to use."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*ceph_keyring*]"},{"line_number":32,"context_line":"#   (optiional) Ceph keyring path."},{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*ceph_secret*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a18252c_51d4e51e","line":32,"in_reply_to":"5a18252c_98b182e4","updated":"2016-04-13 21:44:48.000000000","message":"Done","commit_id":"a2b28064a5f2e35a00ae13ad14810c65bed9cb97"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a2281f1f13acc8d402cfb6fc67c540f26725b23","unresolved":false,"context_lines":[{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  if is_service_default($ceph_keyring) and is_service_default($ceph_secret) {"},{"line_number":52,"context_line":"    fail(\u0027You need to specify either gnocchi::storage::ceph::ceph_keyring or gnocchi::storage::ceph::ceph_secret.\u0027)"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  gnocchi_config {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a18252c_cd0b1b29","line":52,"updated":"2016-04-14 11:02:51.000000000","message":"just a suggestion, can we add more valuable validation here?\nbecause we can pass false in both parameters or undef.","commit_id":"b5cd4cdfb49fb98f7865e43ba64c652d16946171"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b01cf0e1069dfeab0996ab687702ba604cef4fb","unresolved":false,"context_lines":[{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  if is_service_default($ceph_keyring) and is_service_default($ceph_secret) {"},{"line_number":52,"context_line":"    fail(\u0027You need to specify either gnocchi::storage::ceph::ceph_keyring or gnocchi::storage::ceph::ceph_secret.\u0027)"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  gnocchi_config {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a18252c_0894ce40","line":52,"in_reply_to":"5a18252c_cd0b1b29","updated":"2016-04-14 15:18:17.000000000","message":"you\u0027re right, i\u0027ll do in next PS.","commit_id":"b5cd4cdfb49fb98f7865e43ba64c652d16946171"}]}
