)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"04605ace8bca12a467d8169adfc1a622f299a452","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#   (optional) The gnocchi api port."},{"line_number":19,"context_line":"#   Defaults to 8041"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# \u003d\u003d\u003d Keystone Middleware"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*password*]"},{"line_number":24,"context_line":"#   (required) Password for the user"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_925f590e","line":21,"updated":"2016-07-26 17:04:46.000000000","message":"according to our latest meeting, these parameters should be moved into separate class with keeping backward compatibility (use pick function)","commit_id":"301cc15b6826ed25caf8c6b62fd5523bde8375c6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"76ad15dc7c27146ee92bed135b46bc765863d738","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   Defaults to true."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*keystone_user*]"},{"line_number":14,"context_line":"#   (optional) The name of the auth user"},{"line_number":15,"context_line":"#   Defaults to gnocchi"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# [*keystone_tenant*]"},{"line_number":18,"context_line":"#   (optional) Tenant to authenticate with."},{"line_number":19,"context_line":"#   Defaults to \u0027services\u0027."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*keystone_password*]"},{"line_number":22,"context_line":"#   Password to authenticate with."},{"line_number":23,"context_line":"#   Mandatory."},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*keystone_auth_uri*]"},{"line_number":26,"context_line":"#   (optional) Public Identity API endpoint."},{"line_number":27,"context_line":"#   Defaults to \u0027false\u0027."},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*keystone_identity_uri*]"},{"line_number":30,"context_line":"#   (optional) Complete admin Identity API endpoint."},{"line_number":31,"context_line":"#   Defaults to: false"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*host*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bacf61ea_01e4e0a9","side":"PARENT","line":30,"range":{"start_line":14,"start_character":0,"end_line":30,"end_character":26},"updated":"2016-07-29 16:15:14.000000000","message":"you need deprecate first","commit_id":"0c1f61b7c60dfe58c7abb04b629f7f04869492ed"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"76ad15dc7c27146ee92bed135b46bc765863d738","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#   (optional) Should the service be enabled."},{"line_number":7,"context_line":"#   Defaults to true"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# [*auth_type*]"},{"line_number":10,"context_line":"#   (optional) authentication type"},{"line_number":11,"context_line":"#   Defaults to \u0027keystone\u0027"},{"line_number":12,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bacf61ea_417b78f5","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":13},"updated":"2016-07-29 16:15:14.000000000","message":"let\u0027s call it auth_strategy","commit_id":"98f21e45a25edfe9ef3b837bf037e98566b93d35"}],"manifests/keystone/authtoken.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"76ad15dc7c27146ee92bed135b46bc765863d738","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  if is_service_default($password) {"},{"line_number":232,"context_line":"    fail(\u0027Please set password for Gnocchi service user\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  keystone::resource::authtoken { \u0027gnocchi_config\u0027:"},{"line_number":236,"context_line":"    username                       \u003d\u003e $username,"},{"line_number":237,"context_line":"    password                       \u003d\u003e $password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bacf61ea_4162583f","line":234,"updated":"2016-07-29 16:15:14.000000000","message":"you need picks for:\n\n  $keystone_user        \n  $keystone_tenant      \n  $keystone_password    \n  $keystone_auth_uri    \n  $keystone_identity_uri","commit_id":"98f21e45a25edfe9ef3b837bf037e98566b93d35"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5d71211951d18941c2d40aec207c492449d3ed2a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*project_domain_name*]"},{"line_number":28,"context_line":"#   (Optional) Name of domain for $project_name"},{"line_number":29,"context_line":"#   Defaults to $::os_service_default"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*insecure*]"},{"line_number":32,"context_line":"#  (Optional) If true, explicitly allow TLS without checking server cert"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_25035b78","line":29,"updated":"2016-08-12 15:24:36.000000000","message":"alignment is not perfect since line 8. I noticed this problem in all your patches, you probably copy/pasted it. Not big deal, but would be great to fix it sometimes.","commit_id":"badbd0ea6e83f464cd29ae347a0300fdf013fa59"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5d71211951d18941c2d40aec207c492449d3ed2a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*auth_uri*]"},{"line_number":46,"context_line":"#  (Optional) Complete public Identity API endpoint."},{"line_number":47,"context_line":"#  Defaults to $::os_service_default."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*auth_version*]"},{"line_number":50,"context_line":"#  (Optional) API version of the admin Identity API endpoint."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_0508d790","line":47,"updated":"2016-08-12 15:24:36.000000000","message":"why don\u0027t you set an url by default?","commit_id":"badbd0ea6e83f464cd29ae347a0300fdf013fa59"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5d71211951d18941c2d40aec207c492449d3ed2a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  $insecure                       \u003d $::os_service_default,"},{"line_number":201,"context_line":"  $auth_section                   \u003d $::os_service_default,"},{"line_number":202,"context_line":"  $auth_type                      \u003d \u0027password\u0027,"},{"line_number":203,"context_line":"  $auth_uri                       \u003d $::os_service_default,"},{"line_number":204,"context_line":"  $auth_version                   \u003d $::os_service_default,"},{"line_number":205,"context_line":"  $cache                          \u003d $::os_service_default,"},{"line_number":206,"context_line":"  $cafile                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9ad45d7e_65fd536e","line":203,"updated":"2016-08-12 15:24:36.000000000","message":"why no default here?","commit_id":"badbd0ea6e83f464cd29ae347a0300fdf013fa59"}]}