)]}'
{"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6501856634c3fdd094fc9d65cb4a49d75a9315ce","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    warning(\u0027workers is deprecated\u0027)"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  # NOTE(tobasco): Canonical forces apache2 and py3 in gnocchi-api package in Queens."},{"line_number":95,"context_line":"  # This makes sure we use py2 package when running wsgi on Debian based."},{"line_number":96,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 and $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":97,"context_line":"    $api_package_name_real \u003d \u0027python-gnocchi\u0027"},{"line_number":98,"context_line":"  } else {"},{"line_number":99,"context_line":"    $api_package_name_real \u003d $::gnocchi::params::api_package_name"},{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  package { \u0027gnocchi-api\u0027:"},{"line_number":103,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff6b8bd7_d076793f","line":100,"range":{"start_line":94,"start_character":0,"end_line":100,"end_character":3},"updated":"2018-03-05 18:53:00.000000000","message":"This logic should probably live in params and instead of assuming debian, perhaps ubuntu specific logic","commit_id":"f18ed4adb5ecf68fc6749ae51a405bfce0809b00"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"da0126beab2474a0194e7ec83aa2fd25332cd900","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    warning(\u0027workers is deprecated\u0027)"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  # NOTE(tobasco): Canonical forces apache2 and py3 in gnocchi-api package in Queens."},{"line_number":95,"context_line":"  # This makes sure we use py2 package when running wsgi on Debian based."},{"line_number":96,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 and $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":97,"context_line":"    $api_package_name_real \u003d \u0027python-gnocchi\u0027"},{"line_number":98,"context_line":"  } else {"},{"line_number":99,"context_line":"    $api_package_name_real \u003d $::gnocchi::params::api_package_name"},{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  package { \u0027gnocchi-api\u0027:"},{"line_number":103,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff6b8bd7_90c6c116","line":100,"range":{"start_line":94,"start_character":0,"end_line":100,"end_character":3},"in_reply_to":"ff6b8bd7_d076793f","updated":"2018-03-05 19:11:30.000000000","message":"That\u0027s true, I can fix in next PS","commit_id":"f18ed4adb5ecf68fc6749ae51a405bfce0809b00"}],"manifests/storage.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6501856634c3fdd094fc9d65cb4a49d75a9315ce","unresolved":false,"context_lines":[{"line_number":57,"context_line":"          name   \u003d\u003e \u0027python3-redis\u0027,"},{"line_number":58,"context_line":"          tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":59,"context_line":"        })"},{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff6b8bd7_709d2d58","line":60,"updated":"2018-03-05 18:53:00.000000000","message":"Should this exclude python-redis or do we need both?","commit_id":"f18ed4adb5ecf68fc6749ae51a405bfce0809b00"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"da0126beab2474a0194e7ec83aa2fd25332cd900","unresolved":false,"context_lines":[{"line_number":57,"context_line":"          name   \u003d\u003e \u0027python3-redis\u0027,"},{"line_number":58,"context_line":"          tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":59,"context_line":"        })"},{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff6b8bd7_b0cbc51c","line":60,"in_reply_to":"ff6b8bd7_709d2d58","updated":"2018-03-05 19:11:30.000000000","message":"Yes we still need both since we are running api in py2 and the other with py3 right now.","commit_id":"f18ed4adb5ecf68fc6749ae51a405bfce0809b00"}],"manifests/storage/ceph.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6501856634c3fdd094fc9d65cb4a49d75a9315ce","unresolved":false,"context_lines":[{"line_number":114,"context_line":"          \u0027name\u0027   \u003d\u003e \u0027python3-rados\u0027,"},{"line_number":115,"context_line":"          \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027,\u0027gnocchi-package\u0027],"},{"line_number":116,"context_line":"        })"},{"line_number":117,"context_line":"      }"},{"line_number":118,"context_line":"    }"},{"line_number":119,"context_line":"  }"},{"line_number":120,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff6b8bd7_309fb551","line":117,"updated":"2018-03-05 18:53:00.000000000","message":"same question, do we want both?","commit_id":"f18ed4adb5ecf68fc6749ae51a405bfce0809b00"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"da0126beab2474a0194e7ec83aa2fd25332cd900","unresolved":false,"context_lines":[{"line_number":114,"context_line":"          \u0027name\u0027   \u003d\u003e \u0027python3-rados\u0027,"},{"line_number":115,"context_line":"          \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027,\u0027gnocchi-package\u0027],"},{"line_number":116,"context_line":"        })"},{"line_number":117,"context_line":"      }"},{"line_number":118,"context_line":"    }"},{"line_number":119,"context_line":"  }"},{"line_number":120,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ff6b8bd7_10dab1e8","line":117,"in_reply_to":"ff6b8bd7_309fb551","updated":"2018-03-05 19:11:30.000000000","message":"Yeah, same as the other answer.","commit_id":"f18ed4adb5ecf68fc6749ae51a405bfce0809b00"}],"spec/classes/gnocchi_api_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0c6e4ecd9e12615e4d0a251f56211da02fed1ca","unresolved":false,"context_lines":[{"line_number":199,"context_line":"      end"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"      let(:platform_params) do"},{"line_number":202,"context_line":"        { :api_package_name \u003d\u003e \u0027gnocchi-api\u0027,"},{"line_number":203,"context_line":"          :api_service_name \u003d\u003e \u0027gnocchi-api\u0027 }"},{"line_number":204,"context_line":"      end"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"      if facts[:operatingsystem] \u003d\u003d \u0027Ubuntu\u0027 then"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"ff6b8bd7_404cbbc6","line":203,"range":{"start_line":202,"start_character":2,"end_line":203,"end_character":46},"updated":"2018-03-06 21:34:42.000000000","message":"So this is where you\u0027ll probably want to just add logic here to switch out the package name if it\u0027s ubuntu otherwise use gnocchi-api. Then you won\u0027t need the special logic anywhere else.","commit_id":"9537511b5c459682fc07a1553d5564d8fca51697"}],"spec/classes/gnocchi_wsgi_apache_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dd51b453381f5c0999854bdbcb03dac4a4663ae3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      if facts[:operatingsystem] \u003d\u003d \u0027Ubuntu\u0027 then"},{"line_number":112,"context_line":"        platform_params.merge!({"},{"line_number":113,"context_line":"          :wsgi_script_source \u003d\u003e \u0027/usr/bin/python2-gnocchi-api\u0027"},{"line_number":114,"context_line":"        )}"},{"line_number":115,"context_line":"      end"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"      it_behaves_like \u0027apache serving gnocchi with mod_wsgi\u0027"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"ff6b8bd7_3959cf59","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":10},"updated":"2018-03-06 16:28:15.000000000","message":"This is backwards, should be })","commit_id":"17466d8e7554bfa366bf91c6935cb620f48063ef"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9b40c6ff4e7115c89af6d9fd460bbfbed345637c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      let(:platform_params) do"},{"line_number":93,"context_line":"        case facts[:osfamily]"},{"line_number":94,"context_line":"        when \u0027Debian\u0027"},{"line_number":95,"context_line":"          {"},{"line_number":96,"context_line":"            :httpd_service_name \u003d\u003e \u0027apache2\u0027,"},{"line_number":97,"context_line":"            :httpd_ports_file   \u003d\u003e \u0027/etc/apache2/ports.conf\u0027,"},{"line_number":98,"context_line":"            :wsgi_script_path   \u003d\u003e \u0027/usr/lib/cgi-bin/gnocchi\u0027,"},{"line_number":99,"context_line":"            :wsgi_script_source \u003d\u003e \u0027/usr/share/gnocchi-common/app.wsgi\u0027"},{"line_number":100,"context_line":"          }"},{"line_number":101,"context_line":"        when \u0027RedHat\u0027"},{"line_number":102,"context_line":"          {"},{"line_number":103,"context_line":"            :httpd_service_name \u003d\u003e \u0027httpd\u0027,"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"ff6b8bd7_0a2b47eb","line":100,"range":{"start_line":95,"start_character":0,"end_line":100,"end_character":11},"updated":"2018-03-06 18:10:01.000000000","message":"So because this is in the section that defines platform_params, you\u0027ll need to move your logic from below into something like...\n\n    ...\n     when \u0027Debian\u0027\n        if facts[:operatingsystem] \u003d\u003d \u0027Ubuntu\u0027 then\n          script_source \u003d \u0027/usr/bin/python2-gnocchi-api\u0027\n        else\n          script_source \u003d \u0027/usr/share/gnocchi-common/app.wsgi\u0027\n        end\n        {\n          :httpd_service_name \u003d\u003e \u0027apache2\u0027,\n          :httpd_ports_file   \u003d\u003e \u0027/etc/apache2/ports.conf\u0027,\n          :wsgi_script_path   \u003d\u003e \u0027/usr/lib/cgi-bin/gnocchi\u0027,\n          :wsgi_script_source \u003d\u003e script_source\n        }\n    ...","commit_id":"ab40c1a7bb78d7e022a536062aeefb4767f515d3"}]}