)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"1b1e911baeaf27da8fdb0f77ec71ec470e2919c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f0bebe6f_caa6d674","updated":"2021-11-13 15:57:09.000000000","message":"Given there has been no work done on this for 2 years +, do we still need this or can we abandon it ?","commit_id":"79dfae96a77ba6539f4948c9b056a2a2bc6df04a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d2bf0e18f3b4d250f7c134357393123f84ecb84a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ba7ddf9e_f7df0d6d","updated":"2021-11-15 01:31:51.000000000","message":"IIUC boto3 has never been added to the dependencies of the gnocchi package and we still need this. The original bug was the issue with TripleO which doesn\u0027t require this fix in puppet-gnocchi but I believe this is still worth fixing.","commit_id":"697c2af2b64af5639939337de651080d856cdfa5"}],"manifests/params.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d3f50015a2fd9535451b380ea26418102209956e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $statsd_service_name        \u003d \u0027gnocchi-statsd\u0027"},{"line_number":20,"context_line":"  $group                      \u003d \u0027gnocchi\u0027"},{"line_number":21,"context_line":"  $gnocchi_wsgi_script_source \u003d \u0027/usr/bin/gnocchi-api\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  case $::osfamily {"},{"line_number":24,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":25,"context_line":"      $sqlite_package_name        \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5fc1f717_c23359aa","line":22,"updated":"2019-03-26 19:31:20.000000000","message":"Actually these packages should be version specific.  We\u0027ll need python3 version logic for the redhat family","commit_id":"787ca40aa0bf9c15d32044bedf9cbc1676e0072d"},{"author":{"_account_id":30158,"name":"Cyril Grosjean","email":"cyril.grosjean@wifirst.fr","username":"cgrosjean"},"change_message_id":"063b3161aae1925d2d41a9c9d60ddd7d9da7d280","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  case $::osfamily {"},{"line_number":22,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":23,"context_line":"      $boto3_package_name         \u003d \"python-boto3\""},{"line_number":24,"context_line":"      $s3transfer_package_name    \u003d \u0027python-s3transfer\u0027"},{"line_number":25,"context_line":"      $sqlite_package_name        \u003d undef"},{"line_number":26,"context_line":"      $indexer_package_name       \u003d \u0027openstack-gnocchi-indexer-sqlalchemy\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_a69c0e0e","line":23,"range":{"start_line":23,"start_character":36,"end_line":23,"end_character":50},"updated":"2019-03-27 13:48:13.000000000","message":"manifests/params.pp:23:WARNING: double quoted string containing no variables","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"658e7f1416e1927550a1a73973926bd973487227","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  case $::osfamily {"},{"line_number":22,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":23,"context_line":"      $boto3_package_name         \u003d \"python-boto3\""},{"line_number":24,"context_line":"      $s3transfer_package_name    \u003d \u0027python-s3transfer\u0027"},{"line_number":25,"context_line":"      $sqlite_package_name        \u003d undef"},{"line_number":26,"context_line":"      $indexer_package_name       \u003d \u0027openstack-gnocchi-indexer-sqlalchemy\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_0ff2ce70","line":23,"range":{"start_line":23,"start_character":36,"end_line":23,"end_character":50},"in_reply_to":"5fc1f717_a69c0e0e","updated":"2019-03-31 12:55:18.000000000","message":"Done","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":30158,"name":"Cyril Grosjean","email":"cyril.grosjean@wifirst.fr","username":"cgrosjean"},"change_message_id":"bdf444579989fe0aed3d7efd0bd689524ebf52d8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  case $::osfamily {"},{"line_number":22,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":23,"context_line":"      $boto3_package_name         \u003d \"python-boto3\""},{"line_number":24,"context_line":"      $s3transfer_package_name    \u003d \u0027python-s3transfer\u0027"},{"line_number":25,"context_line":"      $sqlite_package_name        \u003d undef"},{"line_number":26,"context_line":"      $indexer_package_name       \u003d \u0027openstack-gnocchi-indexer-sqlalchemy\u0027"},{"line_number":27,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/gnocchi\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_e67a16ef","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":55},"updated":"2019-03-27 13:43:43.000000000","message":"s3transfer is a dependency of boto3, useless to declare it here.","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"658e7f1416e1927550a1a73973926bd973487227","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  case $::osfamily {"},{"line_number":22,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":23,"context_line":"      $boto3_package_name         \u003d \"python-boto3\""},{"line_number":24,"context_line":"      $s3transfer_package_name    \u003d \u0027python-s3transfer\u0027"},{"line_number":25,"context_line":"      $sqlite_package_name        \u003d undef"},{"line_number":26,"context_line":"      $indexer_package_name       \u003d \u0027openstack-gnocchi-indexer-sqlalchemy\u0027"},{"line_number":27,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/gnocchi\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_2ff54a57","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":55},"in_reply_to":"5fc1f717_e67a16ef","updated":"2019-03-31 12:55:18.000000000","message":"Done","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":30158,"name":"Cyril Grosjean","email":"cyril.grosjean@wifirst.fr","username":"cgrosjean"},"change_message_id":"bdf444579989fe0aed3d7efd0bd689524ebf52d8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      $redis_package_name         \u003d \"python${pyvers}-redis\""},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"    \u0027Debian\u0027: {"},{"line_number":33,"context_line":"      $boto3_package_name         \u003d undef"},{"line_number":34,"context_line":"      $s3transfer_package_name    \u003d undef"},{"line_number":35,"context_line":"      $sqlite_package_name        \u003d \u0027python-pysqlite2\u0027"},{"line_number":36,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/usr/lib/cgi-bin/gnocchi\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_061962d5","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":41},"updated":"2019-03-27 13:43:43.000000000","message":"You have a package for boto3 in python2 and python3 for Debian :\npython-boto3 (python2)\npython3-boto3 (python3)","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"658e7f1416e1927550a1a73973926bd973487227","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      $redis_package_name         \u003d \"python${pyvers}-redis\""},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"    \u0027Debian\u0027: {"},{"line_number":33,"context_line":"      $boto3_package_name         \u003d undef"},{"line_number":34,"context_line":"      $s3transfer_package_name    \u003d undef"},{"line_number":35,"context_line":"      $sqlite_package_name        \u003d \u0027python-pysqlite2\u0027"},{"line_number":36,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/usr/lib/cgi-bin/gnocchi\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_cfe7e6ab","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":41},"in_reply_to":"5fc1f717_061962d5","updated":"2019-03-31 12:55:18.000000000","message":"I used python3-boto3 for debian.","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":30158,"name":"Cyril Grosjean","email":"cyril.grosjean@wifirst.fr","username":"cgrosjean"},"change_message_id":"bdf444579989fe0aed3d7efd0bd689524ebf52d8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"    \u0027Debian\u0027: {"},{"line_number":33,"context_line":"      $boto3_package_name         \u003d undef"},{"line_number":34,"context_line":"      $s3transfer_package_name    \u003d undef"},{"line_number":35,"context_line":"      $sqlite_package_name        \u003d \u0027python-pysqlite2\u0027"},{"line_number":36,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/usr/lib/cgi-bin/gnocchi\u0027"},{"line_number":37,"context_line":"      $pymysql_package_name       \u003d \"python${pyvers}-pymysql\""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_8624720e","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":41},"updated":"2019-03-27 13:43:43.000000000","message":"s3transfer is a dependency of boto3, useless to declare it here.","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"658e7f1416e1927550a1a73973926bd973487227","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"    \u0027Debian\u0027: {"},{"line_number":33,"context_line":"      $boto3_package_name         \u003d undef"},{"line_number":34,"context_line":"      $s3transfer_package_name    \u003d undef"},{"line_number":35,"context_line":"      $sqlite_package_name        \u003d \u0027python-pysqlite2\u0027"},{"line_number":36,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/usr/lib/cgi-bin/gnocchi\u0027"},{"line_number":37,"context_line":"      $pymysql_package_name       \u003d \"python${pyvers}-pymysql\""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5fc1f717_efeae271","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":41},"in_reply_to":"5fc1f717_8624720e","updated":"2019-03-31 12:55:18.000000000","message":"Done","commit_id":"d9bacc60fb6d137363800eb64df34fd03b9e3468"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"50c2866669f08e33e3db517ccf9bdcdf424507af","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  case $::osfamily {"},{"line_number":22,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":23,"context_line":"      $boto3_package_name         \u003d \u0027python-boto3\u0027"},{"line_number":24,"context_line":"      $sqlite_package_name        \u003d undef"},{"line_number":25,"context_line":"      $indexer_package_name       \u003d \u0027openstack-gnocchi-indexer-sqlalchemy\u0027"},{"line_number":26,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/gnocchi\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5fc1f717_f67056dd","line":23,"updated":"2019-03-29 14:53:28.000000000","message":"should be \"python${pyvers}-boto3\" to get the python/python3 package name correctly","commit_id":"1242221e37cb78655c38b43893d44b6376e8b516"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d8baab5887f61262412e48201bd256017d0e8f7a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  case $::osfamily {"},{"line_number":22,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":23,"context_line":"      $boto3_package_name         \u003d \u0027python-boto3\u0027"},{"line_number":24,"context_line":"      $sqlite_package_name        \u003d undef"},{"line_number":25,"context_line":"      $indexer_package_name       \u003d \u0027openstack-gnocchi-indexer-sqlalchemy\u0027"},{"line_number":26,"context_line":"      $gnocchi_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/gnocchi\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5fc1f717_c1a6b2ac","line":23,"updated":"2019-03-29 15:23:41.000000000","message":"This also needs the ${pyvers}","commit_id":"d5413d6b3b85915863071f7f9d197d684b51011d"}],"manifests/storage/s3.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b81b272aaf4b0f3ebb273b6e8873804c7c5c950b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::gnocchi::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $::gnocchi::params::s3transfer_package_name {"},{"line_number":35,"context_line":"    ensure_packages(\u0027python-s3transfer\u0027, {"},{"line_number":36,"context_line":"      \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":37,"context_line":"      \u0027name\u0027   \u003d\u003e $::gnocchi::params::s3transfer_package_name,"},{"line_number":38,"context_line":"      \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027,\u0027gnocchi-package\u0027],"},{"line_number":39,"context_line":"    })"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $::gnocchi::params::boto3_package_name {"},{"line_number":43,"context_line":"    ensure_packages(\u0027python-boto3\u0027, {"},{"line_number":44,"context_line":"      \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":45,"context_line":"      \u0027name\u0027   \u003d\u003e $::gnocchi::params::boto3_package_name,"},{"line_number":46,"context_line":"      \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027,\u0027gnocchi-package\u0027],"},{"line_number":47,"context_line":"    })"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  gnocchi_config {"},{"line_number":51,"context_line":"    \u0027storage/driver\u0027:                value \u003d\u003e \u0027s3\u0027;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5fc1f717_9ea6170f","line":48,"range":{"start_line":34,"start_character":0,"end_line":48,"end_character":3},"updated":"2019-03-26 13:59:29.000000000","message":"So in containers this has no effect. The correct place to put this is likely in kolla itself. We have overrides that we can put into tripleo-common if this needs to be backported past master.  http://git.openstack.org/cgit/openstack/tripleo-common/tree/container-images/tripleo_kolla_template_overrides.j2#n112 you\u0027d need to add a gnocchi_api_packages_append (if it belongs in that container)","commit_id":"787ca40aa0bf9c15d32044bedf9cbc1676e0072d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2af21fe5a92787fe9a13db3d2eec80050c84eea","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::gnocchi::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $::gnocchi::params::s3transfer_package_name {"},{"line_number":35,"context_line":"    ensure_packages(\u0027python-s3transfer\u0027, {"},{"line_number":36,"context_line":"      \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":37,"context_line":"      \u0027name\u0027   \u003d\u003e $::gnocchi::params::s3transfer_package_name,"},{"line_number":38,"context_line":"      \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027,\u0027gnocchi-package\u0027],"},{"line_number":39,"context_line":"    })"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $::gnocchi::params::boto3_package_name {"},{"line_number":43,"context_line":"    ensure_packages(\u0027python-boto3\u0027, {"},{"line_number":44,"context_line":"      \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":45,"context_line":"      \u0027name\u0027   \u003d\u003e $::gnocchi::params::boto3_package_name,"},{"line_number":46,"context_line":"      \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027,\u0027gnocchi-package\u0027],"},{"line_number":47,"context_line":"    })"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  gnocchi_config {"},{"line_number":51,"context_line":"    \u0027storage/driver\u0027:                value \u003d\u003e \u0027s3\u0027;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5fc1f717_de3c9f94","line":48,"range":{"start_line":34,"start_character":0,"end_line":48,"end_character":3},"in_reply_to":"5fc1f717_9ea6170f","updated":"2019-03-26 14:02:34.000000000","message":"we\u0027ll need this here for normal puppet installs however","commit_id":"787ca40aa0bf9c15d32044bedf9cbc1676e0072d"}],"spec/classes/gnocchi_storage_s3_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c3c66dd6a7f0e4530f758af5367fda232a751501","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    context \"on #{os}\" do"},{"line_number":43,"context_line":"      let (:facts) do"},{"line_number":44,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":45,"context_line":"      end"},{"line_number":46,"context_line":"      it_behaves_like \u0027gnocchi storage s3\u0027"},{"line_number":47,"context_line":"    end"},{"line_number":48,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"ffb9cba7_498e4179","line":45,"updated":"2019-04-22 22:47:31.000000000","message":"You need to define platform_params in here to specify the package name","commit_id":"79dfae96a77ba6539f4948c9b056a2a2bc6df04a"}]}