)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"279e7efd65d0dd8209338af5e422c7f048c8533c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77a4c577_2168fb7b","updated":"2024-10-27 11:41:09.000000000","message":"This is a proposal for simplify the relation between oslo::* and the modules.\n\nPlease add comments if you think this proposal has any value or not. \nAlso feel free to add  additional reviewers.\n(and please do NOT merge)","commit_id":"099ec3434a4541bd0307c9caf57b3ac95caa4d67"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31cc333ceb6347910934c18b5f610b8e7c3933ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52d8e78e_7cdc7b73","updated":"2024-10-27 11:46:17.000000000","message":"This is an actual example of showing the concern by this approach.\n\nFor example gnocchi does not use oslo.db and most of the oslo.db parameters are not recognized by gnocchi. We reuse the base handling of database_connection but we do not use the other part. Another example is oslo::middleware which supports multiple middleware options but some middlewares might not be enabled in some services.\n\nOne of the benefit of having explicit interface is that we know what are actually used by the service and I\u0027m in favor of keeping the existing explicit interface as much as possible","commit_id":"099ec3434a4541bd0307c9caf57b3ac95caa4d67"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"755d558ce4f123f10ad4e80546191c5ddd0b2b13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a217ea9_687f50d4","in_reply_to":"46986592_74340fe5","updated":"2024-10-27 12:05:07.000000000","message":"About: gnocchi and oslo.db: right, but I think this is an gnocchi only problem (actually I see most of the config options in gnocchi.conf), and nothing bad happens if a user configures a parameter that is not used by gnocchi.\n.\nAbout the explicit error: if we the type of $oslo_db_defaults is set to Oslo::Db_defaults (which does not exist yet).\nAn error will then point to the parameter gnocchi::db::oslo_db_defaults which makes it easy to find.","commit_id":"099ec3434a4541bd0307c9caf57b3ac95caa4d67"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"576ba51070c0933bcba75d3c1102f2bdc73c093c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"46986592_74340fe5","in_reply_to":"52d8e78e_7cdc7b73","updated":"2024-10-27 11:47:54.000000000","message":"Also if you rely on the data type interface in oslo then you may not get very explicit error to understand which class has an invalid value which is causing validation errors.","commit_id":"099ec3434a4541bd0307c9caf57b3ac95caa4d67"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe811945e7dce3f20a965f3eb6d85e14496c3583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f3f267f_ba34cf5b","in_reply_to":"78fad7d9_35f84248","updated":"2024-10-27 17:52:52.000000000","message":"It\u0027s true that gnocchi uses oslo.db options but it does not [database] connection. To make my stance clear I won\u0027t block adding this interface, as we already introduced this for authtoken option, IMO the interface is for last resort. We need a way to helps users to find out which options they can actually customize, and for that purpose we should maintain the individual parameters as much as possible (except for very advanced parameters).","commit_id":"099ec3434a4541bd0307c9caf57b3ac95caa4d67"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"1834548cd5ec6c75a6bf2e0cfbac9d918a7dab18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78fad7d9_35f84248","in_reply_to":"8a217ea9_687f50d4","updated":"2024-10-27 12:15:20.000000000","message":"Actually gnocchi is using oslo::db (see https://github.com/gnocchixyz/gnocchi/blob/master/setup.cfg#L62)","commit_id":"099ec3434a4541bd0307c9caf57b3ac95caa4d67"}],"manifests/db.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe811945e7dce3f20a965f3eb6d85e14496c3583","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#   (optional) The state of gnocchi packages"},{"line_number":13,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*oslo_db_defaults*]"},{"line_number":16,"context_line":"#   Hash of values use for calling oslo::db"},{"line_number":17,"context_line":"#   as defaults values."},{"line_number":18,"context_line":"#  Defaults to {}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"88a0e445_5f9d3af4","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":20},"updated":"2024-10-27 17:52:52.000000000","message":"By the way we use `params` parameter for authtoken. Should we use the same name for consistency ?","commit_id":"8d4b00072cd4da2a68c186d547ef5ed91d20127b"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"9df3bdc88b51c6bc813d134675008e8d7b4c8f9c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#   (optional) The state of gnocchi packages"},{"line_number":13,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*oslo_db_defaults*]"},{"line_number":16,"context_line":"#   Hash of values use for calling oslo::db"},{"line_number":17,"context_line":"#   as defaults values."},{"line_number":18,"context_line":"#  Defaults to {}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1e312db6_bfd7fd68","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":20},"in_reply_to":"88a0e445_5f9d3af4","updated":"2025-04-20 15:17:37.000000000","message":"Yes, this seems to be a goot idea, I will change that.\n\nAnother:\nShould params be default, and overwritten by specified puppet parameters (like in gnocchi::db) or schould $params overwrite defaults set by puppet specific parameters (like in gnocchi::keystone::authoken) ?\n\nProbably we want to have it the same way round if the parameter name has the same name","commit_id":"8d4b00072cd4da2a68c186d547ef5ed91d20127b"}]}