)]}'
{"id":"openstack%2Fpuppet-gnocchi~933541","triplet_id":"openstack%2Fpuppet-gnocchi~master~Iad90bde7e0fe38197dcd62cdd921bc1893d9111a","project":"openstack/puppet-gnocchi","branch":"master","topic":"dev_proposal_oslo_parameters","attention_set":{},"removed_from_attention_set":{"7888":{"account":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"last_update":"2025-04-20 15:17:37.000000000","reason":"\u003cGERRIT_ACCOUNT_7888\u003e replied on the change","reason_account":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"}},"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2025-08-25 07:29:20.000000000","reason":"Change was abandoned"},"14985":{"account":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"last_update":"2025-08-25 07:29:20.000000000","reason":"Change was abandoned"},"16137":{"account":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"last_update":"2025-08-25 07:29:20.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Iad90bde7e0fe38197dcd62cdd921bc1893d9111a","subject":"PROPOSAL: use hash for calling oslo libraries","status":"ABANDONED","created":"2024-10-27 11:34:48.000000000","updated":"2025-08-25 07:29:20.000000000","total_comment_count":8,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"26b88c746d6d6e33aea69b20d57b9c7eaad59426","_number":933541,"virtual_id_number":933541,"owner":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:check","value":1,"date":"2024-10-27 13:18:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"all":[{"value":-1,"date":"2024-10-27 12:05:07.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-27 11:41:09.000000000","updated_by":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2024-10-27 11:41:09.000000000","updated_by":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2024-10-27 11:41:09.000000000","updated_by":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2024-10-27 13:18:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a399f3360763ab72199ce3f9bb4484421c2a2377","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2024-10-27 11:34:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"279e7efd65d0dd8209338af5e422c7f048c8533c","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2024-10-27 11:41:09.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"31cc333ceb6347910934c18b5f610b8e7c3933ef","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-10-27 11:46:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"576ba51070c0933bcba75d3c1102f2bdc73c093c","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-10-27 11:47:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c872f2a8bdf5795eeb7b5eba8ded66f0183d865","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-10-27 11:48:03.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"bb681fb13014f4a949502a870b7e86a4fae9b829","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2024-10-27 11:53:33.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Workflow-1\n","accounts_in_message":[],"_revision_number":2},{"id":"755d558ce4f123f10ad4e80546191c5ddd0b2b13","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2024-10-27 12:05:07.000000000","message":"Patch Set 2: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1834548cd5ec6c75a6bf2e0cfbac9d918a7dab18","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2024-10-27 12:15:20.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c3a5a2c9328060226e088a590e3e5468d28f6421","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-27 13:18:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dfcc5f25c49f434e8ff96bfeaddf5c7f\n\n- puppet-openstack-lint-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/5df7f04deff64be2bda7da57516015a9 : SUCCESS in 2m 07s\n- puppet-openstack-syntax-7-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/6cfd899e19b0462293b6ae4f615e56d8 : SUCCESS in 2m 41s\n- puppet-openstack-syntax-8-centos-9-stream https://zuul.opendev.org/t/openstack/build/f93df6d395574c8aac6395efe3745757 : SUCCESS in 5m 19s (non-voting)\n- puppet-openstack-unit-7.32-centos-9-stream https://zuul.opendev.org/t/openstack/build/3c7485bce4dc4f54b42697a9c52727ad : SUCCESS in 8m 11s\n- puppet-openstack-unit-7.32-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/16437f6cfde04e9b849f6f5a6d1e63e2 : SUCCESS in 5m 15s\n- puppet-openstack-unit-8.8-centos-9-stream https://zuul.opendev.org/t/openstack/build/6005fa3a29284685ae9153a3a47b97bb : SUCCESS in 8m 22s (non-voting)\n- puppet-openstack-unit-latest-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/7c45cad0364e438ca29a4a0b59282fcf : SUCCESS in 5m 22s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/4420f0b8b06f4a3dad8ba36b9ec7d877 : SUCCESS in 43m 21s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/def9db83e8e24a27b64a424f8355f60f : SUCCESS in 1h 05m 33s\n- puppet-openstack-integration-7-scenario002-tempest-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/889707a0a21c48e99947e5f6d0b82e16 : SUCCESS in 37m 41s (non-voting)\n- puppet-openstack-integration-7-scenario002-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/0a14e925f8384385bdf6e7bf2f91636b : SUCCESS in 1h 19m 47s\n- puppet-openstack-litmus-7.32-centos-9-stream https://zuul.opendev.org/t/openstack/build/82105b322f5c4ba29ffe9f6658425d95 : SUCCESS in 16m 53s\n- puppet-openstack-litmus-7.32-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/6b7c50eb0938482ea731d2e3c62dd7b3 : SUCCESS in 11m 41s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/94d61ce1639944129b202bd51654922f : SUCCESS in 10m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"fe811945e7dce3f20a965f3eb6d85e14496c3583","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-10-27 17:52:52.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9df3bdc88b51c6bc813d134675008e8d7b4c8f9c","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2025-04-20 15:17:37.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"26b88c746d6d6e33aea69b20d57b9c7eaad59426","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2025-08-25 07:29:20.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8d4b00072cd4da2a68c186d547ef5ed91d20127b","revisions":{"099ec3434a4541bd0307c9caf57b3ac95caa4d67":{"kind":"REWORK","_number":1,"created":"2024-10-27 11:34:48.000000000","uploader":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"ref":"refs/changes/41/933541/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-gnocchi","ref":"refs/changes/41/933541/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/1"}}},"commit":{"parents":[{"commit":"7929bd422d02c45bfa9e334a3f52739f3d8ff9ef","subject":"Merge \"Expose configure_service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-gnocchi/commit/7929bd422d02c45bfa9e334a3f52739f3d8ff9ef"}]}],"author":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2024-10-27 11:02:51.000000000","tz":60},"committer":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2024-10-27 11:19:39.000000000","tz":60},"subject":"PROPOSAL: use hash for calling oslo libraries","message":"PROPOSAL: use hash for calling oslo libraries\n\nThe idea of this proposal is to initiate a discussion about\nhaving a simpler releationship betwen puppet oslo library and\nthe puppet modules used to configure a project.\nIf the community thinks this is a valuable idea it should be used\nin all modules for oslo::* and openstacklib::* calls.\n\nPros:\n- no need to update all modules if an oslo library changes a resource\n  (eg. new parameter in oslo::db does not need upgrade of gnocchi module)\n  which means less workload for puppet module developpers.\n- simpler upgrade procedure for operators (no need to have have all puppet modules\n  in sync with the used oslo library).\n- type checking is always consistent with the used oslo library (needs\n  the datatype defined in oslo library (second step, for simplicity\n  for this discussion I defined it as Hash).\n\nCons:\n- defining the db parameter as a hash is not so \u0027nice\u0027\n\nChange-Id: Iad90bde7e0fe38197dcd62cdd921bc1893d9111a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-gnocchi/commit/099ec3434a4541bd0307c9caf57b3ac95caa4d67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-gnocchi/commit/099ec3434a4541bd0307c9caf57b3ac95caa4d67"}]},"branch":"refs/heads/master"},"8d4b00072cd4da2a68c186d547ef5ed91d20127b":{"kind":"REWORK","_number":2,"created":"2024-10-27 11:53:33.000000000","uploader":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"ref":"refs/changes/41/933541/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-gnocchi","ref":"refs/changes/41/933541/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-gnocchi refs/changes/41/933541/2"}}},"commit":{"parents":[{"commit":"7929bd422d02c45bfa9e334a3f52739f3d8ff9ef","subject":"Merge \"Expose configure_service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-gnocchi/commit/7929bd422d02c45bfa9e334a3f52739f3d8ff9ef"}]}],"author":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2024-10-27 11:02:51.000000000","tz":60},"committer":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2024-10-27 11:53:12.000000000","tz":60},"subject":"PROPOSAL: use hash for calling oslo libraries","message":"PROPOSAL: use hash for calling oslo libraries\n\nThe idea of this proposal is to initiate a discussion about\nhaving a simpler releationship betwen puppet oslo library and\nthe puppet modules used to configure a project.\nIf the community thinks this is a valuable idea it should be used\nin all modules for oslo::* and openstacklib::* calls.\n\nPros:\n- no need to update all modules if an oslo library changes a resource\n  (eg. new parameter in oslo::db does not need upgrade of gnocchi module)\n  which means less workload for puppet module developpers.\n- simpler upgrade procedure for operators (no need to have have all puppet modules\n  in sync with the used oslo library).\n- type checking is always consistent with the used oslo library (needs\n  the datatype defined in oslo library (second step, for simplicity\n  for this discussion I defined it as Hash).\n\nCons:\n- defining the db parameter as a hash is not so \u0027nice\u0027\n\nChange-Id: Iad90bde7e0fe38197dcd62cdd921bc1893d9111a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-gnocchi/commit/8d4b00072cd4da2a68c186d547ef5ed91d20127b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-gnocchi/commit/8d4b00072cd4da2a68c186d547ef5ed91d20127b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{}}}]}