)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"a1f1e3a446705085a106e4c89c88d62c1c6a57f8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Defaults to \u0027keystone\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5ff596b6418d71726714ec69211352dd5f4b8db2"},{"line_number":14,"context_line":"Implements: blueprint option-to-configure-falvor-in-heat.conf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a961159_efcc2065","line":14,"updated":"2015-01-20 04:30:10.000000000","message":"that blueprint is misspelled. normally I wouldn\u0027t care but since it\u0027s a clickable link it should be right.","commit_id":"4c406c7d362a5d647c1bd106ab27e4c411914e1c"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"be626265741c62dc2765b6dda83cdca8de262bdd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Defaults to \u0027keystone\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5ff596b6418d71726714ec69211352dd5f4b8db2"},{"line_number":14,"context_line":"Implements: blueprint option-to-configure-falvor-in-heat.conf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a961159_d1e0d028","line":14,"updated":"2015-01-20 16:23:28.000000000","message":"still spelled wrong, should be flavor, not falvor","commit_id":"15bc34ecd2b7ff6b6e8b24d243ebfe7aea97521d"}],"manifests/init.pp":[{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"bd54e3285bae8de0fd7c4432bfa9ad1e9f13ad88","unresolved":false,"context_lines":[{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"# [*sql_connection*]"},{"line_number":151,"context_line":"#   Deprecated. Use database_connection instead."},{"line_number":152,"context_line":"#"},{"line_number":153,"context_line":"class heat("},{"line_number":154,"context_line":"  $auth_uri                    \u003d false,"},{"line_number":155,"context_line":"  $package_ensure              \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3a961159_fef96dc8","side":"PARENT","line":152,"updated":"2015-01-08 14:17:59.000000000","message":"Hum, can you move this doc just before « Deprecated Parameters » section?","commit_id":"50ae53a95b0bafdeced3b10a3ac687afcbda5942"},{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"bd54e3285bae8de0fd7c4432bfa9ad1e9f13ad88","unresolved":false,"context_lines":[{"line_number":445,"context_line":"  }"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"  heat_config {"},{"line_number":448,"context_line":"      \u0027paste_deploy/flavor\u0027:           value \u003d\u003e $flavor;"},{"line_number":449,"context_line":"  }"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3a961159_1ed719c0","line":448,"updated":"2015-01-08 14:17:59.000000000","message":"you should maybe encapsulate this heat_config in an « if $flavor { … } » no? Without this, the value of paste_deploy/flavor will be « undef », it\u0027s that intended ?\n\nIn default config flavor is http://docs.openstack.org/juno/config-reference/content/orchestration-configuring-api.html","commit_id":"05f9c537156c7c0189ef29ced594b8ca327571af"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"a1f1e3a446705085a106e4c89c88d62c1c6a57f8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"#   (optional) Specifies the Authentication method."},{"line_number":147,"context_line":"#   Set to \u0027standalone\u0027 to get Heat to work with a remote OpenStack"},{"line_number":148,"context_line":"#   Tested versions include 0.9 and 2.2"},{"line_number":149,"context_line":"#   Defaults to \u0027keystone\u0027"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"# \u003d\u003d\u003d Deprecated ParameterS"},{"line_number":152,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a961159_6f27501f","line":149,"updated":"2015-01-20 04:30:10.000000000","message":"looks to me like it properly default to undef","commit_id":"4c406c7d362a5d647c1bd106ab27e4c411914e1c"}],"spec/classes/heat_init_spec.rb":[{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"bd54e3285bae8de0fd7c4432bfa9ad1e9f13ad88","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    end"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  end"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  shared_examples_for \u0027rabbit without HA support (with backward compatibility)\u0027 do"},{"line_number":164,"context_line":"    it \u0027configures rabbit\u0027 do"},{"line_number":165,"context_line":"      should contain_heat_config(\u0027DEFAULT/rabbit_userid\u0027).with_value( params[:rabbit_userid] )"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3a961159_5e50c12b","side":"PARENT","line":162,"updated":"2015-01-08 14:17:59.000000000","message":"If you use a shared_examples_for you must update the context declaration. With only this, this spec test isn\u0027t launched (please take a look line 33 (heat shared_example) and in your case, it\u0027s maybe more appropriate to add you spec test inside « a heat base installation » shared_example, and not create a new one.","commit_id":"50ae53a95b0bafdeced3b10a3ac687afcbda5942"}]}
