)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5be0eae2c871cd4ecc32bea27146c14dc18f4a0d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  $public_url                \u003d \u0027http://127.0.0.1:8004/v1/%(tenant_id)s\u0027,"},{"line_number":152,"context_line":"  $admin_url                 \u003d \u0027http://127.0.0.1:8004/v1/%(tenant_id)s\u0027,"},{"line_number":153,"context_line":"  $internal_url              \u003d \u0027http://127.0.0.1:8004/v1/%(tenant_id)s\u0027,"},{"line_number":154,"context_line":"  $heat_stack_user_role      \u003d \u0027heat_stack_user\u0027,"},{"line_number":155,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":156,"context_line":"  $version                   \u003d undef,"},{"line_number":157,"context_line":"  $port                      \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba15a1d1_1c0b8725","line":154,"updated":"2015-09-23 23:56:19.000000000","message":"I want to note that this name really confused me because there is a keystone_user_role type but this is only managing a keystone_role resource. However I see that the heat config param name is heat_stack_user_role so this is probably the best name for this.","commit_id":"5e68769874ed7e1482cbd4ec9200effc0816a8d2"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5be0eae2c871cd4ecc32bea27146c14dc18f4a0d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"      Service \u003c| name \u003d\u003d \u0027heat-api\u0027 |\u003e"},{"line_number":252,"context_line":"  }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  if $heat_stack_user_role {"},{"line_number":255,"context_line":"    keystone_role { $heat_stack_user_role:"},{"line_number":256,"context_line":"      ensure \u003d\u003e present,"},{"line_number":257,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba15a1d1_591ef170","line":254,"updated":"2015-09-23 23:56:19.000000000","message":"The default value is set, so this is always going to run unless the user explicitly sets it to false. If we want to control whether the keystone_role gets created it would be better to add another parameter like manage_keystone_role","commit_id":"5e68769874ed7e1482cbd4ec9200effc0816a8d2"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"97e803f70fb56ca6ca8226f3376817a40b3bd02e","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    }"},{"line_number":265,"context_line":"    # if this is a keystone only node, we configure the role here"},{"line_number":266,"context_line":"    # but let engine.pp set the config file. A keystone only node"},{"line_number":267,"context_line":"    # will not have a heat.conf file. "},{"line_number":268,"context_line":"    keystone_role { $trusts_delegated_roles:"},{"line_number":269,"context_line":"      ensure \u003d\u003e present,"},{"line_number":270,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba15a1d1_c0f859c7","line":267,"updated":"2015-09-21 08:22:29.000000000","message":"Please remove whitespace","commit_id":"5e68769874ed7e1482cbd4ec9200effc0816a8d2"}]}