)]}'
{"manifests/engine.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"acbd1a68a1ac7764fc426bb261d57b25ca611b1e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":"# [*instance_connection_is_secure*]"},{"line_number":81,"context_line":"#   (Optional) Instance connection to CFN/CW API via https."},{"line_number":82,"context_line":"#   Defaults to 0"},{"line_number":83,"context_line":"#"},{"line_number":84,"context_line":"# [*instance_connection_https_validate_certificates*]"},{"line_number":85,"context_line":"#   (Optional) Instance connection to CFN/CW API validate certs if SSL is used."}],"source_content_type":"text/x-puppet","patch_set":18,"id":"ba8a016a_9c40f135","line":82,"updated":"2015-11-18 18:52:28.000000000","message":"should probably os_service_default these values","commit_id":"27a653b8b030adac74f9ae4711ede2f00af0b033"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"ceedf8194b821a6d863d50c688f31be9546fdd14","unresolved":false,"context_lines":[{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":"# [*instance_connection_is_secure*]"},{"line_number":81,"context_line":"#   (Optional) Instance connection to CFN/CW API via https."},{"line_number":82,"context_line":"#   Defaults to 0"},{"line_number":83,"context_line":"#"},{"line_number":84,"context_line":"# [*instance_connection_https_validate_certificates*]"},{"line_number":85,"context_line":"#   (Optional) Instance connection to CFN/CW API validate certs if SSL is used."}],"source_content_type":"text/x-puppet","patch_set":18,"id":"ba8a016a_15011d6a","line":82,"in_reply_to":"ba8a016a_9c40f135","updated":"2015-11-19 08:38:26.000000000","message":"Done please check patch set 20","commit_id":"27a653b8b030adac74f9ae4711ede2f00af0b033"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2b1f156dab71d16a303929b8805a9bf8de6b71c7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# [*max_template_size*]"},{"line_number":99,"context_line":"#   (Optional) Maximum raw byte size of any template."},{"line_number":100,"context_line":"#   Defaults to 524288"},{"line_number":101,"context_line":"#   "},{"line_number":102,"context_line":"# [*max_json_body_size*]"},{"line_number":103,"context_line":"#   (Optional) Maximum raw byte size of JSON request body."},{"line_number":104,"context_line":"#   Should be larger than max_template_size."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a2fa921_f8b3dbe7","line":101,"updated":"2015-10-12 13:15:19.000000000","message":"remove please empty spaces","commit_id":"0df109aa549bd0969e5aa9696be3a9eaccb7c25d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2b1f156dab71d16a303929b8805a9bf8de6b71c7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"#"},{"line_number":179,"context_line":"# [*database_max_pool_size*]"},{"line_number":180,"context_line":"#   (Optional) Maximum number of SQL connections to keep open in a pool."},{"line_number":181,"context_line":"#   Defaults to undef"},{"line_number":182,"context_line":"#"},{"line_number":183,"context_line":"# [*database_max_overflow*]"},{"line_number":184,"context_line":"#   (Optional) If set, use this value for max_overflow with SQLAlchemy."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a2fa921_78458bb1","line":181,"updated":"2015-10-12 13:15:19.000000000","message":"Please do not add those parameters here: https://review.openstack.org/#/c/227187/","commit_id":"0df109aa549bd0969e5aa9696be3a9eaccb7c25d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2b1f156dab71d16a303929b8805a9bf8de6b71c7","unresolved":false,"context_lines":[{"line_number":201,"context_line":"#   (Optional) Syslog facility to receive log lines."},{"line_number":202,"context_line":"#   Defaults to LOG_USER."},{"line_number":203,"context_line":"#"},{"line_number":204,"context_line":"# [*use_syslog_rfc_format*]"},{"line_number":205,"context_line":"#   (Optional) Enables or disables syslog rfc5424"},{"line_number":206,"context_line":"#   format for logging. If enabled, prefixes the MSG part of"},{"line_number":207,"context_line":"#   the syslog message with APP-NAME (RFC5424)."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a2fa921_18c6d716","line":204,"updated":"2015-10-12 13:15:19.000000000","message":"Take a look on: https://review.openstack.org/#/c/227810/\n\nUse a new class for adding new parameters.","commit_id":"0df109aa549bd0969e5aa9696be3a9eaccb7c25d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b29c3cd8e4def10807fa52fd960c570bcda8bd5c","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    \u0027keystone_authtoken/admin_password\u0027    : value \u003d\u003e $keystone_password, secret \u003d\u003e true;"},{"line_number":519,"context_line":"  }"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"  #CFN/CW API"},{"line_number":522,"context_line":"  heat_config {"},{"line_number":523,"context_line":"    \u0027DEFAULT/instance_connection_https_validate_certificates\u0027 : value \u003d\u003e $ic_https_validate_certs;"},{"line_number":524,"context_line":"    \u0027DEFAULT/instance_connection_is_secure\u0027                   : value \u003d\u003e $ic_is_secure;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a2fa921_7e46a950","line":521,"updated":"2015-10-13 09:42:01.000000000","message":"nit: we don\u0027t need this comment i think","commit_id":"4ba6ba2e15266965977224020327e612370bd348"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fdf8939c98cd7538d6377b2d8159c2963d69f1a5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"#   (Optional) Maximum raw byte size of any template."},{"line_number":100,"context_line":"#   Defaults to 524288"},{"line_number":101,"context_line":"#"},{"line_number":102,"context_line":"# [*max_json_body_size*]"},{"line_number":103,"context_line":"#   (Optional) Maximum raw byte size of JSON request body."},{"line_number":104,"context_line":"#   Should be larger than max_template_size."},{"line_number":105,"context_line":"#   Defaults to 1048576"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_fd0c8ded","line":102,"updated":"2015-10-16 13:44:24.000000000","message":"Looking at Heat source code, this is an option used by WSGI servers, that are used by Heat API, Heat API CFN and Heat API Cloudwatch.\n\nThis is not a big deal to put the option here I presume, it\u0027s just overloading init.pp which is something we try to avoid. On the other hand, we will have dupplicated parameters on 3 classes, with eventual conflicts.\n\nSo let\u0027s keep this option here.","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"bd4a2b2cc5bf0a9facec2aef951a96dfcfe66da8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"#   (Optional) Maximum raw byte size of any template."},{"line_number":100,"context_line":"#   Defaults to 524288"},{"line_number":101,"context_line":"#"},{"line_number":102,"context_line":"# [*max_json_body_size*]"},{"line_number":103,"context_line":"#   (Optional) Maximum raw byte size of JSON request body."},{"line_number":104,"context_line":"#   Should be larger than max_template_size."},{"line_number":105,"context_line":"#   Defaults to 1048576"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_f1411664","line":102,"in_reply_to":"5a2ca52d_fd0c8ded","updated":"2015-10-16 15:22:36.000000000","message":"noted","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fdf8939c98cd7538d6377b2d8159c2963d69f1a5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#   Should be larger than max_template_size."},{"line_number":105,"context_line":"#   Defaults to 1048576"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*max_resources_per_stack*]"},{"line_number":108,"context_line":"#   (Optional) Maximum resources allowed per top-level stack."},{"line_number":109,"context_line":"#   Defaults to 1000"},{"line_number":110,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_1d12a909","line":107,"updated":"2015-10-16 13:44:24.000000000","message":"this one is used by Heat Engine only, we can probably move it to the right class.\n\nI would like some confirmation from Heat developpers.","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"bd4a2b2cc5bf0a9facec2aef951a96dfcfe66da8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#   Should be larger than max_template_size."},{"line_number":105,"context_line":"#   Defaults to 1048576"},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*max_resources_per_stack*]"},{"line_number":108,"context_line":"#   (Optional) Maximum resources allowed per top-level stack."},{"line_number":109,"context_line":"#   Defaults to 1000"},{"line_number":110,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_5151ea34","line":107,"in_reply_to":"5a2ca52d_1d12a909","updated":"2015-10-16 15:22:36.000000000","message":"ok, will confirm with developers","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fdf8939c98cd7538d6377b2d8159c2963d69f1a5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"#   Defaults to 1000"},{"line_number":110,"context_line":"#"},{"line_number":111,"context_line":"# [*notification_driver*]"},{"line_number":112,"context_line":"#   (Optional) Driver or drivers to handle sending notifications."},{"line_number":113,"context_line":"#   Defaults to undef"},{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":"# [*ic_https_validate_certs*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_bdfb75c0","line":112,"updated":"2015-10-16 13:44:24.000000000","message":"Please stay consistent with puppet-nova for the parameter description and add \"Value can be a string or a list.\"\n\nIt\u0027s really helpful for deployers.","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"bd4a2b2cc5bf0a9facec2aef951a96dfcfe66da8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"#   Defaults to 1000"},{"line_number":110,"context_line":"#"},{"line_number":111,"context_line":"# [*notification_driver*]"},{"line_number":112,"context_line":"#   (Optional) Driver or drivers to handle sending notifications."},{"line_number":113,"context_line":"#   Defaults to undef"},{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":"# [*ic_https_validate_certs*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_717f46ab","line":112,"in_reply_to":"5a2ca52d_bdfb75c0","updated":"2015-10-16 15:22:36.000000000","message":"ok, will do","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fdf8939c98cd7538d6377b2d8159c2963d69f1a5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"#   (Optional) Driver or drivers to handle sending notifications."},{"line_number":113,"context_line":"#   Defaults to undef"},{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":"# [*ic_https_validate_certs*]"},{"line_number":116,"context_line":"#   (Optional) Instance connection to CFN/CW API validate certs if SSL is used."},{"line_number":117,"context_line":"#   Defaults to 1"},{"line_number":118,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_ddf8b1c5","line":115,"updated":"2015-10-16 13:44:24.000000000","message":"I don\u0027t find this option anywhere.","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"bd4a2b2cc5bf0a9facec2aef951a96dfcfe66da8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"#   (Optional) Driver or drivers to handle sending notifications."},{"line_number":113,"context_line":"#   Defaults to undef"},{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":"# [*ic_https_validate_certs*]"},{"line_number":116,"context_line":"#   (Optional) Instance connection to CFN/CW API validate certs if SSL is used."},{"line_number":117,"context_line":"#   Defaults to 1"},{"line_number":118,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_117052db","line":115,"in_reply_to":"5a2ca52d_ddf8b1c5","updated":"2015-10-16 15:22:36.000000000","message":"it is instance_connection_https_validate_certificates, i abbreviated it because i believe it is too long for puppet class parameter, is it ok? or i should use always the full name? \n\nalso i found that it is mentioned in heat/engine/clients/os/nova.py, now i think it can be placed into engine class, i can also confirm this with Heat developers. what do you think?","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fdf8939c98cd7538d6377b2d8159c2963d69f1a5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"#   (Optional) Instance connection to CFN/CW API validate certs if SSL is used."},{"line_number":117,"context_line":"#   Defaults to 1"},{"line_number":118,"context_line":"#"},{"line_number":119,"context_line":"# [*ic_is_secure*]"},{"line_number":120,"context_line":"#   (Optional) Instance connection to CFN/CW API via https."},{"line_number":121,"context_line":"#   Defaults to 0"},{"line_number":122,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_7d015dae","line":119,"updated":"2015-10-16 13:44:24.000000000","message":"ditto","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"bd4a2b2cc5bf0a9facec2aef951a96dfcfe66da8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"#   (Optional) Instance connection to CFN/CW API validate certs if SSL is used."},{"line_number":117,"context_line":"#   Defaults to 1"},{"line_number":118,"context_line":"#"},{"line_number":119,"context_line":"# [*ic_is_secure*]"},{"line_number":120,"context_line":"#   (Optional) Instance connection to CFN/CW API via https."},{"line_number":121,"context_line":"#   Defaults to 0"},{"line_number":122,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_31654e1d","line":119,"in_reply_to":"5a2ca52d_7d015dae","updated":"2015-10-16 15:22:36.000000000","message":"the same as above","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fdf8939c98cd7538d6377b2d8159c2963d69f1a5","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:    value \u003d\u003e $keystone_password, secret \u003d\u003e true;"},{"line_number":519,"context_line":"  }"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"  heat_config {"},{"line_number":522,"context_line":"    \u0027DEFAULT/instance_connection_https_validate_certificates\u0027 : value \u003d\u003e $ic_https_validate_certs;"},{"line_number":523,"context_line":"    \u0027DEFAULT/instance_connection_is_secure\u0027                   : value \u003d\u003e $ic_is_secure;"},{"line_number":524,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_9dfeb9ac","line":521,"updated":"2015-10-16 13:44:24.000000000","message":"why do you create anoter heat_config resource? Why not using the previous one?","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"13b30c7771491a35acc8a051628fbe6232cff6b8","unresolved":false,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"  heat_config {"},{"line_number":522,"context_line":"    \u0027DEFAULT/instance_connection_https_validate_certificates\u0027 : value \u003d\u003e $ic_https_validate_certs;"},{"line_number":523,"context_line":"    \u0027DEFAULT/instance_connection_is_secure\u0027                   : value \u003d\u003e $ic_is_secure;"},{"line_number":524,"context_line":"  }"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"  if $sql_connection {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_af3192ee","line":523,"updated":"2015-10-13 16:49:31.000000000","message":"nit: alignment should be set by \u0027value\u0027 not by \u0027:\u0027","commit_id":"413d99ac8dab636caedb87aa19b8e2d4879fedb4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"aae8b31946f2d63f61441e63c416177f505032aa","unresolved":false,"context_lines":[{"line_number":302,"context_line":"  $enable_stack_adopt                 \u003d undef,"},{"line_number":303,"context_line":"  $enable_stack_abandon               \u003d undef,"},{"line_number":304,"context_line":"  $sync_db                            \u003d undef,"},{"line_number":305,"context_line":"  $max_template_size                  \u003d 524288,"},{"line_number":306,"context_line":"  $max_json_body_size                 \u003d 1048576,"},{"line_number":307,"context_line":"  $notification_driver                \u003d undef,"},{"line_number":308,"context_line":"  # Deprecated parameters"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a29b11f_807d8cb3","line":305,"updated":"2015-10-24 19:08:22.000000000","message":"can we use $::os_service_default ?","commit_id":"ada6b5b6bc930f23a39427aaef60e3c68c6b66fa"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"d55536a9d8fec1c729a4af22f8ca2b7692d928f6","unresolved":false,"context_lines":[{"line_number":302,"context_line":"  $enable_stack_adopt                 \u003d undef,"},{"line_number":303,"context_line":"  $enable_stack_abandon               \u003d undef,"},{"line_number":304,"context_line":"  $sync_db                            \u003d undef,"},{"line_number":305,"context_line":"  $max_template_size                  \u003d 524288,"},{"line_number":306,"context_line":"  $max_json_body_size                 \u003d 1048576,"},{"line_number":307,"context_line":"  $notification_driver                \u003d undef,"},{"line_number":308,"context_line":"  # Deprecated parameters"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba8a016a_0a3e21b8","line":305,"in_reply_to":"3a29b11f_807d8cb3","updated":"2015-11-18 03:39:49.000000000","message":"Seems there are issues with it","commit_id":"ada6b5b6bc930f23a39427aaef60e3c68c6b66fa"}],"spec/classes/heat_init_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b29c3cd8e4def10807fa52fd960c570bcda8bd5c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"      is_expected.to contain_heat_config(\u0027DEFAULT/instance_connection_https_validate_certificates\u0027).with_value( params[:ic_https_validate_certs] )"},{"line_number":189,"context_line":"    end"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    shared_examples_for \u0027without notification_driver set\u0027 do"},{"line_number":192,"context_line":"      it \u0027doesnt have notification_driver set by default\u0027 do"},{"line_number":193,"context_line":"        is_expected.to contain_heat_config(\u0027DEFAULT/notification_driver\u0027).with_enure(\u0027absent\u0027)"},{"line_number":194,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a2fa921_74480b88","line":191,"updated":"2015-10-13 09:42:01.000000000","message":"i think, we don\u0027t need separate shared example for this option, it can be placed just in \u0027a heat base installation\u0027","commit_id":"4ba6ba2e15266965977224020327e612370bd348"}]}