)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fc68e7404f0c9107ab80aceccd6bfff2b46dc312","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   Defaults to \u00278004\u0027."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*workers*]"},{"line_number":28,"context_line":"#   (Optional) The number of workers to spawn"},{"line_number":29,"context_line":"#   Defaults to \u00270\u0027."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*use_ssl*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_cb01e7b0","line":28,"updated":"2015-10-21 10:41:53.000000000","message":"it is out of scope patch description","commit_id":"a6430996f77c0d3f31ab9343e192bda5e51492e9"}],"manifests/engine.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5f7c151e11d6cacdfd9ad62d62a14dd8a841f05f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_7c9c1f5d","line":89,"updated":"2015-10-21 09:14:41.000000000","message":"Should we use at least 1 here? I\u0027m not sure that heat-engine will start and work correctly if this value is 0","commit_id":"a6430996f77c0d3f31ab9343e192bda5e51492e9"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"00165f72995a80cfb2cf0f2e1fcb8277b58531c5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_b07bb68b","line":89,"in_reply_to":"3a29b11f_7c9c1f5d","updated":"2015-10-21 10:17:10.000000000","message":"No, 0 is the correct default value. Check out the other classes, they also all default to 0.","commit_id":"a6430996f77c0d3f31ab9343e192bda5e51492e9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fc68e7404f0c9107ab80aceccd6bfff2b46dc312","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  heat_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/auth_encryption_key\u0027                 : value \u003d\u003e $auth_encryption_key;"},{"line_number":138,"context_line":"    \u0027DEFAULT/engine_workers\u0027                      : value \u003d\u003e $workers;"},{"line_number":139,"context_line":"    \u0027DEFAULT/heat_stack_user_role\u0027                : value \u003d\u003e $heat_stack_user_role;"},{"line_number":140,"context_line":"    \u0027DEFAULT/heat_metadata_server_url\u0027            : value \u003d\u003e $heat_metadata_server_url;"},{"line_number":141,"context_line":"    \u0027DEFAULT/heat_waitcondition_server_url\u0027       : value \u003d\u003e $heat_waitcondition_server_url;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_6bcd33b6","line":138,"updated":"2015-10-21 10:41:53.000000000","message":"i can\u0027t find such option in docs and source code. Can you provide link to docs or code?","commit_id":"a6430996f77c0d3f31ab9343e192bda5e51492e9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c35b8927372391478e10a693e1d8ce001b963b9e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*workers*]"},{"line_number":19,"context_line":"#   (Optional) The number of workers to spawn"},{"line_number":20,"context_line":"#   Defaults to \u00270\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*manage_service*]"},{"line_number":23,"context_line":"#   (optional) Whether the service should be managed by Puppet."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_9c71d178","line":20,"updated":"2015-11-18 18:57:19.000000000","message":"So based on the config docs, the new default for liberty is 8 where as the previous was 0. That being said, this should be configured using the $::os_service_default fact as that is the accepted way going forward for new values. We are trying to prevent these types of values from being in puppet code and becoming out of sync between versions. $::os_service_default will remove the setting from the config file thus relying on the services\u0027 default for the configuration. Only if this is specified by an end user would we put a value in the config, thus preventing this type of situation where it changes between releases.  Can you please switch this to leverage the $::os_service_default as the default value rather than 0?","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"df70c8bc96a8913d5c3533c4c8d667e3948f08fa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*workers*]"},{"line_number":19,"context_line":"#   (Optional) The number of workers to spawn"},{"line_number":20,"context_line":"#   Defaults to \u00270\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*manage_service*]"},{"line_number":23,"context_line":"#   (optional) Whether the service should be managed by Puppet."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_12b3520b","line":20,"updated":"2015-10-22 13:42:01.000000000","message":"the default number should be equal \"1\", otherwise we will get unworkable heat engine!","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"5925b941cff960acd68f0930bccafb49fe235169","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*workers*]"},{"line_number":19,"context_line":"#   (Optional) The number of workers to spawn"},{"line_number":20,"context_line":"#   Defaults to \u00270\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*manage_service*]"},{"line_number":23,"context_line":"#   (optional) Whether the service should be managed by Puppet."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_b7cfdb54","line":20,"in_reply_to":"3a29b11f_12b3520b","updated":"2015-10-22 21:58:13.000000000","message":"That is not correct, please test yourself before giving a -1","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2777c4d7cebe73d35dcbab13429f03d8260b9551","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*workers*]"},{"line_number":19,"context_line":"#   (Optional) The number of workers to spawn"},{"line_number":20,"context_line":"#   Defaults to \u00270\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*manage_service*]"},{"line_number":23,"context_line":"#   (optional) Whether the service should be managed by Puppet."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_f3e0182b","line":20,"in_reply_to":"ba8a016a_10d032f5","updated":"2015-11-19 15:32:07.000000000","message":"We can, but this value is wrong for liberty anyway based on the docs. It should be undef to follow the old style anyway. I\u0027d rather not put a patch in with an incorrect value.","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"67d9874c9d4afd70410735d3f0d96162e847ba52","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*workers*]"},{"line_number":19,"context_line":"#   (Optional) The number of workers to spawn"},{"line_number":20,"context_line":"#   Defaults to \u00270\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*manage_service*]"},{"line_number":23,"context_line":"#   (optional) Whether the service should be managed by Puppet."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_10d032f5","line":20,"in_reply_to":"ba8a016a_9c71d178","updated":"2015-11-19 15:24:42.000000000","message":"Alex,\n\nwe can accept all old patches with old style. Because for heat this feature is not implemented yet.","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"782b770ea59e55f0f1dc946a7ce89aa4bb5806d6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*workers*]"},{"line_number":19,"context_line":"#   (Optional) The number of workers to spawn"},{"line_number":20,"context_line":"#   Defaults to \u00270\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*manage_service*]"},{"line_number":23,"context_line":"#   (optional) Whether the service should be managed by Puppet."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_fee53f08","line":20,"in_reply_to":"ba8a016a_f3e0182b","updated":"2015-11-19 15:49:03.000000000","message":"Oops, we already have patch for heat. So, yes, i\u0027d prefer using $::os_service_default too.\n\nhttps://review.openstack.org/#/c/246891/1\n\nPlease rebase your change.","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"df70c8bc96a8913d5c3533c4c8d667e3948f08fa","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_92c76263","line":89,"updated":"2015-10-22 13:42:01.000000000","message":"same","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"67d9874c9d4afd70410735d3f0d96162e847ba52","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_500eba8c","line":89,"in_reply_to":"1a26ad4f_fb31480c","updated":"2015-11-19 15:24:42.000000000","message":"So, if it is by default equals to \u00271\u0027, i guess you can use $::processorcount","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"9638ca78c4f795adbf3e60f1e133d95a743416de","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_be80dd8c","line":89,"in_reply_to":"3a29b11f_379e5c63","updated":"2015-10-26 02:48:40.000000000","message":"Hi Sergey,\n\nMaybe this has changed in Liberty. I\u0027m using Kilo and setting this to 0 works. I could set the default to the fact $::processorcount?","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"394e1511285be86db5ba1e5c672147b99a8c59d2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_d7e5b7db","line":89,"in_reply_to":"3a29b11f_92c76263","updated":"2015-10-22 21:57:34.000000000","message":"Sergey, 0 is the correct default here. It is also the same defaults as we use for the api* services. \n\nFeel free to test it out on a heat-engine. 0 is the value we have been using in production for the past year or so so I know it works.","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"300e115f19259cc5e60d24558eb474c2c895596f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a26ad4f_fb31480c","line":89,"in_reply_to":"3a29b11f_be80dd8c","updated":"2015-10-29 23:57:21.000000000","message":"Just remove this value from your config and it will start using number of processors (https://github.com/openstack/heat/blob/stable/kilo/heat/common/config.py#L87-L89), i.e. default value for this options is calculated in this way for kilo :)\n\nIn kilo we had openstack code in tree and there was no oslo service library, so maybe it\u0027s reason of different behavior.\nHowever I can not find real differences in code...\nNeed to recheck again on kilo devstack.","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"6b4aecd59b0854a8512294bc3102950b39c52b6e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  $package_ensure                      \u003d \u0027present\u0027,"},{"line_number":87,"context_line":"  $manage_service                      \u003d true,"},{"line_number":88,"context_line":"  $enabled                             \u003d true,"},{"line_number":89,"context_line":"  $workers                             \u003d \u00270\u0027,"},{"line_number":90,"context_line":"  $heat_stack_user_role                \u003d \u0027heat_stack_user\u0027,"},{"line_number":91,"context_line":"  $heat_metadata_server_url            \u003d \u0027http://127.0.0.1:8000\u0027,"},{"line_number":92,"context_line":"  $heat_waitcondition_server_url       \u003d \u0027http://127.0.0.1:8000/v1/waitcondition\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_379e5c63","line":89,"in_reply_to":"3a29b11f_d7e5b7db","updated":"2015-10-23 09:55:25.000000000","message":"Sam: thank you for your understanding.\n However, before post my comment here I have checked it on my local devstack and can say, that this default does not work.\n\nLet me clarify your experience:\n - this value in Heat config NEVER was equal 0. Previous default were equal 1.[1] Last changes remove default value number and now it is calculated base on numbers of CPU. [2]\n\nNow about your value - \"0\". Let\u0027s look on oslo_service code [3], [4]:\nwhere one process will be launched if workers is None or equal 1 [5].\nbut in your case it\u0027s \"0\" so it will try to start requested number of child [6]... and will  launch anything.\n\nCorresponding links:\n[1] https://github.com/openstack/heat/blob/stable/juno/heat/common/config.py#L82\n[2] https://github.com/openstack/heat/blob/master/heat/common/config.py#L85\n[3] https://github.com/openstack/heat/blob/master/heat/cmd/engine.py#L31\n[4] https://github.com/openstack/heat/blob/master/heat/cmd/engine.py#L69-L70\n[5] https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L658-L663\n[6] https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L445-L458\n\n\n\nif I am wrong, will be glad to here your explanation.","commit_id":"6d45388d39a1b186c2b3c8e09df178d76f4059d6"}]}
