)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"aa7c65878a527f300a036d8188667bd197678171","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $enabled           \u003d true,"},{"line_number":53,"context_line":"  $bind_host         \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $bind_port         \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $workers           \u003d \u00270\u0027,"},{"line_number":56,"context_line":"  $use_ssl           \u003d false,"},{"line_number":57,"context_line":"  $cert_file         \u003d $::os_service_default,"},{"line_number":58,"context_line":"  $key_file          \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_5b12fa63","line":55,"updated":"2015-12-04 14:17:04.000000000","message":"why you leave it with default?","commit_id":"208aa5702ff449bca7ed1fbae4f7661f5a1a83fb"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"72e9a18aeb67febb032b4d65af1995d0668b69be","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $enabled           \u003d true,"},{"line_number":53,"context_line":"  $bind_host         \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $bind_port         \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $workers           \u003d \u00270\u0027,"},{"line_number":56,"context_line":"  $use_ssl           \u003d false,"},{"line_number":57,"context_line":"  $cert_file         \u003d $::os_service_default,"},{"line_number":58,"context_line":"  $key_file          \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_b263c6db","line":55,"in_reply_to":"7a740942_51e739e4","updated":"2015-12-07 08:43:59.000000000","message":"It seems that docs are incorrect, I checked this also with Heat developers, and we found that:\n\nif workers - 0, will be launched 1 Heat process\n\nif workers parameter is not specified in config file (service default), number of processes will be equal to number of CPUs, also this can be confirmed looking to code - https://github.com/openstack/heat/blob/master/heat/common/wsgi.py#L80","commit_id":"208aa5702ff449bca7ed1fbae4f7661f5a1a83fb"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"322cdd035cd60045cffa59172f9e51d2cbc68cc2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $enabled           \u003d true,"},{"line_number":53,"context_line":"  $bind_host         \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $bind_port         \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $workers           \u003d \u00270\u0027,"},{"line_number":56,"context_line":"  $use_ssl           \u003d false,"},{"line_number":57,"context_line":"  $cert_file         \u003d $::os_service_default,"},{"line_number":58,"context_line":"  $key_file          \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_51e739e4","line":55,"in_reply_to":"7a740942_5b12fa63","updated":"2015-12-04 14:35:34.000000000","message":"according to http://docs.openstack.org/liberty/config-reference/content/orchestration-configuring-api.html default value is 4, so this one is differs from default","commit_id":"208aa5702ff449bca7ed1fbae4f7661f5a1a83fb"}],"manifests/init.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"be4f6a501ea3e8365b7c57194a6ec3bb3976eca1","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  $keystone_ec2_uri                   \u003d \u0027http://127.0.0.1:5000/v2.0/ec2tokens\u0027,"},{"line_number":263,"context_line":"  $rpc_backend                        \u003d $::os_service_default,"},{"line_number":264,"context_line":"  $rpc_response_timeout               \u003d $::os_service_default,"},{"line_number":265,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"},{"line_number":266,"context_line":"  $rabbit_port                        \u003d $::os_service_default,"},{"line_number":267,"context_line":"  $rabbit_hosts                       \u003d $::os_service_default,"},{"line_number":268,"context_line":"  $rabbit_userid                      \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"da6ed579_9496893c","line":265,"range":{"start_line":265,"start_character":45,"end_line":265,"end_character":46},"updated":"2016-01-14 13:47:57.000000000","message":"this can be $::os_service_default","commit_id":"e3a607ac4cacd6e9d2fbfc34358415128f36bcf7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"d30ea4d3fd7521bf0afce2010508c49158a6fe7f","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  $keystone_ec2_uri                   \u003d \u0027http://127.0.0.1:5000/v2.0/ec2tokens\u0027,"},{"line_number":263,"context_line":"  $rpc_backend                        \u003d $::os_service_default,"},{"line_number":264,"context_line":"  $rpc_response_timeout               \u003d $::os_service_default,"},{"line_number":265,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"},{"line_number":266,"context_line":"  $rabbit_port                        \u003d $::os_service_default,"},{"line_number":267,"context_line":"  $rabbit_hosts                       \u003d $::os_service_default,"},{"line_number":268,"context_line":"  $rabbit_userid                      \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a68dd71_21782fc4","line":265,"range":{"start_line":265,"start_character":45,"end_line":265,"end_character":46},"in_reply_to":"da6ed579_9496893c","updated":"2016-01-21 09:26:54.000000000","message":"Done","commit_id":"e3a607ac4cacd6e9d2fbfc34358415128f36bcf7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"be4f6a501ea3e8365b7c57194a6ec3bb3976eca1","unresolved":false,"context_lines":[{"line_number":266,"context_line":"  $rabbit_port                        \u003d $::os_service_default,"},{"line_number":267,"context_line":"  $rabbit_hosts                       \u003d $::os_service_default,"},{"line_number":268,"context_line":"  $rabbit_userid                      \u003d $::os_service_default,"},{"line_number":269,"context_line":"  $rabbit_password                    \u003d \u0027\u0027,"},{"line_number":270,"context_line":"  $rabbit_virtual_host                \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $rabbit_ha_queues                   \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $rabbit_heartbeat_timeout_threshold \u003d 0,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"da6ed579_54cc9169","line":269,"range":{"start_line":269,"start_character":3,"end_line":269,"end_character":18},"updated":"2016-01-14 13:47:57.000000000","message":"same here","commit_id":"e3a607ac4cacd6e9d2fbfc34358415128f36bcf7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"d30ea4d3fd7521bf0afce2010508c49158a6fe7f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"  $rabbit_port                        \u003d $::os_service_default,"},{"line_number":267,"context_line":"  $rabbit_hosts                       \u003d $::os_service_default,"},{"line_number":268,"context_line":"  $rabbit_userid                      \u003d $::os_service_default,"},{"line_number":269,"context_line":"  $rabbit_password                    \u003d \u0027\u0027,"},{"line_number":270,"context_line":"  $rabbit_virtual_host                \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $rabbit_ha_queues                   \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $rabbit_heartbeat_timeout_threshold \u003d 0,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a68dd71_417523c9","line":269,"range":{"start_line":269,"start_character":3,"end_line":269,"end_character":18},"in_reply_to":"da6ed579_54cc9169","updated":"2016-01-21 09:26:54.000000000","message":"Done","commit_id":"e3a607ac4cacd6e9d2fbfc34358415128f36bcf7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"be4f6a501ea3e8365b7c57194a6ec3bb3976eca1","unresolved":false,"context_lines":[{"line_number":269,"context_line":"  $rabbit_password                    \u003d \u0027\u0027,"},{"line_number":270,"context_line":"  $rabbit_virtual_host                \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $rabbit_ha_queues                   \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $rabbit_heartbeat_timeout_threshold \u003d 0,"},{"line_number":273,"context_line":"  $rabbit_heartbeat_rate              \u003d $::os_service_default,"},{"line_number":274,"context_line":"  $rabbit_use_ssl                     \u003d $::os_service_default,"},{"line_number":275,"context_line":"  $kombu_ssl_ca_certs                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"da6ed579_74d0b5f6","line":272,"range":{"start_line":272,"start_character":3,"end_line":272,"end_character":37},"updated":"2016-01-14 13:47:57.000000000","message":"same here","commit_id":"e3a607ac4cacd6e9d2fbfc34358415128f36bcf7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"d30ea4d3fd7521bf0afce2010508c49158a6fe7f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"  $rabbit_password                    \u003d \u0027\u0027,"},{"line_number":270,"context_line":"  $rabbit_virtual_host                \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $rabbit_ha_queues                   \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $rabbit_heartbeat_timeout_threshold \u003d 0,"},{"line_number":273,"context_line":"  $rabbit_heartbeat_rate              \u003d $::os_service_default,"},{"line_number":274,"context_line":"  $rabbit_use_ssl                     \u003d $::os_service_default,"},{"line_number":275,"context_line":"  $kombu_ssl_ca_certs                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a68dd71_e106971f","line":272,"range":{"start_line":272,"start_character":3,"end_line":272,"end_character":37},"in_reply_to":"da6ed579_74d0b5f6","updated":"2016-01-21 09:26:54.000000000","message":"according to documentation this is experimental feature, thats why it is kept disabled, i checked in other projects it is disabled too, so lets keep it as it is","commit_id":"e3a607ac4cacd6e9d2fbfc34358415128f36bcf7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"5aaa11fe693b48509b5a6f94288cb971007643c2","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e $rabbit_ha_queues;"},{"line_number":373,"context_line":"      }"},{"line_number":374,"context_line":"    }"},{"line_number":375,"context_line":"    warning(\u0027Default value for rabbit_heartbeat_timeout_threshold parameter is different from OpenStack project defaults\u0027)"},{"line_number":376,"context_line":"    heat_config {"},{"line_number":377,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"},{"line_number":378,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a68dd71_947ae086","line":375,"updated":"2016-01-25 10:16:35.000000000","message":"rabbit_heartbeat_timeout_threshold - this option is experimental according to https://github.com/openstack/oslo.messaging/blob/a84412dd1623a4e14c47734dfb1d769536f30e1e/oslo_messaging/_drivers/impl_rabbit.py#L153-L157\n\ninitially it was disabled (equal to 0), so i decided to leave it as it is.","commit_id":"a4e5987d5740bc5ef3d3403bafd0816fbdb68b42"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4e093633315f2d0facb2a32fa74235693234f98d","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e $rabbit_ha_queues;"},{"line_number":373,"context_line":"      }"},{"line_number":374,"context_line":"    }"},{"line_number":375,"context_line":"    warning(\u0027Default value for rabbit_heartbeat_timeout_threshold parameter is different from OpenStack project defaults\u0027)"},{"line_number":376,"context_line":"    heat_config {"},{"line_number":377,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"},{"line_number":378,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a68dd71_9e7bcdbd","line":375,"in_reply_to":"9a68dd71_947ae086","updated":"2016-01-25 15:36:07.000000000","message":"Should update this to only print if it is still set to the class default value. We shouldn\u0027t throw warnings all the time.","commit_id":"a4e5987d5740bc5ef3d3403bafd0816fbdb68b42"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"a59ebd1aaab21bcbdd75d884fec9d07fe1d98375","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e $rabbit_ha_queues;"},{"line_number":373,"context_line":"      }"},{"line_number":374,"context_line":"    }"},{"line_number":375,"context_line":"    warning(\u0027Default value for rabbit_heartbeat_timeout_threshold parameter is different from OpenStack project defaults\u0027)"},{"line_number":376,"context_line":"    heat_config {"},{"line_number":377,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"},{"line_number":378,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"9a68dd71_0aaa3785","line":375,"in_reply_to":"9a68dd71_9e7bcdbd","updated":"2016-01-25 16:31:05.000000000","message":"fixed in patch set 16","commit_id":"a4e5987d5740bc5ef3d3403bafd0816fbdb68b42"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4ec2dd27fd510aedefc4b957afd0410ca5ffbb91","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e $rabbit_ha_queues;"},{"line_number":373,"context_line":"      }"},{"line_number":374,"context_line":"    }"},{"line_number":375,"context_line":"    notice(\u0027Default value for rabbit_heartbeat_timeout_threshold parameter is different from OpenStack project defaults\u0027)"},{"line_number":376,"context_line":"    heat_config {"},{"line_number":377,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"},{"line_number":378,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9a68dd71_aa00cb02","line":375,"updated":"2016-01-25 16:38:58.000000000","message":"I didn\u0027t mean switch it to notice, i meant wrap it in a check so we only do this if the setting is what we have as a default for the class.  So if someone changes it to to match the project defaults, we don\u0027t print anything.  The next step would be to change it in the N cycle to be $::os_service_default\n\nif $rabbit_heartbeat_timeout_threadhold \u003d\u003d 0 {\n  warning(\u0027...\u0027)\n}","commit_id":"a06b50a2721a1971971be99ce3996899bf4db00f"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"51e83f9a0cfca357924effcb4e3b8d473760b972","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e $rabbit_ha_queues;"},{"line_number":373,"context_line":"      }"},{"line_number":374,"context_line":"    }"},{"line_number":375,"context_line":"    notice(\u0027Default value for rabbit_heartbeat_timeout_threshold parameter is different from OpenStack project defaults\u0027)"},{"line_number":376,"context_line":"    heat_config {"},{"line_number":377,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"},{"line_number":378,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9a68dd71_101fc65b","line":375,"in_reply_to":"9a68dd71_aa00cb02","updated":"2016-01-25 16:54:38.000000000","message":"got it now, done","commit_id":"a06b50a2721a1971971be99ce3996899bf4db00f"}],"spec/classes/heat_api_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"af61b1b23aaf0816bc26ee54e4f6ec7257bb7ffc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      :manage_service \u003d\u003e true,"},{"line_number":8,"context_line":"      :bind_host      \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":9,"context_line":"      :bind_port      \u003d\u003e \u00271234\u0027,"},{"line_number":10,"context_line":"      :workers        \u003d\u003e \u0027SERVICE DEFAULT\u0027 }"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  shared_examples_for \u0027heat-api\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7a740942_b61b6580","line":10,"updated":"2015-12-08 14:51:33.000000000","message":"Should not be \u0027\u003cSERVICE DEFAULT\u003e\u0027 ?","commit_id":"db822552d5f0fdc2f8679225b5a4b8701f0af055"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"88f33fab8f97fd55f41e218dbd6e5a9414e55770","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      :manage_service \u003d\u003e true,"},{"line_number":8,"context_line":"      :bind_host      \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":9,"context_line":"      :bind_port      \u003d\u003e \u00271234\u0027,"},{"line_number":10,"context_line":"      :workers        \u003d\u003e \u0027SERVICE DEFAULT\u0027 }"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  shared_examples_for \u0027heat-api\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7a740942_229acb6e","line":10,"in_reply_to":"7a740942_b61b6580","updated":"2015-12-08 15:37:53.000000000","message":"oh.. my bad,\n\n done!","commit_id":"db822552d5f0fdc2f8679225b5a4b8701f0af055"}]}
