)]}'
{"manifests/engine.pp":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"41dd3ff4d38c57744cb979e03385af2e72df3230","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#   Defaults to $::os_service_default"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*heat_trustee_user*]"},{"line_number":53,"context_line":"#   (Optional) The name of the trustee user."},{"line_number":54,"context_line":"#   Defaults to $::heat::keystone_user."},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"# [*heat_trustee_password*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_c21f5106","line":53,"range":{"start_line":53,"start_character":14,"end_line":53,"end_character":15},"updated":"2016-01-14 17:37:44.000000000","message":"Name of the trustee user - this is the user used by heat when delegating via trusts for deferred authentication.  Required when using deferred_auth_method\u003d\u003dtrusts, which is the default.  This may be the heat service user, or some other user.","commit_id":"13c72a10857f3eb0b93dcfee047c9417aabd5d12"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"41dd3ff4d38c57744cb979e03385af2e72df3230","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#   Defaults to $::heat::keystone_password."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*heat_trustee_domain*]"},{"line_number":61,"context_line":"#   (Optional) The trustee domain"},{"line_number":62,"context_line":"#   Defaults to \u0027default\u0027."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*default_software_config_transport*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_02b7a9f5","line":61,"range":{"start_line":61,"start_character":13,"end_line":61,"end_character":14},"updated":"2016-01-14 17:37:44.000000000","message":"The domain for the trustee user","commit_id":"13c72a10857f3eb0b93dcfee047c9417aabd5d12"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"0e09cb0ac01fa7498ae55d8cee61b39efc3c2d9d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*heat_trustee_domain*]"},{"line_number":61,"context_line":"#   (Optional) The trustee domain"},{"line_number":62,"context_line":"#   Defaults to \u0027default\u0027."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*default_software_config_transport*]"},{"line_number":65,"context_line":"#   (optional) Template default for how the server should receive the metadata"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_a7e2fd9d","line":62,"updated":"2016-01-12 15:45:17.000000000","message":"@Steven, I am sure you have suggestion to get a better documentation for these heat_trustee_* parameters? ;-)","commit_id":"13c72a10857f3eb0b93dcfee047c9417aabd5d12"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"584e664a522d75f577eba63671ad1d0b15cd5408","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  $instance_connection_is_secure                   \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $instance_connection_https_validate_certificates \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $max_resources_per_stack                         \u003d $::os_service_default,"},{"line_number":124,"context_line":") {"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  include ::heat::deps"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_5524c2ad","line":124,"range":{"start_line":124,"start_character":2,"end_line":124,"end_character":3},"updated":"2016-01-13 17:46:48.000000000","message":"as we used some parameter defaults from another class, do we need add inherits heat?","commit_id":"13c72a10857f3eb0b93dcfee047c9417aabd5d12"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"7c49227e0bde9334227e6baa33cf636d1bb55fec","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  $instance_connection_is_secure                   \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $instance_connection_https_validate_certificates \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $max_resources_per_stack                         \u003d $::os_service_default,"},{"line_number":124,"context_line":") {"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  include ::heat::deps"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_6360f501","line":124,"range":{"start_line":124,"start_character":2,"end_line":124,"end_character":3},"in_reply_to":"da6ed579_5524c2ad","updated":"2016-01-14 15:04:34.000000000","message":"To me, there is no need because we include ::heat at line 137, but maybe I am wrong ...","commit_id":"13c72a10857f3eb0b93dcfee047c9417aabd5d12"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"56a101d5e611a5ffa0a5223a82e593639aec39be","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  $instance_connection_is_secure                   \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $instance_connection_https_validate_certificates \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $max_resources_per_stack                         \u003d $::os_service_default,"},{"line_number":124,"context_line":") {"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  include ::heat::deps"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_b8a5b3a2","line":124,"range":{"start_line":124,"start_character":2,"end_line":124,"end_character":3},"in_reply_to":"da6ed579_6360f501","updated":"2016-01-14 16:49:47.000000000","message":"Yep, we need inherit from some class, if we want to use some vars from in parameter defaults. Take a look here: https://review.openstack.org/#/c/214976/14/manifests/mdns.pp","commit_id":"13c72a10857f3eb0b93dcfee047c9417aabd5d12"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"202f262c5afa2256e101dfec33269427765f4f3b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  $instance_connection_is_secure                   \u003d $::os_service_default,"},{"line_number":125,"context_line":"  $instance_connection_https_validate_certificates \u003d $::os_service_default,"},{"line_number":126,"context_line":"  $max_resources_per_stack                         \u003d $::os_service_default,"},{"line_number":127,"context_line":") inherits heat {"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  include ::heat::deps"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6ed579_ccfbdb77","line":127,"range":{"start_line":127,"start_character":2,"end_line":127,"end_character":10},"updated":"2016-01-15 11:54:13.000000000","message":"Thanks for update.\n\nActually, i have missed another way. We can use pick() function here instead. Like: https://github.com/openstack/puppet-sahara/blob/master/manifests/logging.pp#L115-L120\n\nSo, we need more feedback here.","commit_id":"c0e631d0a1f1b9687110dfd7738facddb488b966"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"87f100e1af99e16e4e6cd262b75e17a07f1b3c4a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    \u0027DEFAULT/instance_connection_is_secure\u0027:                   value \u003d\u003e $instance_connection_is_secure;"},{"line_number":180,"context_line":"  }"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  if (is_service_default($deferred_auth_method)) {"},{"line_number":183,"context_line":"    heat_config {"},{"line_number":184,"context_line":"      \u0027trustee/auth_plugin\u0027    : value \u003d\u003e \u0027password\u0027;"},{"line_number":185,"context_line":"      \u0027trustee/auth_url\u0027       : value \u003d\u003e $::heat::auth_uri;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6ed579_7dcaa41c","line":182,"range":{"start_line":182,"start_character":26,"end_line":182,"end_character":46},"updated":"2016-01-15 10:19:11.000000000","message":"Will this still work if deferred_auth_method is explicitly set to \"trusts\"?  Sorry not very familiar with the service_default stuff.","commit_id":"c0e631d0a1f1b9687110dfd7738facddb488b966"}]}