)]}'
{"manifests/keystone/domain.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fe2dcd07c8ec17010b31aa23d14318279ebacba9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    heat_config {"},{"line_number":73,"context_line":"      \u0027DEFAULT/stack_domain_admin\u0027:          value \u003d\u003e $domain_admin;"},{"line_number":74,"context_line":"      \u0027DEFAULT/stack_domain_admin_password\u0027: value \u003d\u003e $domain_password, secret \u003d\u003e true;"},{"line_number":75,"context_line":"      \u0027DEFAULT/stack_user_domain_name\u0027:      value \u003d\u003e $domain_name;"},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_310cad3a","line":75,"updated":"2016-10-14 10:03:36.000000000","message":"why not then just pass $os_service_default for example for these parameters?","commit_id":"d2eb3b42f053598909708971523801097c8ae506"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"216031732989c661835cfbbc66370ed3c2a9a127","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    heat_config {"},{"line_number":73,"context_line":"      \u0027DEFAULT/stack_domain_admin\u0027:          value \u003d\u003e $domain_admin;"},{"line_number":74,"context_line":"      \u0027DEFAULT/stack_domain_admin_password\u0027: value \u003d\u003e $domain_password, secret \u003d\u003e true;"},{"line_number":75,"context_line":"      \u0027DEFAULT/stack_user_domain_name\u0027:      value \u003d\u003e $domain_name;"},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_e0e339d7","line":75,"in_reply_to":"fa6399be_003f4d87","updated":"2016-10-14 12:22:56.000000000","message":"Not as default value. Use os_service_default as parameter value, when we are calling class.","commit_id":"d2eb3b42f053598909708971523801097c8ae506"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"089d4d3ab1c854af30fd770b685cc490c6152520","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    heat_config {"},{"line_number":73,"context_line":"      \u0027DEFAULT/stack_domain_admin\u0027:          value \u003d\u003e $domain_admin;"},{"line_number":74,"context_line":"      \u0027DEFAULT/stack_domain_admin_password\u0027: value \u003d\u003e $domain_password, secret \u003d\u003e true;"},{"line_number":75,"context_line":"      \u0027DEFAULT/stack_user_domain_name\u0027:      value \u003d\u003e $domain_name;"},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_003f4d87","line":75,"in_reply_to":"fa6399be_310cad3a","updated":"2016-10-14 12:18:01.000000000","message":"if we use os_service_default, we\u0027ll break backward compatibility because defaults values here are different from the ones in heat (heat actually don\u0027t provide default value). So this solution lgtm.","commit_id":"d2eb3b42f053598909708971523801097c8ae506"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"0dfc457710aa924ee35be0ea64cbe2a794a21088","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    heat_config {"},{"line_number":73,"context_line":"      \u0027DEFAULT/stack_domain_admin\u0027:          value \u003d\u003e $domain_admin;"},{"line_number":74,"context_line":"      \u0027DEFAULT/stack_domain_admin_password\u0027: value \u003d\u003e $domain_password, secret \u003d\u003e true;"},{"line_number":75,"context_line":"      \u0027DEFAULT/stack_user_domain_name\u0027:      value \u003d\u003e $domain_name;"},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_b2f518ee","line":75,"in_reply_to":"fa6399be_e0e339d7","updated":"2016-10-14 12:38:15.000000000","message":"There are no defaults for these values, so I\u0027m not sure $os_service_default will really do anything?\n\nhttps://github.com/openstack/heat/blob/master/heat/common/config.py#L70","commit_id":"d2eb3b42f053598909708971523801097c8ae506"}]}