)]}'
{"id":"openstack%2Fpuppet-heat~746779","triplet_id":"openstack%2Fpuppet-heat~master~If689eb5e896dba443358ac83cd7f566aacc276f1","project":"openstack/puppet-heat","branch":"master","hashtags":[],"change_id":"If689eb5e896dba443358ac83cd7f566aacc276f1","subject":"Expose vhost_custom_fragment","status":"MERGED","created":"2020-08-18 17:51:24.000000000","updated":"2020-08-19 14:41:19.000000000","submitted":"2020-08-19 14:41:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"746779-1597848079763-4ababe2a","meta_rev_id":"2b22ff40d8dbcfd85b4a0d817972dd3bb739b59b","_number":746779,"virtual_id_number":746779,"owner":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-19 14:41:19.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2020-08-19 13:11:12.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2020-08-18 23:38:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2020-08-19 07:11:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2020-08-19 13:11:12.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-18 23:38:37.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2020-08-19 07:11:25.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2020-08-19 13:11:12.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-08-19 14:41:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"39f45b42f3de5579e1cadfc7fd461f9b0e61a020","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2020-08-18 17:51:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3aa1419e331b7da6204c34e050b8c7a61bfa59e4","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2020-08-18 17:53:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0fea3a1c46e2fbcfd885827d87d89c31704ddc64","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 19:28:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3feb4c3a9ae54806a22083a15807a4b1 : SUCCESS in 4m 25s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/41ca3e62abdc4a3c90ee9e68fea07a29 : SUCCESS in 4m 06s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5632777098ba476493437434225d15e0 : SUCCESS in 4m 29s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/46021f0176064e3985b7d18e6f2165e5 : SUCCESS in 14m 01s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/8132b73acfb3403aac1908a4eada0772 : SUCCESS in 12m 11s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/257264f169eb402da3f7e43b875151e6 : SUCCESS in 10m 00s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/cc85b557344149b692d38208db03cc86 : FAILURE in 6m 41s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9673d832437c4931b094399cbffd237f : SUCCESS in 43m 55s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/931b0ef2ff8842b3839fc073a261fb41 : SUCCESS in 1h 28m 43s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/8c191c7f245b43abbeff07d05b1762a0 : SUCCESS in 18m 22s\n- puppet-openstack-beaker-centos-8 https://zuul.opendev.org/t/openstack/build/4fd02d159b8e489a93bda135256bf7f1 : FAILURE in 8m 12s (non-voting)\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/56a3faed27164565b7c215d7b9642c7f : FAILURE in 6m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7ac2e663fa8faacf1909e0a3f021cfddfcf9e763","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-08-18 23:38:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"21ed906dd970f38f11edfbca36851c8b31786bc6","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-08-19 07:10:25.000000000","message":"Patch Set 2: Code-Review-1\n\nShould not set the default for TripleO here! Override that in TripleO\u0027s usage of puppet-heat!","accounts_in_message":[],"_revision_number":2},{"id":"2c52985a35af045007135eaf1f8a09313e45bdbe","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-08-19 07:10:40.000000000","message":"Patch Set 2: Code-Review-2\n\n-2 to block Takashi +2","accounts_in_message":[],"_revision_number":2},{"id":"deeab969bb4246108e9781e0f8da9c19d459edcb","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-08-19 07:11:25.000000000","message":"Patch Set 2: Code-Review+2\n\nWow, okey... this was hardcoded before, nvm them.","accounts_in_message":[],"_revision_number":2},{"id":"c2f5d83052c2414b1c4b933b2ceef7ef118f7a7a","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-08-19 07:17:21.000000000","message":"Patch Set 2:\n\nActually I was wondering why we once hardcoded this in puppet-heat layer, but it should be another topic here...\n\nI agree that this should be hardcoded at tripleo layer once the parameter is exposed, unless we have any clear guidance by heat team.","accounts_in_message":[],"_revision_number":2},{"id":"eaaab9e5df5b71e83f492cf0296178b5a98e9925","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-08-19 13:11:12.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3fd4967fd65917a4e7f0315f884f05cc2afcb0c6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-19 13:11:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b3e04198f37b1ac49a93d035e426ba6188350172","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-19 14:41:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2768a14bde66472e8fe791bee95252d1 : SUCCESS in 4m 47s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b57def5dde4b4b1885d5c072596fbe2b : SUCCESS in 5m 11s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/29d9936a59a64de89bed99fab4e43895 : SUCCESS in 4m 23s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/a01e446583474bcfbe3e2b71dceef345 : SUCCESS in 9m 58s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/d2bac006a07747249c3fe1f9a7ad5a24 : SUCCESS in 10m 55s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d3619abe18f449258bea0bd46f99163d : SUCCESS in 12m 57s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/76280034681e44ed8814405c1d753158 : SUCCESS in 1h 22m 07s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/0bb2fa4866d44acc83c8e6c0733d794f : SUCCESS in 17m 59s","accounts_in_message":[],"_revision_number":2},{"id":"764c152fbaf207ad90bdac7d24123414e4f032c2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-19 14:41:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0e85f1c7b0d7c8819aedeb83da10eea4633d2e25","revisions":{"7e499845ca4f3516ba6fd2e924a24ae2aaeda1dc":{"kind":"REWORK","_number":1,"created":"2020-08-18 17:51:24.000000000","uploader":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"ref":"refs/changes/79/746779/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-heat","ref":"refs/changes/79/746779/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/1"}}},"commit":{"parents":[{"commit":"ad82b1f9a08ac0c25a518aeadd16b6571414c102","subject":"Prepare Victoria M1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-heat/commit/ad82b1f9a08ac0c25a518aeadd16b6571414c102"}]}],"author":{"name":"Luke Short","email":"ekultails@gmail.com","date":"2020-08-18 17:50:31.000000000","tz":-240},"committer":{"name":"Luke Short","email":"ekultails@gmail.com","date":"2020-08-18 17:50:32.000000000","tz":-240},"subject":"Expose vhost_custom_fragment","message":"Expose vhost_custom_fragment\n\nIt is provided by the Puppet class \u0027openstacklib::wsgi::apache\u0027.\nThis change exposes it for the Heat CFN service.\n\nChange-Id: If689eb5e896dba443358ac83cd7f566aacc276f1\nSigned-off-by: Luke Short \u003cekultails@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-heat/commit/7e499845ca4f3516ba6fd2e924a24ae2aaeda1dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-heat/commit/7e499845ca4f3516ba6fd2e924a24ae2aaeda1dc"}]},"branch":"refs/heads/master"},"0e85f1c7b0d7c8819aedeb83da10eea4633d2e25":{"kind":"REWORK","_number":2,"created":"2020-08-18 17:53:43.000000000","uploader":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"ref":"refs/changes/79/746779/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-heat","ref":"refs/changes/79/746779/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-heat refs/changes/79/746779/2"}}},"commit":{"parents":[{"commit":"ad82b1f9a08ac0c25a518aeadd16b6571414c102","subject":"Prepare Victoria M1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-heat/commit/ad82b1f9a08ac0c25a518aeadd16b6571414c102"}]}],"author":{"name":"Luke Short","email":"ekultails@gmail.com","date":"2020-08-18 17:50:31.000000000","tz":-240},"committer":{"name":"Luke Short","email":"ekultails@gmail.com","date":"2020-08-18 17:53:38.000000000","tz":-240},"subject":"Expose vhost_custom_fragment","message":"Expose vhost_custom_fragment\n\nIt is provided by the Puppet class \u0027openstacklib::wsgi::apache\u0027.\nThis change exposes it for the Heat CFN service.\n\nChange-Id: If689eb5e896dba443358ac83cd7f566aacc276f1\nSigned-off-by: Luke Short \u003cekultails@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-heat/commit/0e85f1c7b0d7c8819aedeb83da10eea4633d2e25"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-heat/commit/0e85f1c7b0d7c8819aedeb83da10eea4633d2e25"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}