)]}'
{"metadata.json":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4fd9b3a8d7c76cdcc2989bd510c79d1faf8e1618","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"author\": \"eNovance and OpenStack Contributors\","},{"line_number":3,"context_line":"    \"dependencies\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"name\": \"puppetlabs/apache\","},{"line_number":6,"context_line":"            \"version_requirement\": \"\u003e\u003d5.0.0\""},{"line_number":7,"context_line":"        },"},{"line_number":8,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"dcc0a940_64138594","line":5,"updated":"2021-12-07 15:52:18.000000000","message":"Actually this is already covered via the openstack lib requirement which requires this.  IIRC we wrapped most of our apache bits via openstacklib","commit_id":"fbce87f79c7429830ac0e08a5777a29a6f3cfc18"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"87aeaee458e5387a50d7b63fb7ff5412d5ea90d3","unresolved":true,"context_lines":[{"line_number":2,"context_line":"    \"author\": \"eNovance and OpenStack Contributors\","},{"line_number":3,"context_line":"    \"dependencies\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"name\": \"puppetlabs/apache\","},{"line_number":6,"context_line":"            \"version_requirement\": \"\u003e\u003d5.0.0\""},{"line_number":7,"context_line":"        },"},{"line_number":8,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"222703ef_2a8914fb","line":5,"in_reply_to":"092360f9_ff579ea7","updated":"2021-12-07 16:33:20.000000000","message":"I think it adds extra overhead. I wouldn\u0027t add it since it\u0027s universally covered via openstacklib.  If we removed it from openstack lib then we\u0027d want to cover it here as well.","commit_id":"fbce87f79c7429830ac0e08a5777a29a6f3cfc18"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a1be1d73d126de55f972a2017848014b4ec2bac7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"    \"author\": \"eNovance and OpenStack Contributors\","},{"line_number":3,"context_line":"    \"dependencies\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"name\": \"puppetlabs/apache\","},{"line_number":6,"context_line":"            \"version_requirement\": \"\u003e\u003d5.0.0\""},{"line_number":7,"context_line":"        },"},{"line_number":8,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"092360f9_ff579ea7","line":5,"in_reply_to":"dcc0a940_64138594","updated":"2021-12-07 16:27:43.000000000","message":"We still import some classes directly from puppetlabs-apache (apache::params, apache::mod::wsgi and apache::mod::ssl). puppetlabs-apache is listed in dependencies of puppet-nova and I think listing all modules with direct dependencies would be more consistent.\n\nHowever I\u0027d admit this might be just redundant and causing extra work. Maybe we can drop puppetlabs-apache assuming individual modules would not add extra requirement.","commit_id":"fbce87f79c7429830ac0e08a5777a29a6f3cfc18"}]}