)]}'
{"manifests/wsgi/apache.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c35db9ad6185b1f8597ae5a613adf70f5340f50f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    error_log_file              \u003d\u003e \u0027horizon_error.log\u0027,"},{"line_number":177,"context_line":"    priority                    \u003d\u003e $priority,"},{"line_number":178,"context_line":"    aliases                     \u003d\u003e [{"},{"line_number":179,"context_line":"      alias \u003d\u003e \"${webroot}/static\","},{"line_number":180,"context_line":"      path \u003d\u003e \u0027/usr/share/openstack-dashboard/static\u0027,"},{"line_number":181,"context_line":"    }],"},{"line_number":182,"context_line":"    port                        \u003d\u003e 80,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aaa499b_3dfc4b71","line":179,"range":{"start_line":179,"start_character":6,"end_line":179,"end_character":35},"updated":"2015-04-15 14:14:51.000000000","message":"so if alias will be \u0027//static\u0027 by default. Is it something that can cause an issue? It works functionally (tested), I just wonder if we can do better.","commit_id":"e0af7b04d4e1d9f8db48f00b6db1230d0e0d3ac4"},{"author":{"_account_id":1918,"name":"François Charlier","email":"francois.charlier@redhat.com","username":"francois-charlier"},"change_message_id":"47394614ed6b057c7beeb5ed9530551b4fb06986","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    error_log_file              \u003d\u003e \u0027horizon_error.log\u0027,"},{"line_number":177,"context_line":"    priority                    \u003d\u003e $priority,"},{"line_number":178,"context_line":"    aliases                     \u003d\u003e [{"},{"line_number":179,"context_line":"      alias \u003d\u003e \"${webroot}/static\","},{"line_number":180,"context_line":"      path \u003d\u003e \u0027/usr/share/openstack-dashboard/static\u0027,"},{"line_number":181,"context_line":"    }],"},{"line_number":182,"context_line":"    port                        \u003d\u003e 80,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aaa499b_232308a9","line":179,"range":{"start_line":179,"start_character":6,"end_line":179,"end_character":35},"in_reply_to":"7aaa499b_3dfc4b71","updated":"2015-04-15 14:43:36.000000000","message":"As Gael sait in another comment, the parameter should start and end with a \u0027/\u0027, there should be a verification for this and then remove the \u0027/\u0027 here before static (and everywhere else required)","commit_id":"e0af7b04d4e1d9f8db48f00b6db1230d0e0d3ac4"}],"spec/classes/horizon_init_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1dc8418605e6cd921d6fa95a627b7d6ebddfe4a5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          :neutron_options         \u003d\u003e {\u0027enable_lb\u0027 \u003d\u003e true, \u0027enable_firewall\u0027 \u003d\u003e true, \u0027enable_quotas\u0027 \u003d\u003e false, \u0027enable_security_group\u0027 \u003d\u003e false, \u0027enable_vpn\u0027 \u003d\u003e true,"},{"line_number":98,"context_line":"                                       \u0027enable_distributed_router\u0027 \u003d\u003e false, \u0027enable_ha_router\u0027 \u003d\u003e false, \u0027profile_support\u0027 \u003d\u003e \u0027cisco\u0027, },"},{"line_number":99,"context_line":"          :file_upload_temp_dir    \u003d\u003e \u0027/var/spool/horizon\u0027,"},{"line_number":100,"context_line":"          :secure_cookies          \u003d\u003e true,"},{"line_number":101,"context_line":"        })"},{"line_number":102,"context_line":"      end"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa32b979_f4d180ce","line":100,"updated":"2015-06-15 20:47:48.000000000","message":"Not a relevant change","commit_id":"cff9f40cb8fa26de99faff60a139fa783d0f4395"}],"spec/classes/horizon_wsgi_apache_spec.rb":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"78d23c580ba944364e2307adc68e973c6969e35a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"          \u0027priority\u0027             \u003d\u003e params[:priority],"},{"line_number":77,"context_line":"          \u0027serveraliases\u0027        \u003d\u003e \u0027*\u0027,"},{"line_number":78,"context_line":"          \u0027docroot\u0027              \u003d\u003e \u0027/var/www/\u0027,"},{"line_number":79,"context_line":"          \u0027aliases\u0027              \u003d\u003e [[\u0027alias\u0027, \"/dashboard/static\"], [\u0027path\u0027, \u0027/usr/share/openstack-dashboard/static\u0027]],"},{"line_number":80,"context_line":"          \u0027ssl\u0027                  \u003d\u003e \u0027false\u0027,"},{"line_number":81,"context_line":"          \u0027redirectmatch_status\u0027 \u003d\u003e \u0027permanent\u0027,"},{"line_number":82,"context_line":"          \u0027redirectmatch_regexp\u0027 \u003d\u003e \u0027^/$\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aaa499b_df358646","line":79,"updated":"2015-04-14 14:59:50.000000000","message":"could you please use simple quote for /dashboard/static instead of double-quote?","commit_id":"a73584aaab3f1e83f8dee9e9dda46788d910674b"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"c21bbcd3a7665eb9891a05bbfd0c97f80cfb8be0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"    it \u0027configures webroot alias\u0027 do"},{"line_number":207,"context_line":"      is_expected.to contain_apache__vhost(\u0027horizon_vhost\u0027).with("},{"line_number":208,"context_line":"        \u0027aliases\u0027              \u003d\u003e [[\u0027alias\u0027, \u0027/dashboard/static\u0027], [\u0027path\u0027, \u0027/usr/share/openstack-dashboard/static\u0027]],"},{"line_number":209,"context_line":"      )"},{"line_number":210,"context_line":"    end"},{"line_number":211,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7aaa499b_6407d318","line":208,"updated":"2015-04-15 17:12:00.000000000","message":"Why all these spaces?","commit_id":"2ed27de2607abe8c334b5efdd7e26c88ec5ec460"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"22acf1691bfcf1253e3c21865b5883902ca8b8be","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"    it \u0027configures webroot alias\u0027 do"},{"line_number":207,"context_line":"      is_expected.to contain_apache__vhost(\u0027horizon_vhost\u0027).with("},{"line_number":208,"context_line":"        \u0027aliases\u0027              \u003d\u003e [[\u0027alias\u0027, \u0027/dashboard/static\u0027], [\u0027path\u0027, \u0027/usr/share/openstack-dashboard/static\u0027]],"},{"line_number":209,"context_line":"      )"},{"line_number":210,"context_line":"    end"},{"line_number":211,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5aa745d1_e6a5b4b5","line":208,"in_reply_to":"7aaa499b_6407d318","updated":"2015-04-15 19:55:10.000000000","message":"Probably some copy \u0026 paste mistake. Thx :)","commit_id":"2ed27de2607abe8c334b5efdd7e26c88ec5ec460"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"c21bbcd3a7665eb9891a05bbfd0c97f80cfb8be0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    it_behaves_like \u0027apache for horizon\u0027"},{"line_number":234,"context_line":"    it \u0027configures webroot alias\u0027 do"},{"line_number":235,"context_line":"      is_expected.to contain_apache__vhost(\u0027horizon_vhost\u0027).with("},{"line_number":236,"context_line":"        \u0027aliases\u0027              \u003d\u003e [[\u0027alias\u0027, \u0027/horizon/static\u0027], [\u0027path\u0027, \u0027/usr/share/openstack-dashboard/static\u0027]],"},{"line_number":237,"context_line":"      )"},{"line_number":238,"context_line":"    end"},{"line_number":239,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7aaa499b_440cd73a","line":236,"updated":"2015-04-15 17:12:00.000000000","message":"Why all these spaces?","commit_id":"2ed27de2607abe8c334b5efdd7e26c88ec5ec460"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1dc8418605e6cd921d6fa95a627b7d6ebddfe4a5","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    it \u0027configures webroot alias\u0027 do"},{"line_number":207,"context_line":"      if (Gem::Version.new(Puppet.version) \u003e\u003d Gem::Version.new(\u00274.0\u0027))"},{"line_number":208,"context_line":"        is_expected.to contain_apache__vhost(\u0027horizon_vhost\u0027).with("},{"line_number":209,"context_line":"          \u0027aliases\u0027       \u003d\u003e [{\"alias\" \u003d\u003e \"/dashboard/static\", \"path\" \u003d\u003e \"/usr/share/openstack-dashboard/static\"}],"},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"      else"},{"line_number":212,"context_line":"        is_expected.to contain_apache__vhost(\u0027horizon_vhost\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa32b979_b48a18be","line":209,"updated":"2015-06-15 20:47:48.000000000","message":"Too much whitespace between the key and the \u003d\u003e\n\nPlease use single quotes for consistency with the other strings.","commit_id":"cff9f40cb8fa26de99faff60a139fa783d0f4395"}],"templates/local_settings.py.erb":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"48b63896f4f22d82176f7cded58d928cb02f45bd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"TEMPLATE_DEBUG \u003d DEBUG"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# WEBROOT is the location relative to Webserver root"},{"line_number":11,"context_line":"# should end with a slash."},{"line_number":12,"context_line":"WEBROOT \u003d \u0027\u003c%\u003d @webroot %\u003e\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Required for Django 1.5."}],"source_content_type":"application/x-erb","patch_set":4,"id":"7aaa499b_1d474f78","line":11,"updated":"2015-04-15 14:18:47.000000000","message":"As already commented on IRC, this parameter should end with a slash! but can\u0027t see any validation somewhere?","commit_id":"e0af7b04d4e1d9f8db48f00b6db1230d0e0d3ac4"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"c21bbcd3a7665eb9891a05bbfd0c97f80cfb8be0","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# WEBROOT is the location relative to Webserver root"},{"line_number":11,"context_line":"# should end with a slash."},{"line_number":12,"context_line":"WEBROOT \u003d \u0027\u003c%\u003d scope.lookupvar(\"horizon::params::root_url\") %\u003e/\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Required for Django 1.5."},{"line_number":15,"context_line":"# If horizon is running in production (DEBUG is False), set this"}],"source_content_type":"application/x-erb","patch_set":6,"id":"7aaa499b_84065f1b","line":12,"updated":"2015-04-15 17:12:00.000000000","message":"I would use \u0027\u003c%\u003d scope.lookupvar(\u0027::horizon::params::root_url\u0027) %\u003e/\u0027 or \u0027\u003c%\u003d scope[\u0027::horizon::params::root_url\u0027] %\u003e/\u0027.\nNot worth a -1 for this like that\u0027s homogeneous with the others lookupvar functions present in the template ...","commit_id":"2ed27de2607abe8c334b5efdd7e26c88ec5ec460"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"22acf1691bfcf1253e3c21865b5883902ca8b8be","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# WEBROOT is the location relative to Webserver root"},{"line_number":11,"context_line":"# should end with a slash."},{"line_number":12,"context_line":"WEBROOT \u003d \u0027\u003c%\u003d scope.lookupvar(\"horizon::params::root_url\") %\u003e/\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Required for Django 1.5."},{"line_number":15,"context_line":"# If horizon is running in production (DEBUG is False), set this"}],"source_content_type":"application/x-erb","patch_set":6,"id":"5aa745d1_a6b44cd1","line":12,"in_reply_to":"7aaa499b_84065f1b","updated":"2015-04-15 19:55:10.000000000","message":"I\u0027m fine with either syntax, just wanted to make sure it was consistent with the rest of the template.","commit_id":"2ed27de2607abe8c334b5efdd7e26c88ec5ec460"}]}