)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"50b89b028674a7b9b8b1cd7495f7c11df6542c97","unresolved":false,"context_lines":[{"line_number":324,"context_line":"  Service \u003c| title \u003d\u003d \u0027memcached\u0027 |\u003e -\u003e Class[\u0027horizon\u0027]"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"  $hypervisor_options_real \u003d merge($hypervisor_defaults,$hypervisor_options)"},{"line_number":327,"context_line":"  #validate hashes"},{"line_number":328,"context_line":"  validate_hash($hypervisor_options_real)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  package { \u0027horizon\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_26fb9148","line":327,"updated":"2015-08-21 14:01:16.000000000","message":"the comment is... useless. the function is called \u0027validate_hash\u0027, obviously we are validating an hash here :-)","commit_id":"a5d388867e86804024d3d5daa19235b4ce084956"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1b94f1ce72c83f2d5f8cc372741b0e487a0c716e","unresolved":false,"context_lines":[{"line_number":324,"context_line":"  Service \u003c| title \u003d\u003d \u0027memcached\u0027 |\u003e -\u003e Class[\u0027horizon\u0027]"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"  $hypervisor_options_real \u003d merge($hypervisor_defaults,$hypervisor_options)"},{"line_number":327,"context_line":"  #validate hashes"},{"line_number":328,"context_line":"  validate_hash($hypervisor_options_real)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  package { \u0027horizon\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_79cfee55","line":327,"in_reply_to":"fa1b9901_26fb9148","updated":"2015-08-21 14:22:20.000000000","message":"Done","commit_id":"a5d388867e86804024d3d5daa19235b4ce084956"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"284ab94780f8cc4564c6d4ef622eea82c7240a13","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"  $hypervisor_options_real \u003d merge($hypervisor_defaults,$hypervisor_options)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  validate_hash($hypervisor_options_real)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  package { \u0027horizon\u0027:"},{"line_number":331,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da20952f_7d98d36a","line":328,"updated":"2015-09-10 07:47:31.000000000","message":"The validate hash here is unnecessary. The value the merge function returns is an hash per the function code\n\nhttps://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/puppet/parser/functions/merge.rb#L22-L32","commit_id":"326b0aca166f6ab68b19dc66fa518559102090ea"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a7ef87bc668f1acb44877aa4e2d0a61294aa189","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"  $hypervisor_options_real \u003d merge($hypervisor_defaults,$hypervisor_options)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  validate_hash($hypervisor_options_real)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  package { \u0027horizon\u0027:"},{"line_number":331,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da20952f_77820354","line":328,"in_reply_to":"da20952f_7d98d36a","updated":"2015-09-11 07:48:02.000000000","message":"Done","commit_id":"326b0aca166f6ab68b19dc66fa518559102090ea"}],"templates/local_settings.py.erb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"50b89b028674a7b9b8b1cd7495f7c11df6542c97","unresolved":false,"context_lines":[{"line_number":188,"context_line":"# services provided by hypervisors."},{"line_number":189,"context_line":"OPENSTACK_HYPERVISOR_FEATURES \u003d {"},{"line_number":190,"context_line":"    \u003c%- @hypervisor_options \u003d @hypervisor_defaults.merge(@hypervisor_options) -%\u003e"},{"line_number":191,"context_line":"    \u0027can_set_mount_point\u0027: \u003c%\u003d @hypervisor_options[\u0027can_set_mount_point\u0027].to_s.capitalize %\u003e,"},{"line_number":192,"context_line":"    \u0027can_set_password\u0027: \u003c%\u003d @hypervisor_options[\u0027can_set_password\u0027].to_s.capitalize %\u003e,"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""}],"source_content_type":"application/x-erb","patch_set":1,"id":"fa1b9901_66618904","side":"PARENT","line":191,"updated":"2015-08-21 14:01:16.000000000","message":"so you\u0027re dropping capitalization.\n\n1/ it\u0027s not mentioned in the commit message why you\u0027re doing that.\n\n2/ it\u0027s not consistent with other booleans in the template.","commit_id":"2eaaebdf08e66096bb3da6d52a876fbe0d8dee0e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1b94f1ce72c83f2d5f8cc372741b0e487a0c716e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"# services provided by hypervisors."},{"line_number":189,"context_line":"OPENSTACK_HYPERVISOR_FEATURES \u003d {"},{"line_number":190,"context_line":"    \u003c%- @hypervisor_options \u003d @hypervisor_defaults.merge(@hypervisor_options) -%\u003e"},{"line_number":191,"context_line":"    \u0027can_set_mount_point\u0027: \u003c%\u003d @hypervisor_options[\u0027can_set_mount_point\u0027].to_s.capitalize %\u003e,"},{"line_number":192,"context_line":"    \u0027can_set_password\u0027: \u003c%\u003d @hypervisor_options[\u0027can_set_password\u0027].to_s.capitalize %\u003e,"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""}],"source_content_type":"application/x-erb","patch_set":1,"id":"fa1b9901_59422aaf","side":"PARENT","line":191,"in_reply_to":"fa1b9901_66618904","updated":"2015-08-21 14:22:20.000000000","message":"you are right, it will not work without capitalization","commit_id":"2eaaebdf08e66096bb3da6d52a876fbe0d8dee0e"}]}