)]}'
{"manifests/init.pp":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"ddbf3b73205b4fe10b422d5be900804ce83a8232","unresolved":false,"context_lines":[{"line_number":381,"context_line":"  $neutron_options_real    \u003d merge($neutron_defaults,$neutron_options)"},{"line_number":382,"context_line":"  validate_hash($api_versions)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-memcache\u0027, { ensure \u003d\u003e present })"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  package { \u0027horizon\u0027:"},{"line_number":387,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba0121b8_cf5eda44","line":384,"range":{"start_line":384,"start_character":2,"end_line":384,"end_character":70},"updated":"2016-03-29 11:54:49.000000000","message":"Please have a look at https://github.com/openstack/puppet-keystone/blob/master/manifests/params.pp\n\nPlease add platform-specific package name to params.pp\nthen use it as:\nensure_packages($python_memcache_package_name)","commit_id":"5700d8edb775c6021574ec54ab4592837e98cdc0"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"05adc9295d885c870688b451d90c2f57396e1f02","unresolved":false,"context_lines":[{"line_number":381,"context_line":"  $neutron_options_real    \u003d merge($neutron_defaults,$neutron_options)"},{"line_number":382,"context_line":"  validate_hash($api_versions)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-memcache\u0027, { ensure \u003d\u003e present })"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  package { \u0027horizon\u0027:"},{"line_number":387,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba0121b8_4a0598c0","line":384,"range":{"start_line":384,"start_character":2,"end_line":384,"end_character":70},"in_reply_to":"ba0121b8_cf5eda44","updated":"2016-03-29 12:02:00.000000000","message":"Also please consider to employ condition:\nif $cache_backend \u003d~ /memcached/ { ... }","commit_id":"5700d8edb775c6021574ec54ab4592837e98cdc0"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"8f136310a09390a6bbe018f4ff69f44b587cb1b1","unresolved":false,"context_lines":[{"line_number":381,"context_line":"  $neutron_options_real    \u003d merge($neutron_defaults,$neutron_options)"},{"line_number":382,"context_line":"  validate_hash($api_versions)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  ensure_resource(\u0027package\u0027, $::horizon::params::memcache_package, { ensure \u003d\u003e present })"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  package { \u0027horizon\u0027:"},{"line_number":387,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba0121b8_0c00d933","line":384,"range":{"start_line":384,"start_character":2,"end_line":384,"end_character":89},"updated":"2016-03-29 13:27:05.000000000","message":"ensure_packages($::horizon::params::memcache_package)\nshould be enough (please refer to stdlib funcs).","commit_id":"c284e1cee96e1370b787650ef220f363ee79471e"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"a4a2ef47f937bc07cf8f473245d1a87730eaee7d","unresolved":false,"context_lines":[{"line_number":381,"context_line":"  $neutron_options_real    \u003d merge($neutron_defaults,$neutron_options)"},{"line_number":382,"context_line":"  validate_hash($api_versions)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  ensure_packages($::horizon::params::memcache_package, { ensure \u003d\u003e present })"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  package { \u0027horizon\u0027:"},{"line_number":387,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_20fafcbd","line":384,"range":{"start_line":384,"start_character":2,"end_line":384,"end_character":78},"updated":"2016-03-29 14:20:00.000000000","message":"# install memcached client only if memcached backed is in action\nif $cache_backend \u003d~ /memcached/ {\n  ensure_packages($::horizon::params::memcache_package)\n}","commit_id":"6930d5d434b8430ee002687602d78af5514d0da6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4e369b9b343846de52e079fb534f7f11dd3bd5a9","unresolved":false,"context_lines":[{"line_number":381,"context_line":"  $neutron_options_real    \u003d merge($neutron_defaults,$neutron_options)"},{"line_number":382,"context_line":"  validate_hash($api_versions)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  ensure_packages($::horizon::params::memcache_package, { ensure \u003d\u003e present })"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  package { \u0027horizon\u0027:"},{"line_number":387,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_690fb52e","line":384,"range":{"start_line":384,"start_character":2,"end_line":384,"end_character":78},"in_reply_to":"ba0121b8_20fafcbd","updated":"2016-03-29 17:36:58.000000000","message":"+1 for this","commit_id":"6930d5d434b8430ee002687602d78af5514d0da6"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"c1e1021f6a1a374b3e6b48ab64381ca548edf7f7","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  if $cache_backend \u003d~ /MemcachedCache/ {"},{"line_number":385,"context_line":"    ensure_packages(\u0027python-memcache\u0027,"},{"line_number":386,"context_line":"      { ensure \u003d\u003e present,"},{"line_number":387,"context_line":"        name   \u003d\u003e $::horizon::params::memcache_package,"},{"line_number":388,"context_line":"        tag    \u003d\u003e [\u0027openstack\u0027, \u0027horizon-package\u0027]})"},{"line_number":389,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a1b2928_2241830c","line":386,"range":{"start_line":386,"start_character":8,"end_line":386,"end_character":25},"updated":"2016-04-11 08:59:35.000000000","message":"#minor: not need, will be added by function.","commit_id":"e00e437b383c6ede0c3852c3d68db834ca8de7dc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9d06c934fe0e2fccaa87b3cc7c82d7ff13112345","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  if $cache_backend \u003d~ /MemcachedCache/ {"},{"line_number":385,"context_line":"    ensure_packages(\u0027python-memcache\u0027,"},{"line_number":386,"context_line":"      { ensure \u003d\u003e present,"},{"line_number":387,"context_line":"        name   \u003d\u003e $::horizon::params::memcache_package,"},{"line_number":388,"context_line":"        tag    \u003d\u003e [\u0027openstack\u0027, \u0027horizon-package\u0027]})"},{"line_number":389,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a18252c_518f1323","line":386,"updated":"2016-04-12 16:27:11.000000000","message":"Actually you should probably not define this. Depending on how this gets used by the end user if they actually wanted ensure \u003d\u003e \u0027latest\u0027, you might come through and override it. It\u0027s best not to specify present here.  My understanding is that ensure_packages can come through and stomp on some already defined resources depending on parser order","commit_id":"e00e437b383c6ede0c3852c3d68db834ca8de7dc"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"dcc8c909ab0520fc2fad4a61bae50fd2517eca7b","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"  if $cache_backend \u003d~ /MemcachedCache/ {"},{"line_number":385,"context_line":"    ensure_packages(\u0027python-memcache\u0027,"},{"line_number":386,"context_line":"      { ensure \u003d\u003e present,"},{"line_number":387,"context_line":"        name   \u003d\u003e $::horizon::params::memcache_package,"},{"line_number":388,"context_line":"        tag    \u003d\u003e [\u0027openstack\u0027, \u0027horizon-package\u0027]})"},{"line_number":389,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a18252c_67ed2d8b","line":386,"in_reply_to":"5a18252c_518f1323","updated":"2016-04-12 17:03:29.000000000","message":"Ok I removed the ensure.","commit_id":"e00e437b383c6ede0c3852c3d68db834ca8de7dc"}]}
