)]}'
{"id":"openstack%2Fpuppet-horizon~718702","triplet_id":"openstack%2Fpuppet-horizon~master~Ie1c4fdfc5f95ce3103beea311223ec78597a38ec","project":"openstack/puppet-horizon","branch":"master","topic":"removed-params","hashtags":[],"change_id":"Ie1c4fdfc5f95ce3103beea311223ec78597a38ec","subject":"Drop removed parameters from loca_settings.py template","status":"MERGED","created":"2020-04-09 13:41:39.000000000","updated":"2020-04-09 22:08:11.000000000","submitted":"2020-04-09 22:08:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"718702-1586470091507-a14ab837","meta_rev_id":"75c0d4ca1e319dd11b9416629cab240aa71fd5c2","_number":718702,"virtual_id_number":718702,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-09 22:08:11.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2020-04-09 19:02:53.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2020-04-09 20:36:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2020-04-09 20:36:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-09 19:02:53.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-04-09 20:36:57.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-04-09 22:08:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4092e07a84a412c5ca2c112a8e5fafd3d9670025","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-09 13:41:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f9bc3f88cf7a98f55e19ff2ffaa208bb9f6de3a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 15:20:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/addf3573042845cea24ba5f236d7dc33 : SUCCESS in 7m 05s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/944e528e9da6477f9f36247798e797c9 : SUCCESS in 5m 06s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/22eba8b0ce0e47f0a1266264b2813a7c : SUCCESS in 4m 47s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/181ab1fd120743f5924dfe6ef216b4b1 : FAILURE in 13m 35s (non-voting)\n- puppet-openstack-unit-6.11-centos-8 https://zuul.opendev.org/t/openstack/build/67230a44241346ed86f92692ca1162e2 : FAILURE in 15m 59s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ba8ce1323e514cba921d1a1208f73970 : FAILURE in 17m 57s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f00b2a3807604cc38c924547896b6356 : FAILURE in 18m 51s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/70606fd19d0c47b4b9c7660c7719f298 : SUCCESS in 48m 05s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/56ef70c24a124861b0952a486017576d : SUCCESS in 1h 28m 01s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/acda3318a815499491e5befc2d88b9c9 : SUCCESS in 17m 45s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/64b728c0c1884f9c9123610ec3f03f8a : FAILURE in 10m 17s (non-voting)\n- puppet-horizon-tripleo-standalone https://zuul.opendev.org/t/openstack/build/1c27ad9705644f44874d188d7bd8d275 : SUCCESS in 1h 29m 18s","accounts_in_message":[],"_revision_number":1},{"id":"d661109deb586004a82b02a784ad90e2f59701bb","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-09 15:46:58.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"2ef958c5e67436322faed4305df40802ca482821","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 17:26:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1a9ca533ae5c4951b9f2eee87dd0f051 : SUCCESS in 6m 04s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d89952b79f694730b25b308a5a31adc7 : SUCCESS in 6m 12s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/241ca2b7e31d4b6481623d8606e06cfc : SUCCESS in 6m 32s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/cb3deb4ddb1f4a53a2ad74d60ac2ec8d : SUCCESS in 15m 43s\n- puppet-openstack-unit-6.11-centos-8 https://zuul.opendev.org/t/openstack/build/61547a7f8abe4dcfa49dead56dcfc26c : SUCCESS in 16m 02s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/39d6c7aef1234ff7bf42720001d9b073 : SUCCESS in 12m 47s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/551263ba6ea841bf9a949c6d698c0e10 : SUCCESS in 11m 58s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/30e3eebd0b3a4f3fa28d85f16cbc0541 : SUCCESS in 54m 42s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/2316106eaa6947dfb58c392ddba59c48 : SUCCESS in 1h 11m 19s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/61e2fd6103a04a5c9c28dcc2dd269806 : SUCCESS in 18m 23s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e4259f2deb004b52b0bc2e6394591ea2 : FAILURE in 11m 52s (non-voting)\n- puppet-horizon-tripleo-standalone https://zuul.opendev.org/t/openstack/build/b7c82d47bdb84583a7949d7ac867903d : SUCCESS in 1h 30m 46s","accounts_in_message":[],"_revision_number":2},{"id":"acf96486bc921bef89b97c114443510bf5a73f60","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-04-09 19:02:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"958dcaebd1bd895da3d80d29c9303639b539fbb2","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-04-09 20:36:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"accb9cb89354f0e826b74a64658cdddcf043b5fa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 20:37:09.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"991d91565a219a534d14dd231b118c321ffa6f48","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 22:08:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d76869ad6a5b4143b9f0ca0e72fdbef6 : SUCCESS in 5m 48s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bb91d48608fe4fab92dc89d699bcb170 : SUCCESS in 5m 34s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7e13eaf7daab4104bd866f6547ac082d : SUCCESS in 6m 34s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/438e1ead211e422fb5be250184ef71dd : SUCCESS in 15m 07s\n- puppet-openstack-unit-6.11-centos-8 https://zuul.opendev.org/t/openstack/build/65fa2bcd9102449285aa585aef6e9310 : SUCCESS in 14m 29s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9664f514d1504f3581619b42ae662823 : SUCCESS in 13m 17s\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/e980d4b495cd4f58883821a8376c83b7 : SUCCESS in 1h 04m 12s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/233a12db16c24bbeb8f7528f0d9dfdee : SUCCESS in 17m 54s\n- puppet-horizon-tripleo-standalone https://zuul.opendev.org/t/openstack/build/89820ee336554804b5b9994f759b5136 : SUCCESS in 1h 21m 44s","accounts_in_message":[],"_revision_number":2},{"id":"b0f43c42987cd0c74aa389a45eaa92611c2c5cbc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 22:08:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fef2af55e80927378f3c875668bccd892e7fe25f","revisions":{"18f3939be231d75129cbf052e33a2ca700eb76fd":{"kind":"REWORK","_number":1,"created":"2020-04-09 13:41:39.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/02/718702/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-horizon","ref":"refs/changes/02/718702/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/1"}}},"commit":{"parents":[{"commit":"0585062ab2953bdada78084ec14742e02c3732e6","subject":"Add CentOS 8 and Puppet 6 in metadata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-horizon/commit/0585062ab2953bdada78084ec14742e02c3732e6"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-09 13:41:07.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-09 13:41:37.000000000","tz":540},"subject":"Drop removed parameters from loca_settings.py template","message":"Drop removed parameters from loca_settings.py template\n\nThe following parmaeters were already removed from horizon,\nso we can remove the from the teamplte file.\n - FLAVOR_EXTRA_KEYS[1]\n - SAHARA_AUTO_IP_ALLOCATION_ENABLED[2]\n - OPENSTACK_TOKEN_HASH_ALGORITHM[3]\n - OPENSTACK_TOKEN_HASH_ENABLED[4]\n\n[1] 5101ebdc2814fc80c63419eee85291d8340fd078\n[2] 0659f9a98a2f175847c7acb005ac8126d03059bc\n[3] 069329eeb220f6fd49670894e4d45a1e3ec59c4f\n[4] 71993e3c983b113ce5672fd1291e6a1200fd5a7b\n\nChange-Id: Ie1c4fdfc5f95ce3103beea311223ec78597a38ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-horizon/commit/18f3939be231d75129cbf052e33a2ca700eb76fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-horizon/commit/18f3939be231d75129cbf052e33a2ca700eb76fd"}]},"branch":"refs/heads/master"},"fef2af55e80927378f3c875668bccd892e7fe25f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-04-09 15:46:58.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/02/718702/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-horizon","ref":"refs/changes/02/718702/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-horizon refs/changes/02/718702/2"}}},"commit":{"parents":[{"commit":"faaaa4a7736423c9f5f6be239aef48ee7dc8ed9b","subject":"Expect python3 package in CentOS8 and Fedora","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-horizon/commit/faaaa4a7736423c9f5f6be239aef48ee7dc8ed9b"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-09 13:41:07.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-09 15:46:48.000000000","tz":540},"subject":"Drop removed parameters from loca_settings.py template","message":"Drop removed parameters from loca_settings.py template\n\nThe following parmaeters were already removed from horizon,\nso we can remove the from the teamplte file.\n - FLAVOR_EXTRA_KEYS[1]\n - SAHARA_AUTO_IP_ALLOCATION_ENABLED[2]\n - OPENSTACK_TOKEN_HASH_ALGORITHM[3]\n - OPENSTACK_TOKEN_HASH_ENABLED[4]\n\n[1] 5101ebdc2814fc80c63419eee85291d8340fd078\n[2] 0659f9a98a2f175847c7acb005ac8126d03059bc\n[3] 069329eeb220f6fd49670894e4d45a1e3ec59c4f\n[4] 71993e3c983b113ce5672fd1291e6a1200fd5a7b\n\nChange-Id: Ie1c4fdfc5f95ce3103beea311223ec78597a38ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-horizon/commit/fef2af55e80927378f3c875668bccd892e7fe25f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-horizon/commit/fef2af55e80927378f3c875668bccd892e7fe25f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}