)]}'
{"manifests/dashboards/heat.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"51798656dc25837b4d4f39e86d8d790523056a04","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  # The horizon class should be included so that some common parameters"},{"line_number":37,"context_line":"  # can be picked here."},{"line_number":38,"context_line":"  include horizon"},{"line_number":39,"context_line":"  $log_handlers \u003d $::horizon::log_handlers"},{"line_number":40,"context_line":"  $log_level    \u003d $::horizon::log_level"},{"line_number":41,"context_line":"  $policy_files \u003d $::horizon::policy_files"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"eb85ed09_b0787f49","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":17},"updated":"2021-05-10 09:40:07.000000000","message":"Wouldn\u0027t it be better to assert in this case? It\u0027s a bit messy that some new things (example db classes) needs to be before main class but this needs to be after main class is defined.\n\nOptimally there would not need to be a requirement like this but maybe lets error if users dont place it after ::horizon class is defined?","commit_id":"dd917dc0176cbd26c334d09d2a841e5507bbc076"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"339afef06d73d51316c7dac25adf8a30ef2cef50","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  # The horizon class should be included so that some common parameters"},{"line_number":37,"context_line":"  # can be picked here."},{"line_number":38,"context_line":"  include horizon"},{"line_number":39,"context_line":"  $log_handlers \u003d $::horizon::log_handlers"},{"line_number":40,"context_line":"  $log_level    \u003d $::horizon::log_level"},{"line_number":41,"context_line":"  $policy_files \u003d $::horizon::policy_files"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"1adae2f1_b75c9781","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":17},"in_reply_to":"2da34b4a_b201807e","updated":"2021-06-03 13:52:19.000000000","message":"Done","commit_id":"dd917dc0176cbd26c334d09d2a841e5507bbc076"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d50a9836ca6fef1ae0afe2219f41a439293ed71b","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  # The horizon class should be included so that some common parameters"},{"line_number":37,"context_line":"  # can be picked here."},{"line_number":38,"context_line":"  include horizon"},{"line_number":39,"context_line":"  $log_handlers \u003d $::horizon::log_handlers"},{"line_number":40,"context_line":"  $log_level    \u003d $::horizon::log_level"},{"line_number":41,"context_line":"  $policy_files \u003d $::horizon::policy_files"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"2da34b4a_b201807e","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":17},"in_reply_to":"eb85ed09_b0787f49","updated":"2021-05-10 23:42:57.000000000","message":"The reason why I used include is that it results in a similar assertion (if horizon class is defined later then that results in duplicated declaration). One benefit of include is that it doesn\u0027t require strict ordering when we compose classes by include and set parameters using hieradata.\n\nHowever this also has a disadvantage that the error doesn\u0027t clearly explain the requirement, so adding assertion would be a better approach.","commit_id":"dd917dc0176cbd26c334d09d2a841e5507bbc076"}]}