)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b68d0a661ee8d11d2c4979377f664cc0ed7479d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7ca91a9_c3af9dd7","updated":"2022-05-16 13:04:28.000000000","message":"I\u0027ve submitted a patch to implement this a while ago.\n https://review.opendev.org/c/openstack/puppet-horizon/+/830130\n\nIt was pending on the dependent patches but I think we can merge it now.\nDo you mind reviewing that change and share any concerns ?","commit_id":"56cec9e8c690f4f00b2bed11ff845eda436aa440"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"08736be991ddffa5345fa36051945b6511a43a10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a73aa95b_4da4ccd8","updated":"2022-05-16 16:11:43.000000000","message":"Once again, thanks Takashi! If that param is actually removed and no longer relevant we probs don\u0027t need this patch at all. I\u0027ll abandon for now pending discussion with designate devs.","commit_id":"56cec9e8c690f4f00b2bed11ff845eda436aa440"}],"manifests/dashboards/designate.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b68d0a661ee8d11d2c4979377f664cc0ed7479d6","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    fail(\u0027The horizon class should be included before the horizon::dashboards::designate class\u0027)"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  $log_handlers \u003d $::horizon::log_handlers"},{"line_number":43,"context_line":"  $log_level    \u003d $::horizon::log_level"},{"line_number":44,"context_line":"  $policy_files \u003d $::horizon::policy_files"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"01c0f67e_c68782eb","line":42,"updated":"2022-05-16 13:04:28.000000000","message":"these parameters are not used in current implementation.","commit_id":"56cec9e8c690f4f00b2bed11ff845eda436aa440"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b68d0a661ee8d11d2c4979377f664cc0ed7479d6","unresolved":true,"context_lines":[{"line_number":43,"context_line":"  $log_level    \u003d $::horizon::log_level"},{"line_number":44,"context_line":"  $policy_files \u003d $::horizon::policy_files"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  if $policy_files and $policy_files[\u0027dns] {"},{"line_number":47,"context_line":"    $policy_file_real \u003d $policy_files[\u0027dns\u0027]"},{"line_number":48,"context_line":"  } else {"},{"line_number":49,"context_line":"    $policy_file_real \u003d $policy_file"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ff004e7_bfc87893","line":46,"updated":"2022-05-16 13:04:28.000000000","message":"missing \u0027","commit_id":"56cec9e8c690f4f00b2bed11ff845eda436aa440"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b68d0a661ee8d11d2c4979377f664cc0ed7479d6","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  package { \u0027designate-dashboard\u0027:"},{"line_number":55,"context_line":"    ensure \u003d\u003e $::horizon::package_ensure,"},{"line_number":56,"context_line":"    name   \u003d\u003e $::horizon::params::designate_dashboard_package_name,"},{"line_number":57,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027horizon-package\u0027],"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"36cf1ddf_d1008535","line":56,"range":{"start_line":56,"start_character":34,"end_line":56,"end_character":67},"updated":"2022-05-16 13:04:28.000000000","message":"this should be defined in the base params class.","commit_id":"56cec9e8c690f4f00b2bed11ff845eda436aa440"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b68d0a661ee8d11d2c4979377f664cc0ed7479d6","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  concat::fragment { \u0027_1710_designate_settings.py\u0027:"},{"line_number":69,"context_line":"    target  \u003d\u003e $config_file,"},{"line_number":70,"context_line":"    content \u003d\u003e \"DESIGNATE \u003d { \u0027records_use_fips\u0027: True }\","},{"line_number":71,"context_line":"    order   \u003d\u003e \u002710\u0027"},{"line_number":72,"context_line":"  }"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a878413_3135e300","line":70,"range":{"start_line":70,"start_character":30,"end_line":70,"end_character":54},"updated":"2022-05-16 13:04:28.000000000","message":"afaik this is no longer valid. See https://review.opendev.org/c/openstack/designate-dashboard/+/823502/","commit_id":"56cec9e8c690f4f00b2bed11ff845eda436aa440"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"08736be991ddffa5345fa36051945b6511a43a10","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  concat::fragment { \u0027_1710_designate_settings.py\u0027:"},{"line_number":69,"context_line":"    target  \u003d\u003e $config_file,"},{"line_number":70,"context_line":"    content \u003d\u003e \"DESIGNATE \u003d { \u0027records_use_fips\u0027: True }\","},{"line_number":71,"context_line":"    order   \u003d\u003e \u002710\u0027"},{"line_number":72,"context_line":"  }"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"37112b4f_bbe474c5","line":70,"range":{"start_line":70,"start_character":30,"end_line":70,"end_character":54},"in_reply_to":"1a878413_3135e300","updated":"2022-05-16 16:11:43.000000000","message":"Hah. Okay. It may be that this patch isn\u0027t really necessary as this was the only reason for it.","commit_id":"56cec9e8c690f4f00b2bed11ff845eda436aa440"}]}