)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13cd1a83edd92b7a452d9ecbc2b36eca17dd76b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac0cc661_27a4285a","updated":"2022-08-09 01:35:25.000000000","message":"Do you mind adding a release note file to explain the new option ?","commit_id":"c4483fe033ad76718812e36af10361f82b7c12c2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4c4ddf8164e95311099b169e37760a54a1fcaac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ea9d9444_c342c096","updated":"2022-08-09 10:02:23.000000000","message":"Thanks for updating . I made a few minor edits. I hope he updated version looks good to you.","commit_id":"663326902092fef964eb136d77a015ffe648457b"}],"manifests/init.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13cd1a83edd92b7a452d9ecbc2b36eca17dd76b8","unresolved":true,"context_lines":[{"line_number":637,"context_line":"  $secure_proxy_addr_header            \u003d undef,"},{"line_number":638,"context_line":"  $disallow_iframe_embed               \u003d true,"},{"line_number":639,"context_line":"  $websso_enabled                      \u003d false,"},{"line_number":640,"context_line":"  $websso_initial_choice               \u003d undef,"},{"line_number":641,"context_line":"  $websso_choices                      \u003d undef,"},{"line_number":642,"context_line":"  $websso_choices_hide_keystone        \u003d false,"},{"line_number":643,"context_line":"  $websso_idp_mapping                  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bb1e734c_263a3199","line":640,"range":{"start_line":640,"start_character":3,"end_line":640,"end_character":24},"updated":"2022-08-09 01:35:25.000000000","message":"WEBSSO_INITIAL_CHOICE is set to \"credentials\" by default. When the credentials entry is removed then this should be set properly. Can we add a validation for that ?\n\n```\nif $websso_choices_hid_keystone and !$websso_initial_choice {\n  fail(\u0027websso_initial_choice is required when websso_choices_hid_keystone is true\u0027)\n}\n```","commit_id":"c4483fe033ad76718812e36af10361f82b7c12c2"}]}
