)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b3de1f963c5e52c94c6d429fb069eae263cf9f95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c695d979_b0ce757a","updated":"2023-08-30 01:59:19.000000000","message":"recheck https://review.opendev.org/c/openstack/puppet-openstack_spec_helper/+/892840 was merged","commit_id":"bec3f3a2147a4dea9684c70d04186169e704855b"}],"templates/local_settings.py.erb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e6ec9c6e5c01d4d32ad8ac782096e5bc19b019f7","unresolved":true,"context_lines":[{"line_number":447,"context_line":"# The OPENSTACK_HYPERVISOR_FEATURES settings can be used to enable optional"},{"line_number":448,"context_line":"# services provided by hypervisors."},{"line_number":449,"context_line":"\u003c%- if ! (@hypervisor_options.empty?) -%\u003e"},{"line_number":450,"context_line":"OPENSTACK_HYPERVISOR_FEATURES \u003d {"},{"line_number":451,"context_line":"\u003c%- @hypervisor_options.sort.each do |opt_name,opt_val| -%\u003e"},{"line_number":452,"context_line":"    \u0027\u003c%\u003d opt_name -%\u003e\u0027: \u003c%\u003d opt_val.to_s.capitalize -%\u003e,"},{"line_number":453,"context_line":"\u003c%-end-%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"92c3e8df_07dc750a","line":450,"range":{"start_line":450,"start_character":0,"end_line":450,"end_character":33},"updated":"2023-08-28 10:12:22.000000000","message":"This replaces the definition in default, so the enable_quotas parameter is disabled by this.\n\nI\u0027m wondering if updating this to\n\n```\n\u003c%- if ! (@hypervisor_options.empty?) -%\u003e\nOPENSTACK_HYPERVISOR_FEATURES.update({\n\u003c%- @hypervisor_options.sort.each do |opt_name,opt_val| -%\u003e\n    \u0027\u003c%\u003d opt_name -%\u003e\u0027: \u003c%\u003d opt_val.to_s.capitalize -%\u003e,\n\u003c%-end-%\u003e\n})\n\u003c%-end-%\u003e\n```\n\nThis keeps the default setting but override only parameters user explicitly request.","commit_id":"bec3f3a2147a4dea9684c70d04186169e704855b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b9e59178b38d9a32393d8f60c2bea77a5f6b3c93","unresolved":true,"context_lines":[{"line_number":447,"context_line":"# The OPENSTACK_HYPERVISOR_FEATURES settings can be used to enable optional"},{"line_number":448,"context_line":"# services provided by hypervisors."},{"line_number":449,"context_line":"\u003c%- if ! (@hypervisor_options.empty?) -%\u003e"},{"line_number":450,"context_line":"OPENSTACK_HYPERVISOR_FEATURES \u003d {"},{"line_number":451,"context_line":"\u003c%- @hypervisor_options.sort.each do |opt_name,opt_val| -%\u003e"},{"line_number":452,"context_line":"    \u0027\u003c%\u003d opt_name -%\u003e\u0027: \u003c%\u003d opt_val.to_s.capitalize -%\u003e,"},{"line_number":453,"context_line":"\u003c%-end-%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"bb886749_30cab501","line":450,"range":{"start_line":450,"start_character":0,"end_line":450,"end_character":33},"in_reply_to":"772bc583_826fdbd2","updated":"2023-08-28 12:09:54.000000000","message":"It makes sense, nless Horizon already does that by internally? You could do that as a follow-up then, since this just removes the hardcoded values but doesn\u0027t solve that part you are mentioning.","commit_id":"bec3f3a2147a4dea9684c70d04186169e704855b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bf17ef501c394a1ab650730890785d608619af93","unresolved":true,"context_lines":[{"line_number":447,"context_line":"# The OPENSTACK_HYPERVISOR_FEATURES settings can be used to enable optional"},{"line_number":448,"context_line":"# services provided by hypervisors."},{"line_number":449,"context_line":"\u003c%- if ! (@hypervisor_options.empty?) -%\u003e"},{"line_number":450,"context_line":"OPENSTACK_HYPERVISOR_FEATURES \u003d {"},{"line_number":451,"context_line":"\u003c%- @hypervisor_options.sort.each do |opt_name,opt_val| -%\u003e"},{"line_number":452,"context_line":"    \u0027\u003c%\u003d opt_name -%\u003e\u0027: \u003c%\u003d opt_val.to_s.capitalize -%\u003e,"},{"line_number":453,"context_line":"\u003c%-end-%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"772bc583_826fdbd2","line":450,"range":{"start_line":450,"start_character":0,"end_line":450,"end_character":33},"in_reply_to":"92c3e8df_07dc750a","updated":"2023-08-28 10:14:10.000000000","message":"I hit save with an incomplete content ...\n\n\u003e I\u0027m wondering if updating this to\n\nI\u0027m wondering if updating this to the following snippet works better.\n\n\nAlso if we agree this makes sense then I\u0027ll submit a follow-up to fix the other dict options.","commit_id":"bec3f3a2147a4dea9684c70d04186169e704855b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8aaabe770cc6a21b14c755149b869bb3b8f1a34f","unresolved":true,"context_lines":[{"line_number":447,"context_line":"# The OPENSTACK_HYPERVISOR_FEATURES settings can be used to enable optional"},{"line_number":448,"context_line":"# services provided by hypervisors."},{"line_number":449,"context_line":"\u003c%- if ! (@hypervisor_options.empty?) -%\u003e"},{"line_number":450,"context_line":"OPENSTACK_HYPERVISOR_FEATURES \u003d {"},{"line_number":451,"context_line":"\u003c%- @hypervisor_options.sort.each do |opt_name,opt_val| -%\u003e"},{"line_number":452,"context_line":"    \u0027\u003c%\u003d opt_name -%\u003e\u0027: \u003c%\u003d opt_val.to_s.capitalize -%\u003e,"},{"line_number":453,"context_line":"\u003c%-end-%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"55cfc1dd_f2764c96","line":450,"range":{"start_line":450,"start_character":0,"end_line":450,"end_character":33},"in_reply_to":"bb886749_30cab501","updated":"2023-08-28 12:22:34.000000000","message":"Yeah that\u0027s the fair point. I\u0027ll leave that change for follow-up.","commit_id":"bec3f3a2147a4dea9684c70d04186169e704855b"}]}