)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da132b35ff8af3cf91691ae4f10f3bc4ee876043","unresolved":false,"context_lines":[{"line_number":298,"context_line":"      \u0027glance/glance_api_servers\u0027: value \u003d\u003e $glance_api_servers;"},{"line_number":299,"context_line":"    }"},{"line_number":300,"context_line":"  }"},{"line_number":301,"context_line":"  "},{"line_number":302,"context_line":"  if $log_dir {"},{"line_number":303,"context_line":"    file { $log_dir:"},{"line_number":304,"context_line":"      ensure  \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_f11d5973","line":301,"updated":"2015-07-03 14:51:12.000000000","message":"whitespace","commit_id":"cc855d8bd8812a4c0bb72f8c44c9b4ee20193878"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da132b35ff8af3cf91691ae4f10f3bc4ee876043","unresolved":false,"context_lines":[{"line_number":305,"context_line":"      mode    \u003d\u003e \u00270750\u0027,"},{"line_number":306,"context_line":"      owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":307,"context_line":"      group   \u003d\u003e $::ironic::params::ironic_log_group,"},{"line_number":308,"context_line":"      require \u003d\u003e Package[\u0027ironic-common\u0027],"},{"line_number":309,"context_line":"    }"},{"line_number":310,"context_line":"    ironic_config { \u0027DEFAULT/log_dir\u0027: value \u003d\u003e $log_dir;}"},{"line_number":311,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_6c117251","line":308,"updated":"2015-07-03 14:51:12.000000000","message":"could you be consistent with other modules:\n\nhttps://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L867-L884\n\nThanks","commit_id":"cc855d8bd8812a4c0bb72f8c44c9b4ee20193878"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da132b35ff8af3cf91691ae4f10f3bc4ee876043","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  } else {"},{"line_number":312,"context_line":"    ironic_config { \u0027DEFAULT/log_dir\u0027: ensure \u003d\u003e absent;}"},{"line_number":313,"context_line":"  }"},{"line_number":314,"context_line":"  "},{"line_number":315,"context_line":"  ironic_config {"},{"line_number":316,"context_line":"    \u0027DEFAULT/verbose\u0027:                 value \u003d\u003e $verbose;"},{"line_number":317,"context_line":"    \u0027DEFAULT/debug\u0027:                   value \u003d\u003e $debug;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_91108d5a","line":314,"updated":"2015-07-03 14:51:12.000000000","message":"whitespace","commit_id":"cc855d8bd8812a4c0bb72f8c44c9b4ee20193878"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"81dd8347096603226bf81bd933bf8888278de1f2","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  file { [\u0027/etc/ironic\u0027, $log_dir]:"},{"line_number":247,"context_line":"    ensure  \u003d\u003e directory,"},{"line_number":248,"context_line":"    mode    \u003d\u003e \u00270750\u0027,"},{"line_number":249,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":250,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"},{"line_number":251,"context_line":"    require \u003d\u003e Package[\u0027ironic-common\u0027],"},{"line_number":252,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_0920869a","line":249,"updated":"2015-07-07 05:33:02.000000000","message":"we don\u0027t want to manage user/groups in our modules, either file permissions. Please drop it.","commit_id":"51506e824dee53f654de0d78e076644517b55cdb"}]}
