)]}'
{"manifests/bifrost.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# \u003d\u003d Class: ironic::bifrost"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Installs and configures Bifrost"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*git_source_repo*]"},{"line_number":20,"context_line":"#   (optional) Git repository location for pulling Bifrost"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_1247e477","line":17,"updated":"2015-07-15 12:28:27.000000000","message":"This class is a little bit \"special\", since it installs a third party tool to bootstrap Ironic.\nI would write more description about what it does, so people reading this manifest can have a first overview.","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# \u003d\u003d Class: ironic::bifrost"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Installs and configures Bifrost"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*git_source_repo*]"},{"line_number":20,"context_line":"#   (optional) Git repository location for pulling Bifrost"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_0bd24a5c","line":17,"in_reply_to":"9a41bdd9_1247e477","updated":"2015-07-15 13:23:55.000000000","message":"Done","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*git_source_repo*]"},{"line_number":20,"context_line":"#   (optional) Git repository location for pulling Bifrost"},{"line_number":21,"context_line":"#   Defaults to \u0027https://git.openstack.org/openstack/bifrost\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*revision*]"},{"line_number":24,"context_line":"#   (optional) The branch or commit to checkout on Bifrost repository"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_1215a447","line":21,"updated":"2015-07-15 12:28:27.000000000","message":"We usually don\u0027t install from source, but if there is no package, well. I guess we don\u0027t have the choice?","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*git_source_repo*]"},{"line_number":20,"context_line":"#   (optional) Git repository location for pulling Bifrost"},{"line_number":21,"context_line":"#   Defaults to \u0027https://git.openstack.org/openstack/bifrost\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*revision*]"},{"line_number":24,"context_line":"#   (optional) The branch or commit to checkout on Bifrost repository"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_0b39eaa3","line":21,"in_reply_to":"9a41bdd9_1215a447","updated":"2015-07-15 13:23:55.000000000","message":"yes, Bifrost is only available from source afaik","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*ironic_url*]"},{"line_number":28,"context_line":"#   (optional) The URL of the Ironic server"},{"line_number":29,"context_line":"#   Defaults to \u0027\"http://localhost:6385\"\u0027"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*network_interface*]"},{"line_number":32,"context_line":"#   (optional) The network interface DHCP will serve requests on"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_c66781e7","line":29,"updated":"2015-07-15 12:28:27.000000000","message":"This parameter is already present in the module:\nhttps://github.com/openstack/puppet-ironic/blob/a440277c650f00e5c11d4b05b4ed13ce487ee49b/manifests/keystone/auth.pp#L61-L72\n\nI don\u0027t know if it\u0027s relevant, but might be useful.","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"356637b4dbb1bf9b15ed037a738e15732601725f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*ironic_url*]"},{"line_number":28,"context_line":"#   (optional) The URL of the Ironic server"},{"line_number":29,"context_line":"#   Defaults to \u0027\"http://localhost:6385\"\u0027"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*network_interface*]"},{"line_number":32,"context_line":"#   (optional) The network interface DHCP will serve requests on"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_226947f9","line":29,"in_reply_to":"9a41bdd9_c66781e7","updated":"2015-07-16 08:57:43.000000000","message":"Actually, this is going to confuse users.\nBifrost installs Ironic in a standalone fashion, without Neutron or Keystone:\n\nhttp://git.openstack.org/cgit/openstack/bifrost/tree/README.rst#n104\n\nResorting to a param from keystone manifest is going to confuse users, as it may hint Keystone would be used when it\u0027s not.","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*ironic_url*]"},{"line_number":28,"context_line":"#   (optional) The URL of the Ironic server"},{"line_number":29,"context_line":"#   Defaults to \u0027\"http://localhost:6385\"\u0027"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*network_interface*]"},{"line_number":32,"context_line":"#   (optional) The network interface DHCP will serve requests on"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_cbf0e2ff","line":29,"in_reply_to":"9a41bdd9_c66781e7","updated":"2015-07-15 13:23:55.000000000","message":"Done","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   (optional) The network interface DHCP will serve requests on"},{"line_number":33,"context_line":"#    Defaults to \u0027\"virbr0\"\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*ironic_db_password*]"},{"line_number":36,"context_line":"#   (required) The Ironic DB password"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*mysql_password*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_a6dfdd67","line":35,"updated":"2015-07-15 12:28:27.000000000","message":"I think you could import the parameter from https://github.com/openstack/puppet-ironic/blob/master/manifests/init.pp#L217-L221","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   (optional) The network interface DHCP will serve requests on"},{"line_number":33,"context_line":"#    Defaults to \u0027\"virbr0\"\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*ironic_db_password*]"},{"line_number":36,"context_line":"#   (required) The Ironic DB password"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*mysql_password*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_6b8bd668","line":35,"in_reply_to":"9a41bdd9_a6dfdd67","updated":"2015-07-15 13:23:55.000000000","message":"Done","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"356637b4dbb1bf9b15ed037a738e15732601725f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   (optional) The network interface DHCP will serve requests on"},{"line_number":33,"context_line":"#    Defaults to \u0027\"virbr0\"\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*ironic_db_password*]"},{"line_number":36,"context_line":"#   (required) The Ironic DB password"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*mysql_password*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_021be381","line":35,"in_reply_to":"9a41bdd9_a6dfdd67","updated":"2015-07-16 08:57:43.000000000","message":"I assume you meant https://github.com/openstack/puppet-ironic/blob/master/manifests/db/mysql.pp","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# [*ironic_db_password*]"},{"line_number":36,"context_line":"#   (required) The Ironic DB password"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*mysql_password*]"},{"line_number":39,"context_line":"#   (required) The mysql server password"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*testing*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_a6d03d20","line":38,"updated":"2015-07-15 12:28:27.000000000","message":"Our modules do not create MySQL root password because we think it\u0027s up to the user to declare this parameter.\nWe consider the user already has the structure in place to configure MySQL (with Puppet or whatever), so we don\u0027t want to enforce this parameter.\nI guess bifrost installs MySQL server with Ansible, so I guess we can go for it now.","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# [*mysql_password*]"},{"line_number":39,"context_line":"#   (required) The mysql server password"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*testing*]"},{"line_number":42,"context_line":"#   (optional) If true, Ironic will provision libvirt and VMs instead of baremetal"},{"line_number":43,"context_line":"#   Defaults to \u0027false\u0027"},{"line_number":44,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_e67f2515","line":41,"updated":"2015-07-15 12:28:27.000000000","message":"I would rename it. Using VMs does not mean you\u0027re doing testing, isn\u0027t? I would rather use \u0027virtual\u0027 to false or something like that.","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"356637b4dbb1bf9b15ed037a738e15732601725f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# [*mysql_password*]"},{"line_number":39,"context_line":"#   (required) The mysql server password"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*testing*]"},{"line_number":42,"context_line":"#   (optional) If true, Ironic will provision libvirt and VMs instead of baremetal"},{"line_number":43,"context_line":"#   Defaults to \u0027false\u0027"},{"line_number":44,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_a549e132","line":41,"in_reply_to":"9a41bdd9_2bd70e4c","updated":"2015-07-16 08:57:43.000000000","message":"http://git.openstack.org/cgit/openstack/bifrost/tree/playbooks/inventory/group_vars/all","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# [*mysql_password*]"},{"line_number":39,"context_line":"#   (required) The mysql server password"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*testing*]"},{"line_number":42,"context_line":"#   (optional) If true, Ironic will provision libvirt and VMs instead of baremetal"},{"line_number":43,"context_line":"#   Defaults to \u0027false\u0027"},{"line_number":44,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_2bd70e4c","line":41,"in_reply_to":"9a41bdd9_e67f2515","updated":"2015-07-15 13:23:55.000000000","message":"\u0027testing\u0027 is the param name used by Bifrost playbooks, I rather leave all the params the same as the Bifrost playbooks, to not confuse users that are familiar with it.","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*testing_user*]"},{"line_number":46,"context_line":"#   (optional) VM default user in case testing is enabled"},{"line_number":47,"context_line":"#   Defaults to \u0027ubuntu\u0027"},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*http_boot_folder*]"},{"line_number":50,"context_line":"#   (optional) gPXE folder location for HTTP PXE boot"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_a67efd16","line":47,"updated":"2015-07-15 12:28:27.000000000","message":"vm_user?","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"356637b4dbb1bf9b15ed037a738e15732601725f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*testing_user*]"},{"line_number":46,"context_line":"#   (optional) VM default user in case testing is enabled"},{"line_number":47,"context_line":"#   Defaults to \u0027ubuntu\u0027"},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*http_boot_folder*]"},{"line_number":50,"context_line":"#   (optional) gPXE folder location for HTTP PXE boot"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_455495c8","line":47,"in_reply_to":"9a41bdd9_8bc65a98","updated":"2015-07-16 08:57:43.000000000","message":"http://git.openstack.org/cgit/openstack/bifrost/tree/playbooks/inventory/group_vars/all","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"356637b4dbb1bf9b15ed037a738e15732601725f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*testing_user*]"},{"line_number":46,"context_line":"#   (optional) VM default user in case testing is enabled"},{"line_number":47,"context_line":"#   Defaults to \u0027ubuntu\u0027"},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*http_boot_folder*]"},{"line_number":50,"context_line":"#   (optional) gPXE folder location for HTTP PXE boot"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_853dbdc5","line":47,"in_reply_to":"9a41bdd9_8bc65a98","updated":"2015-07-16 08:57:43.000000000","message":"http://git.openstack.org/cgit/openstack/bifrost/tree/playbooks/inventory/group_vars/all","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*testing_user*]"},{"line_number":46,"context_line":"#   (optional) VM default user in case testing is enabled"},{"line_number":47,"context_line":"#   Defaults to \u0027ubuntu\u0027"},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*http_boot_folder*]"},{"line_number":50,"context_line":"#   (optional) gPXE folder location for HTTP PXE boot"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_8bc65a98","line":47,"in_reply_to":"9a41bdd9_a67efd16","updated":"2015-07-15 13:23:55.000000000","message":"I\u0027m using the bifrost default user, they use \u0027ubuntu\u0027","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    require \u003d\u003e Vcsrepo[\u0027/opt/stack/bifrost\u0027],"},{"line_number":171,"context_line":"  }"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  file { \u0027/opt/stack/bifrost/baremetal.json\u0027:"},{"line_number":174,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":175,"context_line":"    content \u003d\u003e template(\u0027bifrost/baremetal.json.erb\u0027),"},{"line_number":176,"context_line":"    require \u003d\u003e Vcsrepo[\u0027/opt/stack/bifrost\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_5a8ede79","line":173,"updated":"2015-07-15 12:28:27.000000000","message":"we might need to make sure /opt/stack is here. Also we might need to change the path.","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    require \u003d\u003e Vcsrepo[\u0027/opt/stack/bifrost\u0027],"},{"line_number":171,"context_line":"  }"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  file { \u0027/opt/stack/bifrost/baremetal.json\u0027:"},{"line_number":174,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":175,"context_line":"    content \u003d\u003e template(\u0027bifrost/baremetal.json.erb\u0027),"},{"line_number":176,"context_line":"    require \u003d\u003e Vcsrepo[\u0027/opt/stack/bifrost\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_abc31e88","line":173,"in_reply_to":"9a41bdd9_5a8ede79","updated":"2015-07-15 13:23:55.000000000","message":"The file resources require the vcsrepo , which creates /opt/stack/bifrost.\n\nYou mean some other require test?\n\nWhat path do you suggest?","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"356637b4dbb1bf9b15ed037a738e15732601725f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    require \u003d\u003e Vcsrepo[\u0027/opt/stack/bifrost\u0027],"},{"line_number":171,"context_line":"  }"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  file { \u0027/opt/stack/bifrost/baremetal.json\u0027:"},{"line_number":174,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":175,"context_line":"    content \u003d\u003e template(\u0027bifrost/baremetal.json.erb\u0027),"},{"line_number":176,"context_line":"    require \u003d\u003e Vcsrepo[\u0027/opt/stack/bifrost\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_053a0d99","line":173,"in_reply_to":"9a41bdd9_abc31e88","updated":"2015-07-16 08:57:43.000000000","message":"Hmm, I am going to parameterize it and put it on the class signature, that way it\u0027s user configurable, thanks","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"38b83aec0aa09698840b03783117210dd2c6a9de","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class ironic::bifrost ("},{"line_number":140,"context_line":"  $git_source_repo \u003d \u0027https://git.openstack.org/openstack/bifrost\u0027,"},{"line_number":141,"context_line":"  $revision \u003d master,"},{"line_number":142,"context_line":"  $git_dest_repo_folder \u003d \u0027/opt/stack/bifrost\u0027,"},{"line_number":143,"context_line":"  $ironic_url \u003d \u0027\"http://localhost:6385/\"\u0027,"},{"line_number":144,"context_line":"  $network_interface \u003d \u0027\"virbr0\"\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a41bdd9_56a4edb7","line":141,"updated":"2015-07-17 18:33:35.000000000","message":"This is a string and should be single quoted.","commit_id":"649d89ebd9fec46b77e00ebbaf9c5c8668ec00a4"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"38b83aec0aa09698840b03783117210dd2c6a9de","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  $ironic_url \u003d \u0027\"http://localhost:6385/\"\u0027,"},{"line_number":144,"context_line":"  $network_interface \u003d \u0027\"virbr0\"\u0027,"},{"line_number":145,"context_line":"  $ironic_db_password,"},{"line_number":146,"context_line":"  $mysql_password,"},{"line_number":147,"context_line":"  $testing \u003d false,"},{"line_number":148,"context_line":"  $testing_user \u003d \u0027ubuntu\u0027,"},{"line_number":149,"context_line":"  $http_boot_folder \u003d \u0027/httpboot\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a41bdd9_d6779d39","line":146,"updated":"2015-07-17 18:33:35.000000000","message":"These are required parameters and should be at the top of the parameter list.","commit_id":"649d89ebd9fec46b77e00ebbaf9c5c8668ec00a4"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"38b83aec0aa09698840b03783117210dd2c6a9de","unresolved":false,"context_lines":[{"line_number":165,"context_line":"  $dhcp_pool_start \u003d \u0027192.168.1.200\u0027,"},{"line_number":166,"context_line":"  $dhcp_pool_end \u003d \u0027192.168.1.250\u0027,"},{"line_number":167,"context_line":"  $ipmi_bridging \u003d \u0027no\u0027,"},{"line_number":168,"context_line":"  $baremetal_json_hosts,"},{"line_number":169,"context_line":") {"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  vcsrepo { $git_dest_repo_folder:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a41bdd9_169c255c","line":168,"updated":"2015-07-17 18:33:35.000000000","message":"Ditto","commit_id":"649d89ebd9fec46b77e00ebbaf9c5c8668ec00a4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fb9df04756f936b914a8502b2aa0494be8fbf10","unresolved":false,"context_lines":[{"line_number":134,"context_line":"# [*ipmi_bridging*]"},{"line_number":135,"context_line":"#   (optional) Flag to enable/disable IPMI bridging"},{"line_number":136,"context_line":"#   Defaults to \u0027no\u0027"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class ironic::bifrost ("},{"line_number":140,"context_line":"  $ironic_db_password,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a50d1a3_9664fce5","line":137,"updated":"2015-07-23 21:49:45.000000000","message":"not worth a -1 but you have one useless line here.","commit_id":"28862e77f44083307bb3c539199884945a960159"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fb9df04756f936b914a8502b2aa0494be8fbf10","unresolved":false,"context_lines":[{"line_number":165,"context_line":"  $network_mtu \u003d \u00271500\u0027,"},{"line_number":166,"context_line":"  $dhcp_pool_start \u003d \u0027192.168.1.200\u0027,"},{"line_number":167,"context_line":"  $dhcp_pool_end \u003d \u0027192.168.1.250\u0027,"},{"line_number":168,"context_line":"  $ipmi_bridging \u003d \u0027no\u0027,"},{"line_number":169,"context_line":") {"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  vcsrepo { $git_dest_repo_folder:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a50d1a3_96ab9cd6","line":168,"updated":"2015-07-23 21:49:45.000000000","message":"same, not worth -1 but we usually like to align \"\u003d\".","commit_id":"28862e77f44083307bb3c539199884945a960159"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3bc63348d6ed39f8b3f99d817ce996a76dd8cd5e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"  $network_mtu \u003d \u00271500\u0027,"},{"line_number":166,"context_line":"  $dhcp_pool_start \u003d \u0027192.168.1.200\u0027,"},{"line_number":167,"context_line":"  $dhcp_pool_end \u003d \u0027192.168.1.250\u0027,"},{"line_number":168,"context_line":"  $ipmi_bridging \u003d \u0027no\u0027,"},{"line_number":169,"context_line":") {"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  vcsrepo { $git_dest_repo_folder:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_27ee088c","line":168,"in_reply_to":"3a50d1a3_96ab9cd6","updated":"2015-08-03 21:26:32.000000000","message":"I think it is worth a -1, if left as-is it is not easy to fix in future patches.","commit_id":"28862e77f44083307bb3c539199884945a960159"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3bc63348d6ed39f8b3f99d817ce996a76dd8cd5e","unresolved":false,"context_lines":[{"line_number":169,"context_line":") {"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  vcsrepo { $git_dest_repo_folder:"},{"line_number":172,"context_line":"    ensure   \u003d\u003e latest,"},{"line_number":173,"context_line":"    provider \u003d\u003e git,"},{"line_number":174,"context_line":"    revision \u003d\u003e $revision,"},{"line_number":175,"context_line":"    source   \u003d\u003e $git_source_repo,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_e7e7c0aa","line":172,"updated":"2015-08-03 21:26:32.000000000","message":"This should be a parameter, not everyone will want to install latest.","commit_id":"28862e77f44083307bb3c539199884945a960159"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"023e952b7e7957ff7bd3c5b3d56037cee8f7a9be","unresolved":false,"context_lines":[{"line_number":169,"context_line":") {"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  vcsrepo { $git_dest_repo_folder:"},{"line_number":172,"context_line":"    ensure   \u003d\u003e latest,"},{"line_number":173,"context_line":"    provider \u003d\u003e git,"},{"line_number":174,"context_line":"    revision \u003d\u003e $revision,"},{"line_number":175,"context_line":"    source   \u003d\u003e $git_source_repo,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_74110aac","line":172,"in_reply_to":"1a4dcd0f_e7e7c0aa","updated":"2015-08-04 07:42:17.000000000","message":"actually, that\u0027s a bug.\n\nThe revision parameter is what allows to set whichever revision, by having ensure latest that forces to have latest commit.","commit_id":"28862e77f44083307bb3c539199884945a960159"}],"metadata.json":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e0b085b1814eedf1703551b8b86c60e521db19e7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":36,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":37,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":38,"context_line":"    { \"name\": \"openstackci/vcsrepo\", \"version_requirement\": \"\u003e\u003d 0.0.8\"}"},{"line_number":39,"context_line":"  ]"},{"line_number":40,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"9a41bdd9_5ae57e35","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":34},"updated":"2015-07-15 12:28:27.000000000","message":"Please use Puppetlabs module: https://github.com/puppetlabs/puppetlabs-vcsrepo","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"da7ac5a1c39bd1bfd70bfaff909d0a208d964d3c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":36,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":37,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":38,"context_line":"    { \"name\": \"openstackci/vcsrepo\", \"version_requirement\": \"\u003e\u003d 0.0.8\"}"},{"line_number":39,"context_line":"  ]"},{"line_number":40,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"9a41bdd9_8b4dfa3f","line":38,"in_reply_to":"9a41bdd9_5ae57e35","updated":"2015-07-15 13:23:55.000000000","message":"Done","commit_id":"7958466fec29682c867ac093289e6c18feb54e99"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3bc63348d6ed39f8b3f99d817ce996a76dd8cd5e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":36,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":37,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":38,"context_line":"    { \"name\": \"puppetlabs/vcsrepo\", \"version_requirement\": \"\u003e\u003d 1.3.0\"}"},{"line_number":39,"context_line":"  ]"},{"line_number":40,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"1a4dcd0f_075f4c73","line":38,"updated":"2015-08-03 21:26:32.000000000","message":"This needs to have an upper bound of \u003c2.0.0","commit_id":"28862e77f44083307bb3c539199884945a960159"}],"spec/classes/ironic_bifrost_spec.rb":[{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"38b83aec0aa09698840b03783117210dd2c6a9de","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      :network_mtu \u003d\u003e \u00271500\u0027,"},{"line_number":46,"context_line":"      :dhcp_pool_start \u003d\u003e \u0027192.168.1.200\u0027,"},{"line_number":47,"context_line":"      :dhcp_pool_end \u003d\u003e \u0027192.168.1.250\u0027,"},{"line_number":48,"context_line":"      :ipmi_bridging \u003d\u003e \u0027no\u0027,"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"  end"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a41bdd9_36b609dd","line":48,"updated":"2015-07-17 18:33:35.000000000","message":"I don\u0027t think you need to specify all the parameters if you\u0027re just testing the base case. (And you specify them below)","commit_id":"649d89ebd9fec46b77e00ebbaf9c5c8668ec00a4"}]}