)]}'
{"manifests/bifrost.pp":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5504c31b783cc1bf83ed2aa23242b0f9c96f8b93","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# [*bifrost_config_folder*]"},{"line_number":59,"context_line":"#   (optional) Folder to keep the configuration files, namely the global vars file"},{"line_number":60,"context_line":"#   and baremetal.json"},{"line_number":61,"context_line":"#   Defaults to \u0027/etc/bifrost\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*ironic_url*]"},{"line_number":64,"context_line":"#   (optional) The URL of the Ironic server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_0f8c5534","line":61,"updated":"2015-08-21 18:14:49.000000000","message":"So, this file is kind of data, not config. I think /var/lib/bifrost/baremetal.json might make more sense as a default.","commit_id":"31229fff893f74c2000d02ea161e23f96e2e7f5a"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"3e5cbaa22fa56aa7878a576851da8b81ca0f92bf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# [*bifrost_config_folder*]"},{"line_number":59,"context_line":"#   (optional) Folder to keep the configuration files, namely the global vars file"},{"line_number":60,"context_line":"#   and baremetal.json"},{"line_number":61,"context_line":"#   Defaults to \u0027/etc/bifrost\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*ironic_url*]"},{"line_number":64,"context_line":"#   (optional) The URL of the Ironic server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_73083b92","line":61,"in_reply_to":"fa1b9901_0f8c5534","updated":"2015-08-23 18:36:39.000000000","message":"Ok, it\u0027s kind of a gray area. Yes, it\u0027s data, but it also contains config to set up the servers to provision.\n\nI think adding another folder just to contain baremetal.json is not worth it, rather have one to contain both.","commit_id":"31229fff893f74c2000d02ea161e23f96e2e7f5a"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"78937bb593fc2017782d4d059ca00ba221aefa45","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# [*bifrost_config_folder*]"},{"line_number":59,"context_line":"#   (optional) Folder to keep the configuration files, namely the global vars file"},{"line_number":60,"context_line":"#   and baremetal.json"},{"line_number":61,"context_line":"#   Defaults to \u0027/etc/bifrost\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*ironic_url*]"},{"line_number":64,"context_line":"#   (optional) The URL of the Ironic server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_16d0cdc8","line":61,"in_reply_to":"fa1b9901_73083b92","updated":"2015-08-23 22:27:57.000000000","message":"kk, gray area it is. No minus one about this.","commit_id":"31229fff893f74c2000d02ea161e23f96e2e7f5a"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5504c31b783cc1bf83ed2aa23242b0f9c96f8b93","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  file { \"${bifrost_config_folder}/bifrost_global_vars\":"},{"line_number":201,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":202,"context_line":"    content \u003d\u003e template(\u0027ironic/group_vars_all.erb\u0027),"},{"line_number":203,"context_line":"    require \u003d\u003e File[$bifrost_config_folder],"},{"line_number":204,"context_line":"  }"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"  file { \"${bifrost_config_folder}/baremetal.json\":"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_cf9c1d60","line":203,"updated":"2015-08-21 18:14:49.000000000","message":"It might need to go in a follow-up patch, but modifying group_vars in this way is actually the wrong approach. We shouldn\u0027t be modifying these files at all. The playbooks can be run with -e @some/yaml/file and any overrides should go there.","commit_id":"31229fff893f74c2000d02ea161e23f96e2e7f5a"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"78937bb593fc2017782d4d059ca00ba221aefa45","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  file { \"${bifrost_config_folder}/bifrost_global_vars\":"},{"line_number":201,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":202,"context_line":"    content \u003d\u003e template(\u0027ironic/group_vars_all.erb\u0027),"},{"line_number":203,"context_line":"    require \u003d\u003e File[$bifrost_config_folder],"},{"line_number":204,"context_line":"  }"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"  file { \"${bifrost_config_folder}/baremetal.json\":"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_d6da55e9","line":203,"in_reply_to":"fa1b9901_93daaf16","updated":"2015-08-23 22:27:57.000000000","message":"AHA! I\u0027m sorry I\u0027m really awful at understanding puppet, so I missed that. I suggest calling it something else to make it clear that this is for overriding defaults.\n\nForgive me if I\u0027m crazy here, but is this really how puppet modules work? You override _EVERY_ upstream default with the default as it was the day you wrote the config file?\n\n:-P\n\nAnyway, given that we expect people to use -e @/this/file I suggest that would be something that must be added to the documentation of the module.","commit_id":"31229fff893f74c2000d02ea161e23f96e2e7f5a"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"3e5cbaa22fa56aa7878a576851da8b81ca0f92bf","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  file { \"${bifrost_config_folder}/bifrost_global_vars\":"},{"line_number":201,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":202,"context_line":"    content \u003d\u003e template(\u0027ironic/group_vars_all.erb\u0027),"},{"line_number":203,"context_line":"    require \u003d\u003e File[$bifrost_config_folder],"},{"line_number":204,"context_line":"  }"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"  file { \"${bifrost_config_folder}/baremetal.json\":"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_93daaf16","line":203,"in_reply_to":"fa1b9901_cf9c1d60","updated":"2015-08-23 18:36:39.000000000","message":"This is the purpose of this patch, to not have to use group_vars/all at all.\n\nThe name of template is group_vars_all, but in reality it\u0027s used to templatize the target file /etc/bifrost/bifrost_global_vars, not ${git_source_repo}/group_vars/all.\n\nWe are creating on this patch:\n\n/etc/bifrost\n\n/etc/bifrost/baremetal.json\n\n/etc/bifrost/bifrost_global_vars (with the contents of template group_vars_all.erb)","commit_id":"31229fff893f74c2000d02ea161e23f96e2e7f5a"}]}