)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"071320914b88d1c0706f9bcaf425456ff3d7f183","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This patch also pulls the /tftpboot/ directory out of the if"},{"line_number":19,"context_line":"block relating only to tftp configuration. The /tftpboot/"},{"line_number":20,"context_line":"directory is also used by iPXE/http for the undionly.kpxe"},{"line_number":21,"context_line":"chainloading image."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Id20802b457a8c75d8b1af04a2d2f56b6b776536e"},{"line_number":24,"context_line":"Closes-Bug: 1515630"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_482fe33e","line":21,"updated":"2015-11-19 20:38:03.000000000","message":"So what\u0027s /httpboot/ for if iPXE/http uses tftpboot?","commit_id":"8a5f7f7bb7a3cdf3f70ce3e702ed1d84a67614c9"}],"manifests/inspector.pp":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"3c1c57287a9446367eab28d3f7332da1360323b9","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_dnsmasq_http.erb\u0027),"},{"line_number":197,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":198,"context_line":"    }"},{"line_number":199,"context_line":"    file { \u0027/tftpboot\u0027:"},{"line_number":200,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":201,"context_line":"      seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":202,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_232cf497","line":199,"updated":"2015-11-12 14:52:49.000000000","message":"Why do we need to ensure things about /tftpboot if we\u0027re using HTTP for transfer? Is /tftpboot used for something else later? If so, should this block just be hoisted out of both if-statements?","commit_id":"206c39d7fbbb2f4022f1d608f1108bc258222e14"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"e139c0068d8a62828a654491597bbdd70fb21c85","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_dnsmasq_http.erb\u0027),"},{"line_number":197,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":198,"context_line":"    }"},{"line_number":199,"context_line":"    file { \u0027/tftpboot\u0027:"},{"line_number":200,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":201,"context_line":"      seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":202,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_634f5c34","line":199,"in_reply_to":"da85f559_232cf497","updated":"2015-11-12 14:56:58.000000000","message":"Ah right... good call about moving it from the if statements.\n\nThe /tftpboot/ dir is used by ipxe for the chainloading of the .ipxe image.","commit_id":"206c39d7fbbb2f4022f1d608f1108bc258222e14"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fbc6aba7b3dfb1c6357c440686a479f4390dd1ff","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":170,"context_line":"    require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":171,"context_line":"  }"},{"line_number":172,"context_line":"  file { \u0027/tftpboot\u0027:"},{"line_number":173,"context_line":"    ensure  \u003d\u003e \u0027directory\u0027,"},{"line_number":174,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":175,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_c7990421","line":172,"updated":"2015-11-17 19:36:45.000000000","message":"Why do you move out the file resource from the next conditional? Now the directory will be created for any pxe transfer protocol.","commit_id":"69c803def4c91e1338e6e1434060303d2d9b2b0b"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"0d99dd7f007330bf71a1d16d2690522913b114b1","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":170,"context_line":"    require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":171,"context_line":"  }"},{"line_number":172,"context_line":"  file { \u0027/tftpboot\u0027:"},{"line_number":173,"context_line":"    ensure  \u003d\u003e \u0027directory\u0027,"},{"line_number":174,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":175,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_4df53581","line":172,"in_reply_to":"ba8a016a_c7990421","updated":"2015-11-17 20:11:05.000000000","message":"We actually hit this issue when using http/iPXE. Because iPXE still uses the tftpboot directory for the undionly.kpxe chainloading image. So we need to create the directory for both cases.","commit_id":"69c803def4c91e1338e6e1434060303d2d9b2b0b"}]}