)]}'
{"manifests/inspector.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4e9b85a08aa878337fdfc4c63f16010efeacfd45","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*admin_user*]"},{"line_number":45,"context_line":"#   (optional) The name of the auth user"},{"line_number":46,"context_line":"#   Defaults to \u0027baremetal-introspection\u0027"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*admin_password*]"},{"line_number":49,"context_line":"#   (optional) The password to use for authentication (keystone)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_dbb6cef8","line":46,"updated":"2015-12-10 17:04:12.000000000","message":"we break backward compatibility  here, isn\u0027t it a big deal?","commit_id":"69ed12f76da383af208a72835e9877bdd68264fb"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"e2102a83e8550878aad0feba9dd07c7da1cf289e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*admin_user*]"},{"line_number":45,"context_line":"#   (optional) The name of the auth user"},{"line_number":46,"context_line":"#   Defaults to \u0027baremetal-introspection\u0027"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*admin_password*]"},{"line_number":49,"context_line":"#   (optional) The password to use for authentication (keystone)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_786bd8b9","line":46,"in_reply_to":"7a740942_dbb6cef8","updated":"2015-12-11 19:46:51.000000000","message":"I would like to be backwards compatible.\n\nIf we use \u0027ironic\u0027 here I think we should use it in the auth::inspector class as well. I feel like this is the *wrong* default though.\n\n What do you think?","commit_id":"69ed12f76da383af208a72835e9877bdd68264fb"}],"manifests/keystone/auth_inspector.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c827db85b21cf8a3e7c54410530f10c2af079002","unresolved":false,"context_lines":[{"line_number":49,"context_line":"#   Defaults to the value of auth_name, but must differ from the value."},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"# [*service_type*]"},{"line_number":52,"context_line":"#   Type of service. Defaults to \u0027baremetal_inspector\u0027."},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*service_description*]"},{"line_number":55,"context_line":"#   (Optional) Description for keystone service."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_7d49ee8a","line":52,"updated":"2015-12-04 13:36:25.000000000","message":"that\u0027s not the same as below","commit_id":"71e7f7d2aa95eb89dd774512e8bc3b168fe2d92d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c827db85b21cf8a3e7c54410530f10c2af079002","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  $configure_user      \u003d true,"},{"line_number":88,"context_line":"  $configure_user_role \u003d true,"},{"line_number":89,"context_line":"  $service_name        \u003d undef,"},{"line_number":90,"context_line":"  $service_type        \u003d \u0027inspector\u0027,"},{"line_number":91,"context_line":"  $service_description \u003d \u0027Ironic Inspector Service\u0027,"},{"line_number":92,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":93,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:5050\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_5d6d1203","line":90,"updated":"2015-12-04 13:36:25.000000000","message":"this should use an official name, not a code name. We don\u0027t have an official name, so one should be derived from ironic official name \u0027baremetal\u0027. \u0027baremetal-introspection\u0027 sounds a good fit, as it corresponds to our OSC prefix. \u0027baremetal-inspector\u0027 also sounds nice, but I guess just \u0027inspector\u0027 is too generic.","commit_id":"71e7f7d2aa95eb89dd774512e8bc3b168fe2d92d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f24f73ee7baecc4860aba9676272e537c5ff2b9f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"class ironic::keystone::auth_inspector ("},{"line_number":82,"context_line":"  $password,"},{"line_number":83,"context_line":"  $auth_name           \u003d \u0027baremetal-introspection\u0027,"},{"line_number":84,"context_line":"  $email               \u003d \u0027baremetal-introspection@localhost\u0027,"},{"line_number":85,"context_line":"  $tenant              \u003d \u0027services\u0027,"},{"line_number":86,"context_line":"  $configure_endpoint  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_31e7f141","line":83,"updated":"2015-12-10 17:30:39.000000000","message":"I think for user names we default to a project nick names, so ironic-inspector would be better here","commit_id":"69ed12f76da383af208a72835e9877bdd68264fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"819f1b65aa9722eb772442d85e76379939fece6d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"class ironic::keystone::auth_inspector ("},{"line_number":82,"context_line":"  $password,"},{"line_number":83,"context_line":"  $auth_name           \u003d \u0027baremetal-introspection\u0027,"},{"line_number":84,"context_line":"  $email               \u003d \u0027baremetal-introspection@localhost\u0027,"},{"line_number":85,"context_line":"  $tenant              \u003d \u0027services\u0027,"},{"line_number":86,"context_line":"  $configure_endpoint  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a7e1126_ba9b5117","line":83,"range":{"start_line":83,"start_character":26,"end_line":83,"end_character":49},"updated":"2015-12-21 10:05:06.000000000","message":"default user name for ironic is ironic, not sure why not use ironic-inspector here. it will also be more consistent with what we do now IIRC","commit_id":"d318d63c051ca65b898c74e946c99d0435304c16"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"533c4c0c4ca0438735ef4bd608f8e80491111c37","unresolved":false,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"class ironic::keystone::auth_inspector ("},{"line_number":82,"context_line":"  $password,"},{"line_number":83,"context_line":"  $auth_name           \u003d \u0027baremetal-introspection\u0027,"},{"line_number":84,"context_line":"  $email               \u003d \u0027baremetal-introspection@localhost\u0027,"},{"line_number":85,"context_line":"  $tenant              \u003d \u0027services\u0027,"},{"line_number":86,"context_line":"  $configure_endpoint  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a7e1126_d7d5b9e4","line":83,"range":{"start_line":83,"start_character":26,"end_line":83,"end_character":49},"in_reply_to":"3a7e1126_37dc3d45","updated":"2015-12-21 19:29:33.000000000","message":"Dmitry: so auth_name gets used as the resource name below for keystone::resource::service_identity. Agree this doesn\u0027t currently match what is in inspector.pp but I think that is okay. FWIW this functionally seems to work fine for me.","commit_id":"d318d63c051ca65b898c74e946c99d0435304c16"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"cb36eee8ed1dfcf79a2222f416f091bfcba52822","unresolved":false,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"class ironic::keystone::auth_inspector ("},{"line_number":82,"context_line":"  $password,"},{"line_number":83,"context_line":"  $auth_name           \u003d \u0027baremetal-introspection\u0027,"},{"line_number":84,"context_line":"  $email               \u003d \u0027baremetal-introspection@localhost\u0027,"},{"line_number":85,"context_line":"  $tenant              \u003d \u0027services\u0027,"},{"line_number":86,"context_line":"  $configure_endpoint  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a7e1126_37dc3d45","line":83,"range":{"start_line":83,"start_character":26,"end_line":83,"end_character":49},"in_reply_to":"3a7e1126_ba9b5117","updated":"2015-12-21 19:24:16.000000000","message":"Well I was trying to at least take a step towards using a unique keystone user for the inspector API. If we are fine always sharing w/ \u0027ironic\u0027 I guess changing it here to match is the thing to do.","commit_id":"d318d63c051ca65b898c74e946c99d0435304c16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"610a4982f2126dc93902b6d878df06fe9c7ec2dc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"class ironic::keystone::auth_inspector ("},{"line_number":82,"context_line":"  $password,"},{"line_number":83,"context_line":"  $auth_name           \u003d \u0027baremetal-introspection\u0027,"},{"line_number":84,"context_line":"  $email               \u003d \u0027baremetal-introspection@localhost\u0027,"},{"line_number":85,"context_line":"  $tenant              \u003d \u0027services\u0027,"},{"line_number":86,"context_line":"  $configure_endpoint  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a7b0d38_e04bf557","line":83,"range":{"start_line":83,"start_character":26,"end_line":83,"end_character":49},"in_reply_to":"3a7e1126_d7d5b9e4","updated":"2015-12-23 17:42:38.000000000","message":"I was thinking to have our own user called ironic-inspector. Just like for ironic we have user \u0027ironic\u0027 and service type \u0027baremetal\u0027. But I\u0027m fine with anything that moves us forward :)","commit_id":"d318d63c051ca65b898c74e946c99d0435304c16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"819f1b65aa9722eb772442d85e76379939fece6d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  $configure_user      \u003d true,"},{"line_number":88,"context_line":"  $configure_user_role \u003d true,"},{"line_number":89,"context_line":"  $service_name        \u003d undef,"},{"line_number":90,"context_line":"  $service_type        \u003d \u0027baremetal-introspection\u0027,"},{"line_number":91,"context_line":"  $service_description \u003d \u0027Baremetal Introspection Service\u0027,"},{"line_number":92,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":93,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:5050\u0027,"},{"line_number":94,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:5050\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a7e1126_7aa16945","line":91,"range":{"start_line":90,"start_character":2,"end_line":91,"end_character":58},"updated":"2015-12-21 10:05:06.000000000","message":"LGTM","commit_id":"d318d63c051ca65b898c74e946c99d0435304c16"}]}