)]}'
{"manifests/inspector.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a8c6aa0efa14a23e16a461957044b68252e5c3c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  $package_ensure                  \u003d \u0027present\u0027,"},{"line_number":147,"context_line":"  $enabled                         \u003d true,"},{"line_number":148,"context_line":"  $pxe_transfer_protocol           \u003d \u0027tftp\u0027,"},{"line_number":149,"context_line":"  $debug                           \u003d false,"},{"line_number":150,"context_line":"  $auth_uri                        \u003d \u0027http://127.0.0.1:5000/v2.0\u0027,"},{"line_number":151,"context_line":"  $identity_uri                    \u003d \u0027http://127.0.0.1:35357\u0027,"},{"line_number":152,"context_line":"  $admin_user                      \u003d \u0027ironic\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5aef4532_a2e6b412","line":149,"range":{"start_line":149,"start_character":37,"end_line":149,"end_character":42},"updated":"2016-03-09 11:14:17.000000000","message":"you should set it to undef","commit_id":"e25c33e8751455328e99794e80ff6948d18e9f58"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"68c724ddac3298c4883577fcd4ba0486f622b17c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  $package_ensure                  \u003d \u0027present\u0027,"},{"line_number":147,"context_line":"  $enabled                         \u003d true,"},{"line_number":148,"context_line":"  $pxe_transfer_protocol           \u003d \u0027tftp\u0027,"},{"line_number":149,"context_line":"  $debug                           \u003d false,"},{"line_number":150,"context_line":"  $auth_uri                        \u003d \u0027http://127.0.0.1:5000/v2.0\u0027,"},{"line_number":151,"context_line":"  $identity_uri                    \u003d \u0027http://127.0.0.1:35357\u0027,"},{"line_number":152,"context_line":"  $admin_user                      \u003d \u0027ironic\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5aef4532_aaa96692","line":149,"range":{"start_line":149,"start_character":37,"end_line":149,"end_character":42},"in_reply_to":"5aef4532_a2e6b412","updated":"2016-03-09 12:23:34.000000000","message":"Done","commit_id":"e25c33e8751455328e99794e80ff6948d18e9f58"}],"spec/classes/ironic_inspector_logging_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7bc6443f841e2e0a276917f7eb43847e8e03aab9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      }"},{"line_number":125,"context_line":"  end"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":128,"context_line":"    let :facts do"},{"line_number":129,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":130,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5aef4532_d12bf9e9","line":127,"updated":"2016-03-08 18:02:41.000000000","message":"Ideally this should use the on_supported_os pattern, https://github.com/openstack/puppet-designate/blob/master/spec/classes/designate_logging_spec.rb#L126-L136","commit_id":"e25c33e8751455328e99794e80ff6948d18e9f58"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8573031051c7f9af9bd8a5f9eeab1dcc22930e5f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      }"},{"line_number":125,"context_line":"  end"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":128,"context_line":"    let :facts do"},{"line_number":129,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":130,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5aef4532_c45dbd7a","line":127,"in_reply_to":"5aef4532_0d51a136","updated":"2016-03-09 15:11:48.000000000","message":"Yea the on_support_os is the newer style we\u0027re moving to. It\u0027s not a major thing, just a nice to have because we\u0027ll have to come through and update this when we update the ironic module.","commit_id":"e25c33e8751455328e99794e80ff6948d18e9f58"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb9fdf9ad71dee7dee7849f78532b699bef0b491","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      }"},{"line_number":125,"context_line":"  end"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":128,"context_line":"    let :facts do"},{"line_number":129,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":130,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5aef4532_0d51a136","line":127,"in_reply_to":"5aef4532_d12bf9e9","updated":"2016-03-09 09:35:51.000000000","message":"Yeah, maybe :) I just copy-pasted it from ironic\u0027s configuration","commit_id":"e25c33e8751455328e99794e80ff6948d18e9f58"}]}
