)]}'
{"manifests/drivers/pxe.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7cf8a334214a5826d473c4ae85cc0f4f20b1733e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $uefi_pxe_bootfile_name   \u003d \u0027elilo.efi\u0027,"},{"line_number":101,"context_line":"  $uefi_pxe_config_template \u003d \u0027$pybasedir/drivers/modules/elilo_efi_pxe_config.template\u0027,"},{"line_number":102,"context_line":"  $ipxe_timeout             \u003d \u00270\u0027,"},{"line_number":103,"context_line":"  $ipxe_enabled             \u003d false,"},{"line_number":104,"context_line":") {"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_efd97ef4","line":103,"updated":"2016-03-24 08:37:16.000000000","message":"from what i see ironic has os_service_default facts, i think this parameter should be set to $::os_service_default https://wiki.openstack.org/wiki/Puppet/Coding_style","commit_id":"82273cac48768b929c661642be9bf3b6bbde1a5f"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"9afb6b028715f4199ee17001b15832908e0be92e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $uefi_pxe_bootfile_name   \u003d \u0027elilo.efi\u0027,"},{"line_number":101,"context_line":"  $uefi_pxe_config_template \u003d \u0027$pybasedir/drivers/modules/elilo_efi_pxe_config.template\u0027,"},{"line_number":102,"context_line":"  $ipxe_timeout             \u003d \u00270\u0027,"},{"line_number":103,"context_line":"  $ipxe_enabled             \u003d false,"},{"line_number":104,"context_line":") {"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_9de74eab","line":103,"in_reply_to":"fa0719c6_836d36ce","updated":"2016-03-24 13:13:44.000000000","message":"good to know. Thanks. Why os_service_default is not used for the other variables here?","commit_id":"82273cac48768b929c661642be9bf3b6bbde1a5f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"809cf764f8b2399833c734ee9951f5ea24a2ac67","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $uefi_pxe_bootfile_name   \u003d \u0027elilo.efi\u0027,"},{"line_number":101,"context_line":"  $uefi_pxe_config_template \u003d \u0027$pybasedir/drivers/modules/elilo_efi_pxe_config.template\u0027,"},{"line_number":102,"context_line":"  $ipxe_timeout             \u003d \u00270\u0027,"},{"line_number":103,"context_line":"  $ipxe_enabled             \u003d false,"},{"line_number":104,"context_line":") {"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_11b9652e","line":103,"in_reply_to":"fa0719c6_9de74eab","updated":"2016-03-24 14:03:06.000000000","message":"Gonéri,puppet-ironic module is not switched to this pattern across whole module. But when someone adding a new parameter, we ask to keep this pattern, if it possible.","commit_id":"82273cac48768b929c661642be9bf3b6bbde1a5f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9fc0b8cd96b57e29d51b7ab3411ffa974ba9e94d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $uefi_pxe_bootfile_name   \u003d \u0027elilo.efi\u0027,"},{"line_number":101,"context_line":"  $uefi_pxe_config_template \u003d \u0027$pybasedir/drivers/modules/elilo_efi_pxe_config.template\u0027,"},{"line_number":102,"context_line":"  $ipxe_timeout             \u003d \u00270\u0027,"},{"line_number":103,"context_line":"  $ipxe_enabled             \u003d false,"},{"line_number":104,"context_line":") {"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_836d36ce","line":103,"in_reply_to":"fa0719c6_efd97ef4","updated":"2016-03-24 10:39:59.000000000","message":"If False value is default value for ironic conf - yes, then +1.","commit_id":"82273cac48768b929c661642be9bf3b6bbde1a5f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3871f31707cd9c13946ef50bffde32584b88a5bf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"# [*ipxe_enabled*]"},{"line_number":86,"context_line":"#   (optional) Enable ipxe support"},{"line_number":87,"context_line":"#   Defaults to False."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class ironic::drivers::pxe ("},{"line_number":90,"context_line":"  $deploy_kernel            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa0719c6_b1db597b","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":21},"updated":"2016-03-24 14:04:36.000000000","message":"$::os_service_default","commit_id":"15ddfd7e0980939540ff940ad1760c6ca021329b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f2ee8a8f5e4ebffeac09a5bb042626430031ce4f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"# [*ipxe_enabled*]"},{"line_number":86,"context_line":"#   (optional) Enable ipxe support"},{"line_number":87,"context_line":"#   Defaults to False."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class ironic::drivers::pxe ("},{"line_number":90,"context_line":"  $deploy_kernel            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da0c15f0_2cd0071f","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":21},"updated":"2016-03-28 10:32:04.000000000","message":"$::os_service_default","commit_id":"5a733c74ea0af2282cf4b082dc07db8dfd269088"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"b9596f5a5035363da8bb631e3156e2190bf90ecb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"# [*ipxe_enabled*]"},{"line_number":86,"context_line":"#   (optional) Enable ipxe support"},{"line_number":87,"context_line":"#   Defaults to False."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class ironic::drivers::pxe ("},{"line_number":90,"context_line":"  $deploy_kernel            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_dbb051e0","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":21},"in_reply_to":"da0c15f0_2cd0071f","updated":"2016-03-29 14:33:29.000000000","message":"Done","commit_id":"5a733c74ea0af2282cf4b082dc07db8dfd269088"}],"spec/classes/ironic_drivers_pxe_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3871f31707cd9c13946ef50bffde32584b88a5bf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      :uefi_pxe_bootfile_name   \u003d\u003e \u0027elilo.efi\u0027,"},{"line_number":35,"context_line":"      :uefi_pxe_config_template \u003d\u003e \u0027$pybasedir/drivers/modules/elilo_efi_pxe_config.template\u0027,"},{"line_number":36,"context_line":"      :ipxe_timeout             \u003d\u003e 0,"},{"line_number":37,"context_line":"      :ipxe_enabled             \u003d\u003e false"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa0719c6_51d3dd5f","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":40},"updated":"2016-03-24 14:04:36.000000000","message":"do not put it here","commit_id":"15ddfd7e0980939540ff940ad1760c6ca021329b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3871f31707cd9c13946ef50bffde32584b88a5bf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/tftp_master_path\u0027).with_value(p[:tftp_master_path])"},{"line_number":58,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/instance_master_path\u0027).with_value(p[:instance_master_path])"},{"line_number":59,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_bootfile_name\u0027).with_value(p[:uefi_pxe_bootfile_name])"},{"line_number":60,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_config_template\u0027).with_value(p[:uefi_pxe_config_template])"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    context \u0027when overriding parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa0719c6_1155e5c4","line":60,"updated":"2016-03-24 14:04:36.000000000","message":"is_expected.to contain_ironic_config(\u0027pxe/ipxe_enabled\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)","commit_id":"15ddfd7e0980939540ff940ad1760c6ca021329b"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"a75e64608cca96a65982c9aabdc08d6accf20235","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/tftp_master_path\u0027).with_value(p[:tftp_master_path])"},{"line_number":58,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/instance_master_path\u0027).with_value(p[:instance_master_path])"},{"line_number":59,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_bootfile_name\u0027).with_value(p[:uefi_pxe_bootfile_name])"},{"line_number":60,"context_line":"      is_expected.to contain_ironic_config(\u0027pxe/uefi_pxe_config_template\u0027).with_value(p[:uefi_pxe_config_template])"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    context \u0027when overriding parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa0719c6_0e9e5fb8","line":60,"in_reply_to":"fa0719c6_1155e5c4","updated":"2016-03-24 14:28:45.000000000","message":"Done","commit_id":"15ddfd7e0980939540ff940ad1760c6ca021329b"}]}
