)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a50eae9fc82073e9c1908b16d6ad6aba964d0922","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Messaging (rabbit), db and logging parameters"},{"line_number":10,"context_line":"are configured using puppet-oslo module"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Additonal changes:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* switch messaging related parameters to"},{"line_number":15,"context_line":"  $::os_service_default as they are used"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_55be5bae","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":9},"updated":"2016-04-27 14:45:31.000000000","message":"s/Additonal/Additional/","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"aefbfc4d2ecd965737e197b9becb9d9372e5c68c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Messaging (rabbit), db and logging parameters"},{"line_number":10,"context_line":"are configured using puppet-oslo module"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Additonal changes:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* switch messaging related parameters to"},{"line_number":15,"context_line":"  $::os_service_default as they are used"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_3f6ba786","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":9},"in_reply_to":"1a122d0e_55be5bae","updated":"2016-04-28 12:26:34.000000000","message":"Done","commit_id":"416af9c866a871656fd08c251038c8da49659db4"}],"manifests/db.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"4621eebdc759dc21ad2a15f41e15bba0d2dbd35f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $database_max_pool_size_real \u003d pick($::ironic::database_max_pool_size, $database_max_pool_size)"},{"line_number":54,"context_line":"  $database_max_overflow_real \u003d pick($::ironic::database_max_overflow, $database_max_overflow)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  validate_re($database_connection_real,"},{"line_number":57,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  oslo::db { \u0027ironic_config\u0027:"},{"line_number":60,"context_line":"    connection     \u003d\u003e $database_connection_real,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_8ca2d6fa","line":57,"range":{"start_line":56,"start_character":2,"end_line":57,"end_character":69},"updated":"2016-04-26 09:11:46.000000000","message":"Looks like this can be removed, as it\u0027s validated in puppet-oslo","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"16dd9f71f77cd0bb25359ac6ab60ef43922ad54d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $database_max_pool_size_real \u003d pick($::ironic::database_max_pool_size, $database_max_pool_size)"},{"line_number":54,"context_line":"  $database_max_overflow_real \u003d pick($::ironic::database_max_overflow, $database_max_overflow)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  validate_re($database_connection_real,"},{"line_number":57,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  oslo::db { \u0027ironic_config\u0027:"},{"line_number":60,"context_line":"    connection     \u003d\u003e $database_connection_real,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_7646217c","line":57,"range":{"start_line":56,"start_character":2,"end_line":57,"end_character":69},"in_reply_to":"1a122d0e_166a4d81","updated":"2016-04-26 13:18:46.000000000","message":"i just checked with ironic developer - only sqlite, mysql, postgresql are supported, mongodb isn\u0027t","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"62b25425e6eeb5d8948928f645d58f0137a37905","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $database_max_pool_size_real \u003d pick($::ironic::database_max_pool_size, $database_max_pool_size)"},{"line_number":54,"context_line":"  $database_max_overflow_real \u003d pick($::ironic::database_max_overflow, $database_max_overflow)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  validate_re($database_connection_real,"},{"line_number":57,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  oslo::db { \u0027ironic_config\u0027:"},{"line_number":60,"context_line":"    connection     \u003d\u003e $database_connection_real,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_1ed37a05","line":57,"range":{"start_line":56,"start_character":2,"end_line":57,"end_character":69},"in_reply_to":"1a122d0e_7646217c","updated":"2016-04-26 18:40:29.000000000","message":"Ok, got it","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"e8a84efeae8536d7864f7db4e6da77b53ec6a265","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $database_max_pool_size_real \u003d pick($::ironic::database_max_pool_size, $database_max_pool_size)"},{"line_number":54,"context_line":"  $database_max_overflow_real \u003d pick($::ironic::database_max_overflow, $database_max_overflow)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  validate_re($database_connection_real,"},{"line_number":57,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  oslo::db { \u0027ironic_config\u0027:"},{"line_number":60,"context_line":"    connection     \u003d\u003e $database_connection_real,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_ec99ca7a","line":57,"range":{"start_line":56,"start_character":2,"end_line":57,"end_character":69},"in_reply_to":"1a122d0e_8ca2d6fa","updated":"2016-04-26 09:19:44.000000000","message":"as i saw here https://review.openstack.org/#/c/304740/ it was decided to keep database connection validation in modules","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"087090b085ca14064cadb3716cb394b272ee7f6d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $database_max_pool_size_real \u003d pick($::ironic::database_max_pool_size, $database_max_pool_size)"},{"line_number":54,"context_line":"  $database_max_overflow_real \u003d pick($::ironic::database_max_overflow, $database_max_overflow)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  validate_re($database_connection_real,"},{"line_number":57,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  oslo::db { \u0027ironic_config\u0027:"},{"line_number":60,"context_line":"    connection     \u003d\u003e $database_connection_real,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_166a4d81","line":57,"range":{"start_line":56,"start_character":2,"end_line":57,"end_character":69},"in_reply_to":"1a122d0e_ec99ca7a","updated":"2016-04-26 12:58:50.000000000","message":"Yes we\u0027re keeping it here if we need something more restrictive than what we have in oslo","commit_id":"416af9c866a871656fd08c251038c8da49659db4"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e3f9ae4492e9b3779419244c7fbde454616b5ebf","unresolved":false,"context_lines":[{"line_number":306,"context_line":"  ironic_config {"},{"line_number":307,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:           value \u003d\u003e $auth_strategy;"},{"line_number":308,"context_line":"    \u0027DEFAULT/enabled_drivers\u0027:         value \u003d\u003e join($enabled_drivers, \u0027,\u0027);"},{"line_number":309,"context_line":"    \u0027DEFAULT/control_exchange\u0027:        value \u003d\u003e $control_exchange;"},{"line_number":310,"context_line":"    \u0027glance/glance_num_retries\u0027:       value \u003d\u003e $glance_num_retries;"},{"line_number":311,"context_line":"    \u0027glance/glance_api_insecure\u0027:      value \u003d\u003e $glance_api_insecure;"},{"line_number":312,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a122d0e_092cfd97","line":309,"updated":"2016-04-26 01:19:47.000000000","message":"https://github.com/openstack/puppet-oslo/blob/master/manifests/messaging/default.pp#L30","commit_id":"1ec435c1c76c83716064c5dbfb857250e1174482"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"8832317e84a3d978d64e427eefcbf2a06bbf6c05","unresolved":false,"context_lines":[{"line_number":306,"context_line":"  ironic_config {"},{"line_number":307,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:           value \u003d\u003e $auth_strategy;"},{"line_number":308,"context_line":"    \u0027DEFAULT/enabled_drivers\u0027:         value \u003d\u003e join($enabled_drivers, \u0027,\u0027);"},{"line_number":309,"context_line":"    \u0027DEFAULT/control_exchange\u0027:        value \u003d\u003e $control_exchange;"},{"line_number":310,"context_line":"    \u0027glance/glance_num_retries\u0027:       value \u003d\u003e $glance_num_retries;"},{"line_number":311,"context_line":"    \u0027glance/glance_api_insecure\u0027:      value \u003d\u003e $glance_api_insecure;"},{"line_number":312,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a122d0e_2c2c6298","line":309,"in_reply_to":"1a122d0e_092cfd97","updated":"2016-04-26 09:09:04.000000000","message":"Done","commit_id":"1ec435c1c76c83716064c5dbfb857250e1174482"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"0ddcaf2895fe4edab14cb1afcd498a55957d152e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#  Defaults to [\u0027pxe_ipmitool\u0027]."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*control_exchange*]"},{"line_number":50,"context_line":"#   (optional) What RPC queue/exchange to use (string value)"},{"line_number":51,"context_line":"#   Defaults to $::os_service_default"},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*rpc_backend*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_55481bb3","line":50,"updated":"2016-04-27 14:51:34.000000000","message":"I\u0027m not sure if you need to specify (string value) in the documentation like this. It also goes against the format of the other documentation. It\u0027s more of a nitpick, so I wont -1 for this.","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"aefbfc4d2ecd965737e197b9becb9d9372e5c68c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#  Defaults to [\u0027pxe_ipmitool\u0027]."},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*control_exchange*]"},{"line_number":50,"context_line":"#   (optional) What RPC queue/exchange to use (string value)"},{"line_number":51,"context_line":"#   Defaults to $::os_service_default"},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*rpc_backend*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_d486dab7","line":50,"in_reply_to":"1a122d0e_55481bb3","updated":"2016-04-28 12:26:34.000000000","message":"i prefer the same logic as in https://github.com/openstack/puppet-oslo/blob/master/manifests/messaging/rabbit.pp and https://github.com/openstack/puppet-nova/blob/master/manifests/init.pp","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"0ddcaf2895fe4edab14cb1afcd498a55957d152e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#   Defaults to $::os_service_default"},{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":87,"context_line":"#   (optional) Boolean. Connect over SSL for RabbitMQ. (boolean value)"},{"line_number":88,"context_line":"#   Defaults to $::os_service_default"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*rabbit_ha_queues*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_b5eecf88","line":87,"updated":"2016-04-27 14:51:34.000000000","message":"Another nitpick is (boolean value) at the end is redundant.","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"aefbfc4d2ecd965737e197b9becb9d9372e5c68c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#   Defaults to $::os_service_default"},{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":87,"context_line":"#   (optional) Boolean. Connect over SSL for RabbitMQ. (boolean value)"},{"line_number":88,"context_line":"#   Defaults to $::os_service_default"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*rabbit_ha_queues*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_df48b32f","line":87,"in_reply_to":"1a122d0e_b5eecf88","updated":"2016-04-28 12:26:34.000000000","message":"done, but with the same logic as above","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"0ddcaf2895fe4edab14cb1afcd498a55957d152e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"#   Defaults to $::os_service_default"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*rabbit_ha_queues*]"},{"line_number":91,"context_line":"#   (optional) Use HA queues in RabbitMQ. (boolean value)"},{"line_number":92,"context_line":"#   Defaults to $::os_service_default"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*rabbit_heartbeat_timeout_threshold*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_3503df43","line":91,"updated":"2016-04-27 14:51:34.000000000","message":"Should be like above with saying Boolean instead of (boolean value) at the end.","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"aefbfc4d2ecd965737e197b9becb9d9372e5c68c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"#   Defaults to $::os_service_default"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*rabbit_ha_queues*]"},{"line_number":91,"context_line":"#   (optional) Use HA queues in RabbitMQ. (boolean value)"},{"line_number":92,"context_line":"#   Defaults to $::os_service_default"},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*rabbit_heartbeat_timeout_threshold*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_7f607fa5","line":91,"in_reply_to":"1a122d0e_3503df43","updated":"2016-04-28 12:26:34.000000000","message":"the same as above","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0e4976d809544bf2f007250a56eed5fd5bd03618","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  }"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  oslo::messaging::default {\u0027ironic_config\u0027:"},{"line_number":318,"context_line":"      control_exchange \u003d\u003e $control_exchange;"},{"line_number":319,"context_line":"  }"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"  if $rpc_backend in [$::os_service_default, \u0027ironic.openstack.common.rpc.impl_kombu\u0027, \u0027rabbit\u0027] {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_2cad4c84","line":318,"updated":"2016-04-28 00:22:56.000000000","message":"please add the rpc_response_timeout parameters, some deployments like TripleO are using it.\n\nThanks","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"aefbfc4d2ecd965737e197b9becb9d9372e5c68c","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  }"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  oslo::messaging::default {\u0027ironic_config\u0027:"},{"line_number":318,"context_line":"      control_exchange \u003d\u003e $control_exchange;"},{"line_number":319,"context_line":"  }"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"  if $rpc_backend in [$::os_service_default, \u0027ironic.openstack.common.rpc.impl_kombu\u0027, \u0027rabbit\u0027] {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a122d0e_bf5697cb","line":318,"in_reply_to":"1a122d0e_2cad4c84","updated":"2016-04-28 12:26:34.000000000","message":"Done","commit_id":"416af9c866a871656fd08c251038c8da49659db4"}],"manifests/logging.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e3f9ae4492e9b3779419244c7fbde454616b5ebf","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  $verbose_real  \u003d pick($::ironic::verbose,$verbose)"},{"line_number":119,"context_line":"  $debug_real \u003d pick($::ironic::debug,$debug)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  if is_service_default($default_log_levels) {"},{"line_number":122,"context_line":"    $default_log_levels_real \u003d $default_log_levels"},{"line_number":123,"context_line":"  } else {"},{"line_number":124,"context_line":"    $default_log_levels_real \u003d join(sort(join_keys_to_values($default_log_levels, \u0027\u003d\u0027)), \u0027,\u0027)"},{"line_number":125,"context_line":"  }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  oslo::log { \u0027ironic_config\u0027:"},{"line_number":128,"context_line":"    debug                         \u003d\u003e $debug_real,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a122d0e_c92e858b","line":125,"range":{"start_line":121,"start_character":0,"end_line":125,"end_character":3},"updated":"2016-04-26 01:19:47.000000000","message":"can be removed","commit_id":"1ec435c1c76c83716064c5dbfb857250e1174482"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"8832317e84a3d978d64e427eefcbf2a06bbf6c05","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  $verbose_real  \u003d pick($::ironic::verbose,$verbose)"},{"line_number":119,"context_line":"  $debug_real \u003d pick($::ironic::debug,$debug)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  if is_service_default($default_log_levels) {"},{"line_number":122,"context_line":"    $default_log_levels_real \u003d $default_log_levels"},{"line_number":123,"context_line":"  } else {"},{"line_number":124,"context_line":"    $default_log_levels_real \u003d join(sort(join_keys_to_values($default_log_levels, \u0027\u003d\u0027)), \u0027,\u0027)"},{"line_number":125,"context_line":"  }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  oslo::log { \u0027ironic_config\u0027:"},{"line_number":128,"context_line":"    debug                         \u003d\u003e $debug_real,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a122d0e_8c1db664","line":125,"range":{"start_line":121,"start_character":0,"end_line":125,"end_character":3},"in_reply_to":"1a122d0e_c92e858b","updated":"2016-04-26 09:09:04.000000000","message":"Done","commit_id":"1ec435c1c76c83716064c5dbfb857250e1174482"}],"releasenotes/notes/switch_to_oslo_messaging-3dabb3d90892b881.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a50eae9fc82073e9c1908b16d6ad6aba964d0922","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Use oslo module for messaging (rabbit), db and logging configuration."},{"line_number":4,"context_line":"    Messaging related parameters were switched to $::os_service_default."},{"line_number":5,"context_line":"    Docs string for parameter were updated according to oslo module."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_35275f13","line":2,"updated":"2016-04-27 14:45:31.000000000","message":"In Ironic we trying to use release note file names with \u0027-\u0027. Not sure if it is relevant here.","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"aefbfc4d2ecd965737e197b9becb9d9372e5c68c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Use oslo module for messaging (rabbit), db and logging configuration."},{"line_number":4,"context_line":"    Messaging related parameters were switched to $::os_service_default."},{"line_number":5,"context_line":"    Docs string for parameter were updated according to oslo module."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_bf0df7e9","line":2,"in_reply_to":"1a122d0e_35275f13","updated":"2016-04-28 12:26:34.000000000","message":"looks like we use \u0027_\u0027 everywhere in puppet","commit_id":"416af9c866a871656fd08c251038c8da49659db4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a745a769ed2898019c541002021b45ec3826e5da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Use oslo module for messaging (rabbit), db and logging configuration."},{"line_number":4,"context_line":"    Messaging related parameters were switched to $::os_service_default."},{"line_number":5,"context_line":"    Docs string for parameter were updated according to oslo module."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_28decadc","line":2,"in_reply_to":"1a122d0e_bf0df7e9","updated":"2016-04-28 13:02:54.000000000","message":"we do both, not sure if it\u0027s a big deal","commit_id":"416af9c866a871656fd08c251038c8da49659db4"}],"spec/classes/ironic_init_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e3f9ae4492e9b3779419244c7fbde454616b5ebf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"describe \u0027ironic\u0027 do"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  shared_examples_for \u0027ironic\u0027 do"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"      let :params do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"1a122d0e_a942293c","line":26,"updated":"2016-04-26 01:19:47.000000000","message":"no need to update this file totally, just update test cases if need","commit_id":"1ec435c1c76c83716064c5dbfb857250e1174482"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"8832317e84a3d978d64e427eefcbf2a06bbf6c05","unresolved":false,"context_lines":[{"line_number":23,"context_line":"describe \u0027ironic\u0027 do"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  shared_examples_for \u0027ironic\u0027 do"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"      let :params do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"1a122d0e_6c22daa4","line":26,"in_reply_to":"1a122d0e_a942293c","updated":"2016-04-26 09:09:04.000000000","message":"Done","commit_id":"1ec435c1c76c83716064c5dbfb857250e1174482"}]}
