)]}'
{"manifests/inspector.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d99e4e89d74a1f0aa61043832e8402dc368d778","unresolved":false,"context_lines":[{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"# [*ipxe_timeout*]"},{"line_number":150,"context_line":"#   (optional) ipxe timeout in second."},{"line_number":151,"context_line":"#   Should be an valid integer"},{"line_number":152,"context_line":"#   Defaults to \u00270\u0027 for unlimited."},{"line_number":153,"context_line":"#"},{"line_number":154,"context_line":"class ironic::inspector ("}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_7a27d662","line":151,"updated":"2016-04-28 20:18:34.000000000","message":"nit: a valid or an integer","commit_id":"9751f8cd8669045e244285bec7ff0d255d1d3517"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"a4219944c633b3a461ef216e39ac93f62021cad5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"# [*ipxe_timeout*]"},{"line_number":150,"context_line":"#   (optional) ipxe timeout in second."},{"line_number":151,"context_line":"#   Should be an valid integer"},{"line_number":152,"context_line":"#   Defaults to \u00270\u0027 for unlimited."},{"line_number":153,"context_line":"#"},{"line_number":154,"context_line":"class ironic::inspector ("}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_103323f7","line":151,"in_reply_to":"1a122d0e_7a27d662","updated":"2016-04-28 21:10:16.000000000","message":"Done","commit_id":"9751f8cd8669045e244285bec7ff0d255d1d3517"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3e2037725cdfc5ff20c5033383514dd80df5c2f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"#   Defaults to undef"},{"line_number":148,"context_line":"#"},{"line_number":149,"context_line":"# [*ipxe_timeout*]"},{"line_number":150,"context_line":"#   (optional) ipxe timeout in second. Should be an integer."},{"line_number":151,"context_line":"#   Defaults to \u00270\u0027 for unlimited."},{"line_number":152,"context_line":"#"},{"line_number":153,"context_line":"class ironic::inspector ("}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a122d0e_7cd1322f","line":150,"updated":"2016-05-03 14:05:36.000000000","message":"seconds*","commit_id":"9d56010c8cfad98e6b5cc7bc097f3c148428de68"}],"spec/classes/ironic_inspector_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c901a38c4df14ee2aa1645b736023f57ac8f51ee","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      context \u0027when ipxe_timeout is set\u0027 do"},{"line_number":202,"context_line":"        before :each do"},{"line_number":203,"context_line":"          params.merge!("},{"line_number":204,"context_line":"            :ipxe_timeout                 \u003d\u003e 30,"},{"line_number":205,"context_line":"          )"},{"line_number":206,"context_line":"        end"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a122d0e_63f5574f","line":204,"updated":"2016-04-29 19:16:41.000000000","message":"please align correctly the \u003d\u003e","commit_id":"6d105ed09f60cf104ebf4cfa4cb8728b9399e2c1"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"726bdd767f35cc0ea5076c28747c83c5fe324b55","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      context \u0027when ipxe_timeout is set\u0027 do"},{"line_number":202,"context_line":"        before :each do"},{"line_number":203,"context_line":"          params.merge!("},{"line_number":204,"context_line":"            :ipxe_timeout                 \u003d\u003e 30,"},{"line_number":205,"context_line":"          )"},{"line_number":206,"context_line":"        end"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a122d0e_f980efc1","line":204,"in_reply_to":"1a122d0e_63f5574f","updated":"2016-04-29 23:41:50.000000000","message":"I\u0027m not sure I understand what you expect. I hope it\u0027s fine now.","commit_id":"6d105ed09f60cf104ebf4cfa4cb8728b9399e2c1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c901a38c4df14ee2aa1645b736023f57ac8f51ee","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        it \u0027should contain file /httpboot/inspector.ipxe\u0027 do"},{"line_number":209,"context_line":"          is_expected.to contain_file(\u0027/httpboot/inspector.ipxe\u0027).with_content("},{"line_number":210,"context_line":"                           /kernel --timeout 30000/)"},{"line_number":211,"context_line":"        end"},{"line_number":212,"context_line":"      end"},{"line_number":213,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a122d0e_c396ebee","line":210,"updated":"2016-04-29 19:16:41.000000000","message":"same here","commit_id":"6d105ed09f60cf104ebf4cfa4cb8728b9399e2c1"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"726bdd767f35cc0ea5076c28747c83c5fe324b55","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        it \u0027should contain file /httpboot/inspector.ipxe\u0027 do"},{"line_number":209,"context_line":"          is_expected.to contain_file(\u0027/httpboot/inspector.ipxe\u0027).with_content("},{"line_number":210,"context_line":"                           /kernel --timeout 30000/)"},{"line_number":211,"context_line":"        end"},{"line_number":212,"context_line":"      end"},{"line_number":213,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a122d0e_396b8721","line":210,"in_reply_to":"1a122d0e_c396ebee","updated":"2016-04-29 23:41:50.000000000","message":"I reused the indentation of line 185 (4 spaces) since it\u0027s also a regex, i hope it\u0027s fine.","commit_id":"6d105ed09f60cf104ebf4cfa4cb8728b9399e2c1"}],"templates/inspector_ipxe.erb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b0e267a16895789f288bd56119045db9772e2e08","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":goto loop"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel --timeout 60 http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.kernel ipa-inspection-callback-url\u003dhttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:5050/v1/continue ipa-inspection-collectors\u003d\u003c%\u003d @ramdisk_collectors %\u003e systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} \u003c%\u003d @ramdisk_kernel_args %\u003e initrd\u003dagent.ramdisk || goto loop"},{"line_number":8,"context_line":"initrd --timeout 60 http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.ramdisk || goto loop"},{"line_number":9,"context_line":"boot"}],"source_content_type":"application/x-erb","patch_set":1,"id":"1a122d0e_d41d6363","line":7,"updated":"2016-04-26 19:37:40.000000000","message":"you should also update spec tests as well","commit_id":"f9d2315b9db60070c693fafb39004e8641afa39f"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"90c57d2785887b99fcf733233bfec2b9921b5d59","unresolved":false,"context_lines":[{"line_number":5,"context_line":":goto loop"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel --timeout 60 http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.kernel ipa-inspection-callback-url\u003dhttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:5050/v1/continue ipa-inspection-collectors\u003d\u003c%\u003d @ramdisk_collectors %\u003e systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} \u003c%\u003d @ramdisk_kernel_args %\u003e initrd\u003dagent.ramdisk || goto loop"},{"line_number":8,"context_line":"initrd --timeout 60 http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.ramdisk || goto loop"},{"line_number":9,"context_line":"boot"}],"source_content_type":"application/x-erb","patch_set":2,"id":"1a122d0e_cdc5bf5c","line":8,"updated":"2016-04-27 16:40:42.000000000","message":"If I\u0027m reading this right, the loop will only exit if boot succeeds - is that the intended behaviour?","commit_id":"83a80a165394d73933f0c0b8332fa3a8f48035fa"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"ec7270248758be751be521776ced36d1a0a56fe0","unresolved":false,"context_lines":[{"line_number":5,"context_line":":goto loop"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel --timeout 60 http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.kernel ipa-inspection-callback-url\u003dhttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:5050/v1/continue ipa-inspection-collectors\u003d\u003c%\u003d @ramdisk_collectors %\u003e systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} \u003c%\u003d @ramdisk_kernel_args %\u003e initrd\u003dagent.ramdisk || goto loop"},{"line_number":8,"context_line":"initrd --timeout 60 http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.ramdisk || goto loop"},{"line_number":9,"context_line":"boot"}],"source_content_type":"application/x-erb","patch_set":2,"id":"1a122d0e_aed5d9e5","line":8,"in_reply_to":"1a122d0e_cdc5bf5c","updated":"2016-04-27 19:02:59.000000000","message":"Yes, absolutely. This behavior is documented by upstream and is now ironic default too.\n\nSee: I0fbb40c711a707ae9fae186e9afbe62b79168e28","commit_id":"83a80a165394d73933f0c0b8332fa3a8f48035fa"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"f93c024c35769716abc32baa1604192b30ffcfa9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"dhcp"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"kernel http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.kernel ipa-inspection-callback-url\u003dhttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:5050/v1/continue ipa-inspection-collectors\u003d\u003c%\u003d @ramdisk_collectors %\u003e systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} \u003c%\u003d @ramdisk_kernel_args %\u003e initrd\u003dagent.ramdisk"},{"line_number":6,"context_line":"initrd http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.ramdisk"}],"source_content_type":"application/x-erb","patch_set":4,"id":"1a122d0e_80c9bc28","side":"PARENT","line":3,"updated":"2016-04-28 10:37:01.000000000","message":"Would it make sense to add a retry loop around this too?","commit_id":"76cb4f73e08fe17bf781355c87cfa87771ff9b40"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"08711b83ddf03f0d7c6046563817492b437c3f0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"dhcp"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"kernel http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.kernel ipa-inspection-callback-url\u003dhttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:5050/v1/continue ipa-inspection-collectors\u003d\u003c%\u003d @ramdisk_collectors %\u003e systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} \u003c%\u003d @ramdisk_kernel_args %\u003e initrd\u003dagent.ramdisk"},{"line_number":6,"context_line":"initrd http://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.ramdisk"}],"source_content_type":"application/x-erb","patch_set":4,"id":"1a122d0e_5e02dcb4","side":"PARENT","line":3,"in_reply_to":"1a122d0e_80c9bc28","updated":"2016-04-28 13:45:54.000000000","message":"Yes, probably. In this case we should also patch Ironic itself to be consistent. I will do some test today.","commit_id":"76cb4f73e08fe17bf781355c87cfa87771ff9b40"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d99e4e89d74a1f0aa61043832e8402dc368d778","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":":retry_boot"},{"line_number":7,"context_line":"imgfree"},{"line_number":8,"context_line":"kernel \u003c% if @ipxe_timeout \u003e 0 %\u003e--timeout \u003c%\u003d @ipxe_timeout * 1000 %\u003e \u003c% end %\u003ehttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.kernel ipa-inspection-callback-url\u003dhttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:5050/v1/continue ipa-inspection-collectors\u003d\u003c%\u003d @ramdisk_collectors %\u003e systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} \u003c%\u003d @ramdisk_kernel_args %\u003e initrd\u003dagent.ramdisk || goto loop"},{"line_number":9,"context_line":"initrd \u003c% if @ipxe_timeout \u003e 0 %\u003e--timeout \u003c%\u003d @ipxe_timeout * 1000 %\u003e \u003c% end %\u003ehttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.ramdisk || goto retry_boot"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/x-erb","patch_set":5,"id":"1a122d0e_da226a51","line":8,"updated":"2016-04-28 20:18:34.000000000","message":"s/loop/retry_boot/ ?","commit_id":"9751f8cd8669045e244285bec7ff0d255d1d3517"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"a4219944c633b3a461ef216e39ac93f62021cad5","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":":retry_boot"},{"line_number":7,"context_line":"imgfree"},{"line_number":8,"context_line":"kernel \u003c% if @ipxe_timeout \u003e 0 %\u003e--timeout \u003c%\u003d @ipxe_timeout * 1000 %\u003e \u003c% end %\u003ehttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.kernel ipa-inspection-callback-url\u003dhttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:5050/v1/continue ipa-inspection-collectors\u003d\u003c%\u003d @ramdisk_collectors %\u003e systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} \u003c%\u003d @ramdisk_kernel_args %\u003e initrd\u003dagent.ramdisk || goto loop"},{"line_number":9,"context_line":"initrd \u003c% if @ipxe_timeout \u003e 0 %\u003e--timeout \u003c%\u003d @ipxe_timeout * 1000 %\u003e \u003c% end %\u003ehttp://\u003c%\u003d @dnsmasq_local_ip %\u003e:8088/agent.ramdisk || goto retry_boot"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/x-erb","patch_set":5,"id":"1a122d0e_f02dc78f","line":8,"in_reply_to":"1a122d0e_da226a51","updated":"2016-04-28 21:10:16.000000000","message":"Done","commit_id":"9751f8cd8669045e244285bec7ff0d255d1d3517"}]}
