)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"dd3c2162ba2abe30ab6f89866c22dafcefa184d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Extend ::ironic::inspector::ipxe to fully deploy iPXE boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The xinetd setup or httpd setup of iPXE boot was previously done"},{"line_number":10,"context_line":"partially in ::ironic::inspector and partially by external tool"},{"line_number":11,"context_line":"(eg performed by instack-undercloud in TripleO)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7b3aa014fb6d2756573ded2c760cb3a11c1059f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9ad45d7e_d79a8c6d","line":10,"updated":"2016-08-10 10:49:41.000000000","message":"Nit: \"by an external tool\"","commit_id":"4e1f1f27ac682221bb5fbe720be2c3a119760560"}],"manifests/inspector.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":216,"context_line":"  $ipxe_timeout                    \u003d 0,"},{"line_number":217,"context_line":"  $http_port                       \u003d 8088,"},{"line_number":218,"context_line":"  $pxe_transfer_protocol           \u003d \u0027tftp\u0027,"},{"line_number":219,"context_line":"  $enable_uefi                     \u003d false,"},{"line_number":220,"context_line":") {"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_0eff6f35","line":218,"updated":"2016-07-27 14:35:42.000000000","message":"set it to undef. Also add a warning to signal the deprecation.","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  $ipxe_timeout                    \u003d 0,"},{"line_number":217,"context_line":"  $http_port                       \u003d 8088,"},{"line_number":218,"context_line":"  $pxe_transfer_protocol           \u003d \u0027tftp\u0027,"},{"line_number":219,"context_line":"  $enable_uefi                     \u003d false,"},{"line_number":220,"context_line":") {"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  include ::ironic::params"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_6efc2b3f","line":219,"updated":"2016-07-27 14:35:42.000000000","message":"dito","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"}],"manifests/inspector/ipxe.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    tag       \u003d\u003e \u0027ironic-inspector-dnsmasq-service\u0027,"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  package { \u0027tftpd\u0027:"},{"line_number":98,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":99,"context_line":"    name   \u003d\u003e $::ironic::params::tftpd_package,"},{"line_number":100,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-inspector-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_ae9463e8","line":97,"updated":"2016-07-27 14:35:42.000000000","message":"I would like this resource optional.","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  $options \u003d \"--map-file ${tftp_root}/map-file\""},{"line_number":112,"context_line":"  include ::xinetd"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  xinetd::service { \u0027tftp\u0027:"},{"line_number":115,"context_line":"    port        \u003d\u003e \u002769\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_8e999f22","line":112,"updated":"2016-07-27 14:35:42.000000000","message":"If you add a dependency, you need to patch metadata.json too.","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  $options \u003d \"--map-file ${tftp_root}/map-file\""},{"line_number":112,"context_line":"  include ::xinetd"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  xinetd::service { \u0027tftp\u0027:"},{"line_number":115,"context_line":"    port        \u003d\u003e \u002769\u0027,"},{"line_number":116,"context_line":"    protocol    \u003d\u003e \u0027udp\u0027,"},{"line_number":117,"context_line":"    server_args \u003d\u003e \"${options} ${tftp_root}\","}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_ee9e5b06","line":114,"updated":"2016-07-27 14:35:42.000000000","message":"I would like this resource optional.","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    require     \u003d\u003e Package[\u0027tftpd\u0027],"},{"line_number":125,"context_line":"  }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  service { \u0027tftpd-hpa\u0027:"},{"line_number":128,"context_line":"    ensure \u003d\u003e \u0027stopped\u0027,"},{"line_number":129,"context_line":"    enable \u003d\u003e false,"},{"line_number":130,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_cea3974e","line":127,"updated":"2016-07-27 14:35:42.000000000","message":"I would like this resource optional.","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      content \u003d\u003e \u0027r ^([^/]) /tftpboot/\\1\u0027,"},{"line_number":152,"context_line":"    }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    package { \u0027syslinux\u0027:"},{"line_number":155,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":156,"context_line":"      name   \u003d\u003e $::ironic::params::syslinux_package,"},{"line_number":157,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-inspector-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_2e8993cb","line":154,"updated":"2016-07-27 14:35:42.000000000","message":"this resource has nothing to do with ironic inspector, some people already declare this package and you\u0027re going to break their catalog with duplicate resource.","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"}],"manifests/inspector/tftpboot_file.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c22a0d2289324b6e0e305dc4df23a4b6c5d1bc8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2015 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_4ef9674d","line":2,"updated":"2016-07-27 14:35:42.000000000","message":"2016? same for other files...","commit_id":"8d823f7df51b4a4c9043ad65e103410e43b365f6"}]}