)]}'
{"manifests/drivers.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a67a75a1c5f814a9da2920268e44e76aa3ce5b5a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ironic::config"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class manages inclusion of driver-specific modules based on enabled"},{"line_number":4,"context_line":"# drivers."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_4f49a5cf","line":1,"updated":"2016-08-23 15:35:02.000000000","message":"ironic::drivers","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"53a763f08af11881269ce5741f3ef857085bf768","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ironic::config"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class manages inclusion of driver-specific modules based on enabled"},{"line_number":4,"context_line":"# drivers."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_d2fa6742","line":4,"updated":"2016-08-23 13:52:38.000000000","message":"do we really need this class in ironic? why not put it on orchestration layer?","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9bc326e36a92a721ac654b0c32be8388ae0abe86","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ironic::config"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class manages inclusion of driver-specific modules based on enabled"},{"line_number":4,"context_line":"# drivers."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_e8cdf431","line":4,"in_reply_to":"1ac06dbe_2838ac3c","updated":"2016-08-23 14:21:47.000000000","message":"Just for convenience, in case this list grows (it probably will)","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6737706e6708469127ed53b945fb3076dffb8dbc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ironic::config"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class manages inclusion of driver-specific modules based on enabled"},{"line_number":4,"context_line":"# drivers."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_2838ac3c","line":4,"in_reply_to":"1ac06dbe_323e5bda","updated":"2016-08-23 14:19:28.000000000","message":"Why not place body of this class directly to init.pp then?","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"00ca136c39a8d1c2b5a3431379629a07773f6b3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ironic::config"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This class manages inclusion of driver-specific modules based on enabled"},{"line_number":4,"context_line":"# drivers."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_323e5bda","line":4,"in_reply_to":"1ac06dbe_d2fa6742","updated":"2016-08-23 13:55:00.000000000","message":"I think if we manage enabled_drivers, we have to make sure that we provide packages to make such configuration possible (this is why we already install ipmitool).","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a67a75a1c5f814a9da2920268e44e76aa3ce5b5a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"class ironic::drivers ("},{"line_number":9,"context_line":") {"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  $enabled_drivers \u003d $::ironic::enabled_drivers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  if grep($enabled_drivers, \u0027ipmitool\u0027) !\u003d [] {"},{"line_number":14,"context_line":"    include ::ironic::drivers::ipmi"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_2f4429b5","line":11,"updated":"2016-08-23 15:35:02.000000000","message":"I tend to agree with Denis, the logic should probably move into init.pp, since we rely on enable_drivers.","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"53a763f08af11881269ce5741f3ef857085bf768","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  $enabled_drivers \u003d $::ironic::enabled_drivers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  if grep($enabled_drivers, \u0027ipmitool\u0027) !\u003d [] {"},{"line_number":14,"context_line":"    include ::ironic::drivers::ipmi"},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_92562f5a","line":13,"updated":"2016-08-23 13:52:38.000000000","message":"if \u0027ipmitool\u0027 in $enabled_drivers\n\nex. https://github.com/openstack/puppet-keystone/blob/master/manifests/federation/mellon.pp#L69","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9bc326e36a92a721ac654b0c32be8388ae0abe86","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  $enabled_drivers \u003d $::ironic::enabled_drivers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  if grep($enabled_drivers, \u0027ipmitool\u0027) !\u003d [] {"},{"line_number":14,"context_line":"    include ::ironic::drivers::ipmi"},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_88dd60e2","line":13,"in_reply_to":"1ac06dbe_48aec881","updated":"2016-08-23 14:21:47.000000000","message":"yes. they use the same power driver, but e.g. different deploy drivers.","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"00ca136c39a8d1c2b5a3431379629a07773f6b3b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  $enabled_drivers \u003d $::ironic::enabled_drivers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  if grep($enabled_drivers, \u0027ipmitool\u0027) !\u003d [] {"},{"line_number":14,"context_line":"    include ::ironic::drivers::ipmi"},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_92790fcb","line":13,"in_reply_to":"1ac06dbe_92562f5a","updated":"2016-08-23 13:55:00.000000000","message":"It\u0027s not called \"ipmitool\", it\u0027s called \"pxe_ipmitool\" or \"agent_ipmitool\" (there are a few more rarely used options).","commit_id":"344f88888f2105c340833db096eca55831da4883"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6737706e6708469127ed53b945fb3076dffb8dbc","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  $enabled_drivers \u003d $::ironic::enabled_drivers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  if grep($enabled_drivers, \u0027ipmitool\u0027) !\u003d [] {"},{"line_number":14,"context_line":"    include ::ironic::drivers::ipmi"},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ac06dbe_48aec881","line":13,"in_reply_to":"1ac06dbe_92790fcb","updated":"2016-08-23 14:19:28.000000000","message":"And all of them require same class and package?","commit_id":"344f88888f2105c340833db096eca55831da4883"}],"manifests/drivers/ipmi.pp":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3818eda2677bc2f0dc7a0aa628b7092a7b99be70","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \u0027ipmi/retry_timeout\u0027: value \u003d\u003e $retry_timeout;"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  ensure_packages(\u0027ipmitool\u0027,"},{"line_number":43,"context_line":"    {"},{"line_number":44,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":45,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa7ab95a_3346624f","line":42,"updated":"2016-08-30 07:38:43.000000000","message":"Please update tests according this change.","commit_id":"96e852c1b523ee402e25658896c6e7e77b421359"}],"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"967f4b7ec1fcfacd613bbeec1fa48dcb4aea8036","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    include ::ironic::drivers::ssh"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  if grep($enabled_drivers, \u0027pxe\u0027) !\u003d [] {"},{"line_number":395,"context_line":"    include ::ironic::drivers::pxe"},{"line_number":396,"context_line":"  }"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_10d50ae7","line":394,"updated":"2016-08-23 16:05:59.000000000","message":"For the driver in the commit message, both ssh and pxe get included. Is this the expected functionality? It seems kinda like magic that may not be so beneficial to operators","commit_id":"1511bf141a3221d518b16ca396fb7650040fe8c6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"217a7d26e02df27ebb0dbb95a1f38dffd83ccc32","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    include ::ironic::drivers::ssh"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  if grep($enabled_drivers, \u0027pxe\u0027) !\u003d [] {"},{"line_number":395,"context_line":"    include ::ironic::drivers::pxe"},{"line_number":396,"context_line":"  }"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_e725155c","line":394,"in_reply_to":"1ac06dbe_04c30f8a","updated":"2016-08-23 16:27:28.000000000","message":"It\u0027s not that it\u0027s not beneficial, but if some day someone create their own custom driver that is called foopxe_no_ssh and we have this magically logic it might configure something incorrectly that is not expected. IMHO, It would be safer to define the known drivers with their expected includes rather than try to infer because the name has something in it.  I\u0027m not completely against this change, i just don\u0027t like inferring things based on names. Seems to be something that could be error prone down the line.","commit_id":"1511bf141a3221d518b16ca396fb7650040fe8c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c45145be0fde4ad0bfec9e068b703eab9484c478","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    include ::ironic::drivers::ssh"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  if grep($enabled_drivers, \u0027pxe\u0027) !\u003d [] {"},{"line_number":395,"context_line":"    include ::ironic::drivers::pxe"},{"line_number":396,"context_line":"  }"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_04c30f8a","line":394,"in_reply_to":"1ac06dbe_10d50ae7","updated":"2016-08-23 16:14:06.000000000","message":"Yes, this is expected. For pxe_ssh you need both pxe and ssh, for pxe_ipmitool you need pxe and ipmitool. Could you please elaborate why it won\u0027t be beneficial to automatically detect it?","commit_id":"1511bf141a3221d518b16ca396fb7650040fe8c6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49ef27dbc1bc2b7e56100ab0e5d4463fee4eeb9e","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    include ::ironic::drivers::ssh"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  if grep($enabled_drivers, \u0027pxe\u0027) !\u003d [] {"},{"line_number":395,"context_line":"    include ::ironic::drivers::pxe"},{"line_number":396,"context_line":"  }"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_27628d0a","line":394,"in_reply_to":"1ac06dbe_877f01df","updated":"2016-08-23 16:34:57.000000000","message":"Yea that\u0027s why i\u0027m not -1 on the idea, its just a concern of mine. I prefer stronger validation rather than magic :)  For out of the tree drivers, that really should be something that\u0027s better documented on people knowing to include these driver options in puppet since they become second class citizens in puppet due to this logic.","commit_id":"1511bf141a3221d518b16ca396fb7650040fe8c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6e39ee61307cfae77c5a288a37c819385b3db744","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    include ::ironic::drivers::ssh"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  if grep($enabled_drivers, \u0027pxe\u0027) !\u003d [] {"},{"line_number":395,"context_line":"    include ::ironic::drivers::pxe"},{"line_number":396,"context_line":"  }"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1ac06dbe_877f01df","line":394,"in_reply_to":"1ac06dbe_e725155c","updated":"2016-08-23 16:31:14.000000000","message":"The problem with listing all drivers is that we have a bit too many of them to my taste :) the fix is coming: we\u0027re going to reform how we build our drivers.\n\nAlso, a bit more realistic example will be out of tree drivers actually reusing one of these common bits, which won\u0027t get covered. E.g. I\u0027m aware of out-of-tree drivers pxe_libvirt_agent, pxe_libvirt_iscsi and agent_ipmitool_nm. This logic will work well for them too, otherwise they will get excluded.","commit_id":"1511bf141a3221d518b16ca396fb7650040fe8c6"}]}
