)]}'
{"spec/classes/ironic_drivers_drac_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2eabeeef7151cc66b422c23b45ebb36df7e4f31c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":44,"context_line":"    let :facts do"},{"line_number":45,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":46,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"fa7ab95a_20d9d822","line":43,"updated":"2016-09-01 22:08:14.000000000","message":"Rather than continue this pattern, please switch to the on_suported_os(...) version. We should be using that","commit_id":"c84b4335db369e3c5db4974e5bfcb4973ef48fba"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a296d648b5b5c1111ef0bbc94a8a29e2e25c5d24","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"describe \u0027ironic::drivers::drac\u0027 do"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  let :default_params do"},{"line_number":21,"context_line":"    {}"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_c35e60e8","line":20,"updated":"2016-09-02 10:06:35.000000000","message":"it could be removed. just operate with params","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abdb7d05f883b1a528c9c0a4b921877e697ce6d4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"describe \u0027ironic::drivers::drac\u0027 do"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  let :default_params do"},{"line_number":21,"context_line":"    {}"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_23e9ccb7","line":20,"in_reply_to":"fa7ab95a_c35e60e8","updated":"2016-09-02 10:12:03.000000000","message":"Done","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a296d648b5b5c1111ef0bbc94a8a29e2e25c5d24","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      let (:facts) do"},{"line_number":48,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":49,"context_line":"          :processorcount \u003d\u003e 8,"},{"line_number":50,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":51,"context_line":"        }))"},{"line_number":52,"context_line":"      end"},{"line_number":53,"context_line":"      it_configures \u0027ironic drac driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_e387e45e","line":50,"updated":"2016-09-02 10:06:35.000000000","message":"please remove useless facts","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"53a65b0c27a81f09674b3e0d3592d0921d2624f2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      let (:facts) do"},{"line_number":48,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":49,"context_line":"          :processorcount \u003d\u003e 8,"},{"line_number":50,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":51,"context_line":"        }))"},{"line_number":52,"context_line":"      end"},{"line_number":53,"context_line":"      it_configures \u0027ironic drac driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_553127ec","line":50,"in_reply_to":"fa7ab95a_43f9707f","updated":"2016-09-02 10:16:50.000000000","message":"no, just update it as https://github.com/openstack/puppet-ironic/blob/master/spec/classes/ironic_inspector_authtoken_spec.rb#L138","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abdb7d05f883b1a528c9c0a4b921877e697ce6d4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      let (:facts) do"},{"line_number":48,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":49,"context_line":"          :processorcount \u003d\u003e 8,"},{"line_number":50,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":51,"context_line":"        }))"},{"line_number":52,"context_line":"      end"},{"line_number":53,"context_line":"      it_configures \u0027ironic drac driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_43f9707f","line":50,"in_reply_to":"fa7ab95a_e387e45e","updated":"2016-09-02 10:12:03.000000000","message":"should I remove the whole \"let\" block?","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"}],"spec/classes/ironic_drivers_ilo_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2eabeeef7151cc66b422c23b45ebb36df7e4f31c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  end"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":66,"context_line":"    let :facts do"},{"line_number":67,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":68,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"fa7ab95a_00d054f5","line":65,"updated":"2016-09-01 22:08:14.000000000","message":"same please us the on_suported_os(...) pattern instead so it leverages rspec-puppet-facts.  You can see an example in ironic_db_sync_spec.rb","commit_id":"c84b4335db369e3c5db4974e5bfcb4973ef48fba"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a296d648b5b5c1111ef0bbc94a8a29e2e25c5d24","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"describe \u0027ironic::drivers::ilo\u0027 do"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  let :default_params do"},{"line_number":21,"context_line":"    {}"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_0355a8c0","line":20,"updated":"2016-09-02 10:06:35.000000000","message":"same here","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abdb7d05f883b1a528c9c0a4b921877e697ce6d4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"describe \u0027ironic::drivers::ilo\u0027 do"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  let :default_params do"},{"line_number":21,"context_line":"    {}"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_a3ecfcbb","line":20,"in_reply_to":"fa7ab95a_0355a8c0","updated":"2016-09-02 10:12:03.000000000","message":"Done","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a296d648b5b5c1111ef0bbc94a8a29e2e25c5d24","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        params.merge!(:client_timeout               \u003d\u003e 120,"},{"line_number":51,"context_line":"                      :client_port                  \u003d\u003e 8888,"},{"line_number":52,"context_line":"                      :use_web_server_for_images    \u003d\u003e true,"},{"line_number":53,"context_line":"                      :default_boot_mode            \u003d\u003e \u0027bios\u0027)"},{"line_number":54,"context_line":"      end"},{"line_number":55,"context_line":"      it \u0027should replace default parameter with new value\u0027 do"},{"line_number":56,"context_line":"        is_expected.to contain_ironic_config(\u0027ilo/client_timeout\u0027).with_value(120)"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_c3e9001c","line":53,"updated":"2016-09-02 10:06:35.000000000","message":"fix alignment please","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ac87b0486c324bb94ac29786427c7137bcc9ce02","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        params.merge!(:client_timeout               \u003d\u003e 120,"},{"line_number":51,"context_line":"                      :client_port                  \u003d\u003e 8888,"},{"line_number":52,"context_line":"                      :use_web_server_for_images    \u003d\u003e true,"},{"line_number":53,"context_line":"                      :default_boot_mode            \u003d\u003e \u0027bios\u0027)"},{"line_number":54,"context_line":"      end"},{"line_number":55,"context_line":"      it \u0027should replace default parameter with new value\u0027 do"},{"line_number":56,"context_line":"        is_expected.to contain_ironic_config(\u0027ilo/client_timeout\u0027).with_value(120)"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_8355381f","line":53,"in_reply_to":"fa7ab95a_6324b40c","updated":"2016-09-02 10:15:05.000000000","message":":use_web_server_for_images    \u003d\u003e true,\n\nbut should be\n\n:use_web_server_for_images \u003d\u003e true,","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abdb7d05f883b1a528c9c0a4b921877e697ce6d4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        params.merge!(:client_timeout               \u003d\u003e 120,"},{"line_number":51,"context_line":"                      :client_port                  \u003d\u003e 8888,"},{"line_number":52,"context_line":"                      :use_web_server_for_images    \u003d\u003e true,"},{"line_number":53,"context_line":"                      :default_boot_mode            \u003d\u003e \u0027bios\u0027)"},{"line_number":54,"context_line":"      end"},{"line_number":55,"context_line":"      it \u0027should replace default parameter with new value\u0027 do"},{"line_number":56,"context_line":"        is_expected.to contain_ironic_config(\u0027ilo/client_timeout\u0027).with_value(120)"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_6324b40c","line":53,"in_reply_to":"fa7ab95a_c3e9001c","updated":"2016-09-02 10:12:03.000000000","message":"what is wrong with alignment here? looks correct to me..","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a296d648b5b5c1111ef0bbc94a8a29e2e25c5d24","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      let (:facts) do"},{"line_number":70,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":71,"context_line":"          :processorcount \u003d\u003e 8,"},{"line_number":72,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":73,"context_line":"        }))"},{"line_number":74,"context_line":"      end"},{"line_number":75,"context_line":"      it_configures \u0027ironic ilo driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_4397b08f","line":72,"updated":"2016-09-02 10:06:35.000000000","message":"ditto","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abdb7d05f883b1a528c9c0a4b921877e697ce6d4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      let (:facts) do"},{"line_number":70,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":71,"context_line":"          :processorcount \u003d\u003e 8,"},{"line_number":72,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":73,"context_line":"        }))"},{"line_number":74,"context_line":"      end"},{"line_number":75,"context_line":"      it_configures \u0027ironic ilo driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"fa7ab95a_831d38c0","line":72,"in_reply_to":"fa7ab95a_4397b08f","updated":"2016-09-02 10:12:03.000000000","message":"same question","commit_id":"b63e5aac27a8e280e0c90308d605348e10073159"}]}