)]}'
{"manifests/conductor.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b8bf02147f3a13d08b4861b80069f0a048b7b1be","unresolved":false,"context_lines":[{"line_number":99,"context_line":") {"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  include ::ironic::params"},{"line_number":102,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_8074c09c","line":102,"updated":"2016-08-26 14:27:34.000000000","message":"fyi: if this manifest will be called after main class we will have duplicated declaration, so backward compatibility will be broken anyway :D","commit_id":"e782084100cb31046219924a09a0a0a9cf1cad1f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bc783b9e97d5e55102960eabacabbb3d8956cbfe","unresolved":false,"context_lines":[{"line_number":99,"context_line":") {"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  include ::ironic::params"},{"line_number":102,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_c725f7ab","line":102,"in_reply_to":"fa7ab95a_2c304a01","updated":"2016-08-26 16:09:11.000000000","message":"+1, I like the staged approach","commit_id":"e782084100cb31046219924a09a0a0a9cf1cad1f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ed913f0a30d86556a5e55e6319a9368dbed8353","unresolved":false,"context_lines":[{"line_number":99,"context_line":") {"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  include ::ironic::params"},{"line_number":102,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_9b9a7513","line":102,"in_reply_to":"fa7ab95a_8005a0c3","updated":"2016-08-26 14:44:43.000000000","message":"Probably we can just revert including deploy class here and reflect it in release note, that this change is not backward compatible. But let\u0027s wait for other guys :) may be someone have another opinion.","commit_id":"e782084100cb31046219924a09a0a0a9cf1cad1f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fd95526ec47ecc03c22aa97794f83255702c52cc","unresolved":false,"context_lines":[{"line_number":99,"context_line":") {"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  include ::ironic::params"},{"line_number":102,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_8005a0c3","line":102,"in_reply_to":"fa7ab95a_8074c09c","updated":"2016-08-26 14:29:25.000000000","message":"Hmm, do you think we should reverse the includes, e.g. ironic::drivers::deploy should include ironic::conductor? I can never do it right :)","commit_id":"e782084100cb31046219924a09a0a0a9cf1cad1f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"68812e96b4c5d1a50f01045a6b399afb2f90d6ff","unresolved":false,"context_lines":[{"line_number":99,"context_line":") {"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  include ::ironic::params"},{"line_number":102,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_d3030172","line":102,"in_reply_to":"fa7ab95a_9b9a7513","updated":"2016-08-26 15:13:43.000000000","message":"Denis, it will break TripleO CI, as it relies on the ability to override http_url...","commit_id":"e782084100cb31046219924a09a0a0a9cf1cad1f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1d8218a91cea3d12b60883b53590ad6ac87e2fb8","unresolved":false,"context_lines":[{"line_number":99,"context_line":") {"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  include ::ironic::params"},{"line_number":102,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa7ab95a_2c304a01","line":102,"in_reply_to":"fa7ab95a_d3030172","updated":"2016-08-26 16:07:41.000000000","message":"Ah, got it. But you can merge this patch first, then update TripleO and update this class again :)\n\nIt\u0027s my own opinion, i won\u0027t block this patch, so just +1 :)","commit_id":"e782084100cb31046219924a09a0a0a9cf1cad1f"}]}