)]}'
{"manifests/drivers/agent.pp":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1d1ca85884b37339ab67645cce454df65e3be9aa","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   Accepts values \"local\" and \"swift\"."},{"line_number":40,"context_line":"#   Defaults to $::os_service_default"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*deploy_logs_local_path*]"},{"line_number":43,"context_line":"#   (optional) The path to store IPA logs if deploy_logs_storage_backend is"},{"line_number":44,"context_line":"#   \"local\" (ignored otherwise)."},{"line_number":45,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_4b9186f0","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":26},"updated":"2016-08-29 20:25:20.000000000","message":"We need to ensure that this patch exists and is a directory with rw rights for Ironic user, but possibly may be added in next patch.","commit_id":"ed5613b6419fd6d5c804d4fec44ac353a20051df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1d1ca85884b37339ab67645cce454df65e3be9aa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $deploy_logs_storage_backend                  \u003d $::os_service_default,"},{"line_number":63,"context_line":"  $deploy_logs_local_path                       \u003d $::os_service_default,"},{"line_number":64,"context_line":"  $deploy_logs_swift_container                  \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $deploy_logs_swift_days_to_expire             \u003d $::os_service_default,"},{"line_number":66,"context_line":") {"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa7ab95a_8b646e22","line":65,"updated":"2016-08-29 20:25:20.000000000","message":"few options are missed, but I think they may be added once someone really needs them.","commit_id":"ed5613b6419fd6d5c804d4fec44ac353a20051df"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2028ed6261cafd14a33e661d168577a60d0a0cfd","unresolved":false,"context_lines":[{"line_number":66,"context_line":") {"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  # Configure ironic.conf"},{"line_number":69,"context_line":"  ironic_config {"},{"line_number":70,"context_line":"    \u0027agent/stream_raw_images\u0027: value \u003d\u003e $stream_raw_images;"},{"line_number":71,"context_line":"    \u0027agent/post_deploy_get_power_state_retries\u0027: value \u003d\u003e $post_deploy_get_power_state_retries;"},{"line_number":72,"context_line":"    \u0027agent/post_deploy_get_power_state_retry_interval\u0027: value \u003d\u003e $post_deploy_get_power_state_retry_interval;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa7ab95a_8031c45c","line":69,"updated":"2016-09-01 22:09:40.000000000","message":"Can you fix the alignment of these?","commit_id":"8b60bce735d5e86f66b10e946cd7f80954c0ab82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c1b0db05b09dabf7f507b0589fa35b4c6ec4d74","unresolved":false,"context_lines":[{"line_number":66,"context_line":") {"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  # Configure ironic.conf"},{"line_number":69,"context_line":"  ironic_config {"},{"line_number":70,"context_line":"    \u0027agent/stream_raw_images\u0027: value \u003d\u003e $stream_raw_images;"},{"line_number":71,"context_line":"    \u0027agent/post_deploy_get_power_state_retries\u0027: value \u003d\u003e $post_deploy_get_power_state_retries;"},{"line_number":72,"context_line":"    \u0027agent/post_deploy_get_power_state_retry_interval\u0027: value \u003d\u003e $post_deploy_get_power_state_retry_interval;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa7ab95a_97ebbadb","line":69,"in_reply_to":"fa7ab95a_8031c45c","updated":"2016-09-02 09:09:39.000000000","message":"We don\u0027t have a consistent alignment in puppet-ironic, but will fix.","commit_id":"8b60bce735d5e86f66b10e946cd7f80954c0ab82"}],"spec/classes/ironic_drivers_agent_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2028ed6261cafd14a33e661d168577a60d0a0cfd","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":70,"context_line":"    let :facts do"},{"line_number":71,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":72,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa7ab95a_a032485c","line":69,"updated":"2016-09-01 22:09:40.000000000","message":"please use on_suported_os(...)","commit_id":"8b60bce735d5e86f66b10e946cd7f80954c0ab82"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d39d2ab5abcdea6fe8511930335f6e8cd59dac1e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"describe \u0027ironic::drivers::agent\u0027 do"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  let :default_params do"},{"line_number":21,"context_line":"    {}"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa7ab95a_c3ee608a","line":20,"updated":"2016-09-02 10:14:06.000000000","message":"could be removed","commit_id":"108e2d677065b4ba7b527c21e95612507e4918d7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d39d2ab5abcdea6fe8511930335f6e8cd59dac1e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  shared_examples_for \u0027ironic agent driver\u0027 do"},{"line_number":29,"context_line":"    let :p do"},{"line_number":30,"context_line":"      default_params.merge(params)"},{"line_number":31,"context_line":"    end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    it \u0027configures ironic.conf\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa7ab95a_03e5a8a2","line":30,"updated":"2016-09-02 10:14:06.000000000","message":"let :p do\n  params\nend","commit_id":"108e2d677065b4ba7b527c21e95612507e4918d7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d39d2ab5abcdea6fe8511930335f6e8cd59dac1e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      let (:facts) do"},{"line_number":74,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":75,"context_line":"          :processorcount \u003d\u003e 8,"},{"line_number":76,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":77,"context_line":"        }))"},{"line_number":78,"context_line":"      end"},{"line_number":79,"context_line":"      it_configures \u0027ironic agent driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa7ab95a_43033042","line":76,"updated":"2016-09-02 10:14:06.000000000","message":"useless facts","commit_id":"108e2d677065b4ba7b527c21e95612507e4918d7"}]}
