)]}'
{"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f0591762ed70be403b7e904c938ea24aec6ec424","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  $public_endpoint   \u003d $::os_service_default,"},{"line_number":107,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":108,"context_line":"  $identity_uri      \u003d undef,"},{"line_number":109,"context_line":"  $admin_tenant_name \u003d undef,"},{"line_number":110,"context_line":"  $admin_user        \u003d undef,"},{"line_number":111,"context_line":"  $admin_password    \u003d undef,"},{"line_number":112,"context_line":"  $auth_uri          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a89bdaa_b507ab16","side":"PARENT","line":109,"updated":"2016-09-13 16:47:29.000000000","message":"why did these get un deprecated? bad rebase?","commit_id":"66817defef97b7859001fe6b919e1d424b2bbf97"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"61079e7747c66b8075989a6cd1feec6b498bcc4e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  $public_endpoint   \u003d $::os_service_default,"},{"line_number":107,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":108,"context_line":"  $identity_uri      \u003d undef,"},{"line_number":109,"context_line":"  $admin_tenant_name \u003d undef,"},{"line_number":110,"context_line":"  $admin_user        \u003d undef,"},{"line_number":111,"context_line":"  $admin_password    \u003d undef,"},{"line_number":112,"context_line":"  $auth_uri          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_5e76553f","side":"PARENT","line":109,"in_reply_to":"9a89bdaa_b507ab16","updated":"2016-09-13 17:19:37.000000000","message":"Bad! It was a bad rebase.\nI posted the review from my test cluster and messed up the rebase on this file in the process.  fixing now.","commit_id":"66817defef97b7859001fe6b919e1d424b2bbf97"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  include ::ironic::api::authtoken"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[$service_name]"},{"line_number":147,"context_line":"  Class[\u0027ironic::policy\u0027] ~\u003e Service[$service_name]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  # Configure ironic.conf"},{"line_number":150,"context_line":"  ironic_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_b06e6bc7","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":51},"updated":"2016-09-14 15:02:45.000000000","message":"should be also covered by deps i think","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  include ::ironic::api::authtoken"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[$service_name]"},{"line_number":147,"context_line":"  Class[\u0027ironic::policy\u0027] ~\u003e Service[$service_name]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  # Configure ironic.conf"},{"line_number":150,"context_line":"  ironic_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_4bb80de6","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":51},"in_reply_to":"7a8ec9b2_b06e6bc7","updated":"2016-09-14 18:38:59.000000000","message":"It is covered, removing these lines.\n\ndeps has Ironic_config Notifying ironic services.  Changes to the ironic.conf file would restart ironic services.  The ironic policy class contains the ironic_config tag on its resources, so that ordering is also covered in deps.","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  # Install package"},{"line_number":160,"context_line":"  if $::ironic::params::api_package {"},{"line_number":161,"context_line":"    Package[\u0027ironic-api\u0027] -\u003e Class[\u0027ironic::policy\u0027]"},{"line_number":162,"context_line":"    Package[\u0027ironic-api\u0027] -\u003e Service[$service_name]"},{"line_number":163,"context_line":"    package { \u0027ironic-api\u0027:"},{"line_number":164,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":165,"context_line":"      name   \u003d\u003e $::ironic::params::api_package,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_10663fed","line":162,"range":{"start_line":161,"start_character":0,"end_line":162,"end_character":51},"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  # Install package"},{"line_number":160,"context_line":"  if $::ironic::params::api_package {"},{"line_number":161,"context_line":"    Package[\u0027ironic-api\u0027] -\u003e Class[\u0027ironic::policy\u0027]"},{"line_number":162,"context_line":"    Package[\u0027ironic-api\u0027] -\u003e Service[$service_name]"},{"line_number":163,"context_line":"    package { \u0027ironic-api\u0027:"},{"line_number":164,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":165,"context_line":"      name   \u003d\u003e $::ironic::params::api_package,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_0b67e525","line":162,"range":{"start_line":161,"start_character":0,"end_line":162,"end_character":51},"in_reply_to":"7a8ec9b2_10663fed","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/client.pp":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"6a5ed2140a9156370b353451af1dfe0d274368d3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  package { \u0027python-ironicclient\u0027:"},{"line_number":37,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":38,"context_line":"    name   \u003d\u003e $::ironic::params::client_package,"},{"line_number":39,"context_line":"    tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_98b6dfda","line":39,"updated":"2016-09-14 22:00:14.000000000","message":"you may also need ironic-support-package here, dont remove openstack though it will cause issues with virtual packages on RH*","commit_id":"0ef8271c2d4ed929eda5fdc888b3dfb7f5529d0d"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"7f1cf4696c62fbf6f934bd6742c22f6793972732","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  package { \u0027python-ironicclient\u0027:"},{"line_number":37,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":38,"context_line":"    name   \u003d\u003e $::ironic::params::client_package,"},{"line_number":39,"context_line":"    tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_f35d447a","line":39,"in_reply_to":"7a8ec9b2_98b6dfda","updated":"2016-09-14 22:33:05.000000000","message":"Done","commit_id":"0ef8271c2d4ed929eda5fdc888b3dfb7f5529d0d"}],"manifests/conductor.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  include ::ironic::params"},{"line_number":132,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  $enabled_drivers_real \u003d pick($::ironic::enabled_drivers, $enabled_drivers)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_d0aa17d4","line":134,"updated":"2016-09-14 15:02:45.000000000","message":"move to deps","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  include ::ironic::params"},{"line_number":132,"context_line":"  include ::ironic::drivers::deploy"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  Ironic_config\u003c||\u003e ~\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  $enabled_drivers_real \u003d pick($::ironic::enabled_drivers, $enabled_drivers)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_cb541d23","line":134,"in_reply_to":"7a8ec9b2_d0aa17d4","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  # Install package"},{"line_number":203,"context_line":"  if $::ironic::params::conductor_package {"},{"line_number":204,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ironic-package\u0027 |\u003e -\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":205,"context_line":"    package { \u0027ironic-conductor\u0027:"},{"line_number":206,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":207,"context_line":"      name   \u003d\u003e $::ironic::params::conductor_package,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_10ad5fe9","line":204,"updated":"2016-09-14 15:02:45.000000000","message":"move to deps","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  # Install package"},{"line_number":203,"context_line":"  if $::ironic::params::conductor_package {"},{"line_number":204,"context_line":"    Package\u003c| tag \u003d\u003d \u0027ironic-package\u0027 |\u003e -\u003e Service[\u0027ironic-conductor\u0027]"},{"line_number":205,"context_line":"    package { \u0027ironic-conductor\u0027:"},{"line_number":206,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":207,"context_line":"      name   \u003d\u003e $::ironic::params::conductor_package,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_6b0dc93d","line":204,"in_reply_to":"7a8ec9b2_10ad5fe9","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/cors.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2f951dc802dfaa3e3e502b257dab4b2b49d0899c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#   (Optional) Indicate which headers are safe to expose to the API."},{"line_number":20,"context_line":"#   (list value)"},{"line_number":21,"context_line":"#   Defaults to $::os_service_default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*max_age*]"},{"line_number":25,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_370186af","line":22,"updated":"2016-09-14 10:30:47.000000000","message":"Sneaky spaces.  Should remove this","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"51bd7bf9e13941e4f24ecfeb48de00a8ba846960","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#   (Optional) Indicate which headers are safe to expose to the API."},{"line_number":20,"context_line":"#   (list value)"},{"line_number":21,"context_line":"#   Defaults to $::os_service_default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*max_age*]"},{"line_number":25,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_57bc526c","line":22,"updated":"2016-09-14 10:36:40.000000000","message":"was it added here? I can\u0027t see it in Gertty","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#   (Optional) Indicate which headers are safe to expose to the API."},{"line_number":20,"context_line":"#   (list value)"},{"line_number":21,"context_line":"#   Defaults to $::os_service_default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*max_age*]"},{"line_number":25,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_1d2acc7e","line":22,"in_reply_to":"7a8ec9b2_370186af","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#   (Optional) Indicate which headers are safe to expose to the API."},{"line_number":20,"context_line":"#   (list value)"},{"line_number":21,"context_line":"#   Defaults to $::os_service_default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*max_age*]"},{"line_number":25,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_3d2148a0","line":22,"in_reply_to":"7a8ec9b2_57bc526c","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"af2159c9f507c4d9cb597d54d758e33c4339b35b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#   (Optional) Indicate which headers are safe to expose to the API."},{"line_number":20,"context_line":"#   (list value)"},{"line_number":21,"context_line":"#   Defaults to $::os_service_default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*max_age*]"},{"line_number":25,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_e9582259","line":22,"in_reply_to":"7a8ec9b2_57bc526c","updated":"2016-09-14 10:53:38.000000000","message":"Yea there\u0027s an added blank line here. Unfortunately gertty doesn\u0027t show whitespace like the web ui :/","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#   (Optional) Indicate which headers are safe to expose to the API."},{"line_number":20,"context_line":"#   (list value)"},{"line_number":21,"context_line":"#   Defaults to $::os_service_default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*max_age*]"},{"line_number":25,"context_line":"#   (Optional) Maximum cache age of CORS preflight requests."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_5d2454ae","line":22,"in_reply_to":"7a8ec9b2_e9582259","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/db/inspector_sync.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  include ::ironic::deps"},{"line_number":7,"context_line":"  include ::ironic::params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Package\u003c| tag \u003d\u003d \u0027ironic-inspector-package\u0027 |\u003e ~\u003e Exec[\u0027ironic-inspector-dbsync\u0027]"},{"line_number":10,"context_line":"  Exec[\u0027ironic-inspector-dbsync\u0027] ~\u003e Service \u003c| tag \u003d\u003d \u0027ironic-inspector-service\u0027 |\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  Ironic_inspector_config\u003c||\u003e -\u003e Exec[\u0027ironic-inspector-dbsync\u0027]"},{"line_number":13,"context_line":"  Ironic_inspector_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027ironic-inspector-dbsync\u0027]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  exec { \u0027ironic-inspector-dbsync\u0027:"},{"line_number":16,"context_line":"    command     \u003d\u003e $::ironic::params::inspector_dbsync_command,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_508e0779","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":96},"updated":"2016-09-14 15:02:45.000000000","message":"also can be moved to deps with using anchors","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  include ::ironic::deps"},{"line_number":7,"context_line":"  include ::ironic::params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Package\u003c| tag \u003d\u003d \u0027ironic-inspector-package\u0027 |\u003e ~\u003e Exec[\u0027ironic-inspector-dbsync\u0027]"},{"line_number":10,"context_line":"  Exec[\u0027ironic-inspector-dbsync\u0027] ~\u003e Service \u003c| tag \u003d\u003d \u0027ironic-inspector-service\u0027 |\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  Ironic_inspector_config\u003c||\u003e -\u003e Exec[\u0027ironic-inspector-dbsync\u0027]"},{"line_number":13,"context_line":"  Ironic_inspector_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027ironic-inspector-dbsync\u0027]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  exec { \u0027ironic-inspector-dbsync\u0027:"},{"line_number":16,"context_line":"    command     \u003d\u003e $::ironic::params::inspector_dbsync_command,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_1d300c9e","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":96},"in_reply_to":"7a8ec9b2_508e0779","updated":"2016-09-14 18:38:59.000000000","message":"Lines 30-41 of deps cover these cases.  Removing here.","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/deps.pp":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"6a5ed2140a9156370b353451af1dfe0d274368d3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  # ironic-package should be whether or not ironic services would need to be"},{"line_number":57,"context_line":"  # restarted if the package state was changed."},{"line_number":58,"context_line":"  Anchor[\u0027ironic::install::begin\u0027]"},{"line_number":59,"context_line":"  -\u003e Package\u003c| tag \u003d\u003d \u0027ironic-support-package\u0027|\u003e"},{"line_number":60,"context_line":"  -\u003e Anchor[\u0027ironic::install::end\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  # Installation or config changes will always restart services."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_18f9ef80","line":59,"updated":"2016-09-14 22:00:14.000000000","message":"what about relationships between suppport packages and inspector do any of those exist?","commit_id":"0ef8271c2d4ed929eda5fdc888b3dfb7f5529d0d"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"7f1cf4696c62fbf6f934bd6742c22f6793972732","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  # ironic-package should be whether or not ironic services would need to be"},{"line_number":57,"context_line":"  # restarted if the package state was changed."},{"line_number":58,"context_line":"  Anchor[\u0027ironic::install::begin\u0027]"},{"line_number":59,"context_line":"  -\u003e Package\u003c| tag \u003d\u003d \u0027ironic-support-package\u0027|\u003e"},{"line_number":60,"context_line":"  -\u003e Anchor[\u0027ironic::install::end\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  # Installation or config changes will always restart services."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_33c08c7c","line":59,"in_reply_to":"7a8ec9b2_18f9ef80","updated":"2016-09-14 22:33:05.000000000","message":"Good catch, they do.  Packages in https://review.openstack.org/#/c/369566/4/manifests/pxe.pp\n\nI\u0027ll add a section for ironic-inspector so it can operate independently of ironic core.","commit_id":"0ef8271c2d4ed929eda5fdc888b3dfb7f5529d0d"}],"manifests/drivers/ssh.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2f951dc802dfaa3e3e502b257dab4b2b49d0899c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class ironic::drivers::ssh ("},{"line_number":26,"context_line":"  $libvirt_uri \u003d $::os_service_default,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  "},{"line_number":29,"context_line":"  include ::ironic::deps"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_f7e47e0e","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":2},"updated":"2016-09-14 10:30:47.000000000","message":"Looks like there\u0027s some extra whitespace here as well","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class ironic::drivers::ssh ("},{"line_number":26,"context_line":"  $libvirt_uri \u003d $::os_service_default,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  "},{"line_number":29,"context_line":"  include ::ironic::deps"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_ddc4e460","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":2},"in_reply_to":"7a8ec9b2_f7e47e0e","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    name   \u003d\u003e $::ironic::params::common_package_name,"},{"line_number":382,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],"},{"line_number":383,"context_line":"  }"},{"line_number":384,"context_line":"  Package[\u0027ironic-common\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027ironic-service\u0027 |\u003e"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  package { \u0027ironic-lib\u0027:"},{"line_number":387,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_70d06354","line":384,"range":{"start_line":384,"start_character":0,"end_line":384,"end_character":66},"updated":"2016-09-14 15:02:45.000000000","message":"should be covered by deps","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    name   \u003d\u003e $::ironic::params::common_package_name,"},{"line_number":382,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],"},{"line_number":383,"context_line":"  }"},{"line_number":384,"context_line":"  Package[\u0027ironic-common\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027ironic-service\u0027 |\u003e"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  package { \u0027ironic-lib\u0027:"},{"line_number":387,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_3d830806","line":384,"range":{"start_line":384,"start_character":0,"end_line":384,"end_character":66},"in_reply_to":"7a8ec9b2_70d06354","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    name   \u003d\u003e $::ironic::params::lib_package_name,"},{"line_number":389,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],"},{"line_number":390,"context_line":"  }"},{"line_number":391,"context_line":"  Package[\u0027ironic-lib\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027ironic-service\u0027 |\u003e"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"  resources { \u0027ironic_config\u0027:"},{"line_number":394,"context_line":"    purge \u003d\u003e $purge_config,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_d0cf77ae","line":391,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    name   \u003d\u003e $::ironic::params::lib_package_name,"},{"line_number":389,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],"},{"line_number":390,"context_line":"  }"},{"line_number":391,"context_line":"  Package[\u0027ironic-lib\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027ironic-service\u0027 |\u003e"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"  resources { \u0027ironic_config\u0027:"},{"line_number":394,"context_line":"    purge \u003d\u003e $purge_config,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_9d789c2d","line":391,"in_reply_to":"7a8ec9b2_d0cf77ae","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/inspector.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"79cef8df704eed9271432ec665d5907b96ca634d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"#"},{"line_number":184,"context_line":"class ironic::inspector ("},{"line_number":185,"context_line":"  $package_ensure                  \u003d \u0027present\u0027,"},{"line_number":186,"context_line":"  $write_config                    \u003d true,"},{"line_number":187,"context_line":"  $enabled                         \u003d true,"},{"line_number":188,"context_line":"  $listen_address                  \u003d $::os_service_default,"},{"line_number":189,"context_line":"  $pxe_transfer_protocol           \u003d \u0027tftp\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a8ec9b2_f993b04d","line":186,"updated":"2016-09-13 21:54:34.000000000","message":"looks like this is another one that snuck in somewhere. I assume this should also be removed","commit_id":"f86a46a27a747756c18d529613f8fb21406ac244"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0add2f1ac9ba526d041769ca2a17519f9790d455","unresolved":false,"context_lines":[{"line_number":183,"context_line":"#"},{"line_number":184,"context_line":"class ironic::inspector ("},{"line_number":185,"context_line":"  $package_ensure                  \u003d \u0027present\u0027,"},{"line_number":186,"context_line":"  $write_config                    \u003d true,"},{"line_number":187,"context_line":"  $enabled                         \u003d true,"},{"line_number":188,"context_line":"  $listen_address                  \u003d $::os_service_default,"},{"line_number":189,"context_line":"  $pxe_transfer_protocol           \u003d \u0027tftp\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a8ec9b2_4c5dbde8","line":186,"in_reply_to":"7a8ec9b2_f993b04d","updated":"2016-09-14 00:13:41.000000000","message":"Removed this and added deps to agent and pxe class. Both tested now.","commit_id":"f86a46a27a747756c18d529613f8fb21406ac244"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  $http_port_real \u003d pick($::ironic::pxe::common::http_port, $http_port)"},{"line_number":263,"context_line":"  $ipxe_timeout_real     \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  Ironic_inspector_config\u003c||\u003e ~\u003e Service[\u0027ironic-inspector\u0027]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  file { \u0027/etc/ironic-inspector/inspector.conf\u0027:"},{"line_number":268,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_f072b37b","line":265,"updated":"2016-09-14 15:02:45.000000000","message":"move to deps","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  $http_port_real \u003d pick($::ironic::pxe::common::http_port, $http_port)"},{"line_number":263,"context_line":"  $ipxe_timeout_real     \u003d pick($::ironic::pxe::common::ipxe_timeout, $ipxe_timeout)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  Ironic_inspector_config\u003c||\u003e ~\u003e Service[\u0027ironic-inspector\u0027]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  file { \u0027/etc/ironic-inspector/inspector.conf\u0027:"},{"line_number":268,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_537283ae","line":265,"in_reply_to":"7a8ec9b2_f072b37b","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    file { \u0027/etc/ironic-inspector/dnsmasq.conf\u0027:"},{"line_number":274,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":275,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_dnsmasq_tftp.erb\u0027),"},{"line_number":276,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":277,"context_line":"    }"},{"line_number":278,"context_line":"    file { \"${tftp_root_real}/pxelinux.cfg\":"},{"line_number":279,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_506a8781","line":276,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    file { \u0027/etc/ironic-inspector/dnsmasq.conf\u0027:"},{"line_number":274,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":275,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_dnsmasq_tftp.erb\u0027),"},{"line_number":276,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":277,"context_line":"    }"},{"line_number":278,"context_line":"    file { \"${tftp_root_real}/pxelinux.cfg\":"},{"line_number":279,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_336fb7c6","line":276,"in_reply_to":"7a8ec9b2_506a8781","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    file { \"${tftp_root_real}/pxelinux.cfg/default\":"},{"line_number":282,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":283,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_pxelinux_cfg.erb\u0027),"},{"line_number":284,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":285,"context_line":"    }"},{"line_number":286,"context_line":"  }"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_d014d7f6","line":284,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    file { \"${tftp_root_real}/pxelinux.cfg/default\":"},{"line_number":282,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":283,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_pxelinux_cfg.erb\u0027),"},{"line_number":284,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":285,"context_line":"    }"},{"line_number":286,"context_line":"  }"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_f3746f9d","line":284,"in_reply_to":"7a8ec9b2_d014d7f6","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    file { \u0027/etc/ironic-inspector/dnsmasq.conf\u0027:"},{"line_number":290,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":291,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_dnsmasq_http.erb\u0027),"},{"line_number":292,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":"    file { \"${http_root_real}/inspector.ipxe\":"},{"line_number":295,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_90316fa5","line":292,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    file { \u0027/etc/ironic-inspector/dnsmasq.conf\u0027:"},{"line_number":290,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":291,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_dnsmasq_http.erb\u0027),"},{"line_number":292,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":"    file { \"${http_root_real}/inspector.ipxe\":"},{"line_number":295,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_b34ca771","line":292,"in_reply_to":"7a8ec9b2_90316fa5","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    file { \"${http_root_real}/inspector.ipxe\":"},{"line_number":295,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":296,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_ipxe.erb\u0027),"},{"line_number":297,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":298,"context_line":"    }"},{"line_number":299,"context_line":"  }"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_5018c71d","line":297,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    file { \"${http_root_real}/inspector.ipxe\":"},{"line_number":295,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":296,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_ipxe.erb\u0027),"},{"line_number":297,"context_line":"      require \u003d\u003e Package[\u0027ironic-inspector\u0027],"},{"line_number":298,"context_line":"    }"},{"line_number":299,"context_line":"  }"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_73421f40","line":297,"in_reply_to":"7a8ec9b2_5018c71d","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  # Install package"},{"line_number":330,"context_line":"  if $::ironic::params::inspector_package {"},{"line_number":331,"context_line":"    Package[\u0027ironic-inspector\u0027] -\u003e Service[\u0027ironic-inspector\u0027]"},{"line_number":332,"context_line":"    Package[\u0027ironic-inspector\u0027] -\u003e Service[\u0027ironic-inspector-dnsmasq\u0027]"},{"line_number":333,"context_line":"    package { \u0027ironic-inspector\u0027:"},{"line_number":334,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":335,"context_line":"      name   \u003d\u003e $::ironic::params::inspector_package,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_10e55f08","line":332,"range":{"start_line":331,"start_character":0,"end_line":332,"end_character":70},"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  # Install package"},{"line_number":330,"context_line":"  if $::ironic::params::inspector_package {"},{"line_number":331,"context_line":"    Package[\u0027ironic-inspector\u0027] -\u003e Service[\u0027ironic-inspector\u0027]"},{"line_number":332,"context_line":"    Package[\u0027ironic-inspector\u0027] -\u003e Service[\u0027ironic-inspector-dnsmasq\u0027]"},{"line_number":333,"context_line":"    package { \u0027ironic-inspector\u0027:"},{"line_number":334,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":335,"context_line":"      name   \u003d\u003e $::ironic::params::inspector_package,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_00009f00","line":332,"range":{"start_line":331,"start_character":0,"end_line":332,"end_character":70},"in_reply_to":"7a8ec9b2_10e55f08","updated":"2016-09-14 18:38:59.000000000","message":"got it. covered by deps with:\n\n  ~\u003e anchor { \u0027ironic-inspector::service::begin\u0027: }\n  ~\u003e Service\u003c| tag \u003d\u003d \u0027ironic-inspector-service\u0027 |\u003e\n  ~\u003e Service\u003c| tag \u003d\u003d \u0027ironic-inspector-dnsmasq-service\u0027 |\u003e\n  ~\u003e anchor { \u0027ironic-inspector::service::end\u0027: }\n\nOrdering AND config notification of dnsmasq.","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/inspector/logging.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2f951dc802dfaa3e3e502b257dab4b2b49d0899c","unresolved":false,"context_lines":[{"line_number":113,"context_line":") {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::ironic::deps"},{"line_number":116,"context_line":"    "},{"line_number":117,"context_line":"  $debug_real \u003d pick($::ironic::inspector::debug,$debug)"},{"line_number":118,"context_line":"  if is_service_default($default_log_levels) {"},{"line_number":119,"context_line":"    $default_log_levels_real \u003d $default_log_levels"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_57a1b2a8","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":4},"updated":"2016-09-14 10:30:47.000000000","message":"More whitespace","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":113,"context_line":") {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::ironic::deps"},{"line_number":116,"context_line":"    "},{"line_number":117,"context_line":"  $debug_real \u003d pick($::ironic::inspector::debug,$debug)"},{"line_number":118,"context_line":"  if is_service_default($default_log_levels) {"},{"line_number":119,"context_line":"    $default_log_levels_real \u003d $default_log_levels"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_b304a7c0","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":4},"in_reply_to":"7a8ec9b2_57a1b2a8","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}],"manifests/pxe.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":64,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":65,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"},{"line_number":66,"context_line":"    require \u003d\u003e Package[\u0027ironic-common\u0027],"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  file { $http_root_real:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_107abf24","line":66,"updated":"2016-09-14 15:02:45.000000000","message":"should be covered by deps","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":64,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":65,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"},{"line_number":66,"context_line":"    require \u003d\u003e Package[\u0027ironic-common\u0027],"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  file { $http_root_real:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_f3a1cfaa","line":66,"in_reply_to":"7a8ec9b2_107abf24","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    seltype \u003d\u003e \u0027httpd_sys_content_t\u0027,"},{"line_number":72,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":73,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"},{"line_number":74,"context_line":"    require \u003d\u003e Package[\u0027ironic-common\u0027],"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  ensure_resource( \u0027package\u0027, \u0027tftp-server\u0027, {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_3077bb3b","line":74,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    seltype \u003d\u003e \u0027httpd_sys_content_t\u0027,"},{"line_number":72,"context_line":"    owner   \u003d\u003e \u0027ironic\u0027,"},{"line_number":73,"context_line":"    group   \u003d\u003e \u0027ironic\u0027,"},{"line_number":74,"context_line":"    require \u003d\u003e Package[\u0027ironic-common\u0027],"},{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  ensure_resource( \u0027package\u0027, \u0027tftp-server\u0027, {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_13a55bb4","line":74,"in_reply_to":"7a8ec9b2_3077bb3b","updated":"2016-09-14 18:38:59.000000000","message":"Done","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    flags       \u003d\u003e \u0027IPv4\u0027,"},{"line_number":94,"context_line":"    per_source  \u003d\u003e \u002711\u0027,"},{"line_number":95,"context_line":"    wait        \u003d\u003e \u0027yes\u0027,"},{"line_number":96,"context_line":"    require     \u003d\u003e Package[\u0027tftp-server\u0027],"},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  service { \u0027tftpd-hpa\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_50744734","line":96,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0f88a5679f7448f5f2e15f891de7214e69bdccae","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    flags       \u003d\u003e \u0027IPv4\u0027,"},{"line_number":94,"context_line":"    per_source  \u003d\u003e \u002711\u0027,"},{"line_number":95,"context_line":"    wait        \u003d\u003e \u0027yes\u0027,"},{"line_number":96,"context_line":"    require     \u003d\u003e Package[\u0027tftp-server\u0027],"},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  service { \u0027tftpd-hpa\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_5686f113","line":96,"in_reply_to":"7a8ec9b2_50744734","updated":"2016-09-14 18:38:59.000000000","message":"Going to tag tftp-server package above this with \"ironic-support-package\"\n\nThis is because ironic doesn\u0027t need to be notified if this package changes.    \n\nWill also tag this xinetd/tftp service here as subscribed to Anchor[\u0027ironic::install::end\u0027] so that it restarts on tftp package change.","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    mode    \u003d\u003e \u00270744\u0027,"},{"line_number":133,"context_line":"    source  \u003d\u003e \"${::ironic::params::ipxe_rom_dir}/undionly.kpxe\","},{"line_number":134,"context_line":"    backup  \u003d\u003e false,"},{"line_number":135,"context_line":"    require \u003d\u003e Package[\u0027ipxe\u0027],"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  file { \"${tftp_root_real}/ipxe.efi\":"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_90940f38","line":135,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"62a419e77ab6d1153f5ef01770affd4d7caa2dea","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    mode    \u003d\u003e \u00270744\u0027,"},{"line_number":144,"context_line":"    source  \u003d\u003e \"${::ironic::params::ipxe_rom_dir}/ipxe.efi\","},{"line_number":145,"context_line":"    backup  \u003d\u003e false,"},{"line_number":146,"context_line":"    require \u003d\u003e Package[\u0027ipxe\u0027],"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  include ::apache"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_d09e9755","line":146,"updated":"2016-09-14 15:02:45.000000000","message":"same","commit_id":"a1b013bc7c00422fa69172da928acf305c9cf25b"}]}