)]}'
{"manifests/inspector.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d77da7374fcd18ee16ff0768249bd503e6812bf8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_87991122","line":40,"updated":"2016-12-02 21:00:40.000000000","message":"Usually when we deprecate things we\u0027ll move the documentation to it\u0027s own section under a \u003d\u003d\u003d DEPRECATED section and set the default to undef or $::os_service_default (since this will remove the item from from the config as well)\n\nFor example, https://review.openstack.org/#/c/395224/1","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8dc88ae243baa7c14addea337443bb72a7c81538","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_42f89149","line":40,"in_reply_to":"3a71b18c_07722b7b","updated":"2016-12-05 16:04:47.000000000","message":"So, you mean just enable UEFI? I\u0027m fine with that, just wanted to give folks some time to prepare their environments.. WDYT?","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa3106d00da427602ee8a390ec232c113ba061bf","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_c25f3ae3","line":40,"in_reply_to":"3a71b18c_0b38753c","updated":"2016-12-05 18:04:48.000000000","message":"I still don\u0027t get it. How do you suggest folks stop using the deprecated parameter without losing support for UEFI?\n\nMy only goal here is to stop having UEFI disabled by default, this is not the best idea.","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9e8466adf5c8a44b713e33ec8fc18b4120e1ee82","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_a8894728","line":40,"in_reply_to":"3a71b18c_42f89149","updated":"2016-12-05 16:23:13.000000000","message":"I think my issue is that it wasn\u0027t clear to me what is actually going on. \n\n1) we need to properly deprecate (and document) this parameter. So moving the docs down to the bottom under a \u003d\u003d\u003d DEPRECATED PARAMETERS heading. This is just the normal deprecation procedure. \n2) $enable_uefi param needs similar moving, we can leave it default to false for now.\n3) the warning needs to be more clear on the action for the end user. It wasn\u0027t clear to me that this option is being being deprecated and the functionality will just be enabled.  So it\u0027d be better to put the fact that uefi support will be turned on in Pike and the parameter will be removed in the  warning that\u0027s being returned to the end user.","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cdefca97f078e2f42fcf132da5412d37c1efe042","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_d588ebc7","line":40,"in_reply_to":"3a71b18c_87991122","updated":"2016-12-05 09:50:09.000000000","message":"I understand, but here is the thing: the option is not deprecated in this patch, but rather the fact of setting it to \"false\". The plan is for users to switch to enable_uefi\u003dtrue which will NOT issue a deprecation warning for now. Then later we can make this option a no-op with a proper deprecation warning. Does it make sense?","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"107af77d8539b9a1a7d757908912a99105016e66","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_c81e836f","line":40,"in_reply_to":"3a71b18c_a8894728","updated":"2016-12-05 16:26:29.000000000","message":"\u003e  So it\u0027d be better to put the fact that uefi support will be turned on in Pike and the parameter will be removed in the warning that\u0027s being returned to the end user.\n\nThis does not allow for a clean upgrade path though. With this patch, users can flip enable_uefi to true, then wait for Pike when it becomes true by default and remove it.\n\nIf they (like TripleO) have enable_uefi\u003dtrue already, they\u0027ll have to remove it and revert to not having UEFI. Otherwise they\u0027ll get broken in Pike when we remove the option. Then in Pike they might get broken because we enable UEFI without the ability to temporary disable it at all.","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"130db30da2d3abc7f35fa79af6298383daa89131","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_82f0e292","line":40,"in_reply_to":"3a71b18c_c25f3ae3","updated":"2016-12-05 18:12:53.000000000","message":"So I guess the issue is that you want to deprecate the functionality and not the parameter.  What I described previously is both. Deprecate the parameter, message upcoming functionality change (uefi enabled by default) and schedule removal of parameter in next cycle. If you don\u0027t want to remove the parameter in Q then just message it but honestly I don\u0027t think we need to wait that long.  You\u0027re concerns seem to be around if tripleo would be able to support uefi by then, but that\u0027s not a reason to not go through the correct deprecation process in the puppet openstack modules. I don\u0027t see the point of spacing out the functionality deprecation, then the parameter deprecation over the next year an a half.  I\u0027m trying to shorten it to like the next year.  We wouldn\u0027t merge the removal of the parameter until tripleo passes so I don\u0027t see the point of making this take longer than it has to.","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fda9f1f1a41c38908f8a7e763626352b6b32535c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_0b38753c","line":40,"in_reply_to":"3a71b18c_c81e836f","updated":"2016-12-05 16:38:41.000000000","message":"They\u0027ll have the rest of Ocata and part of Pike to fix it. We could keep the parameter until after Pike (or late in the pike cycle) but it seems like this is getting ahead of the deprecation for once rather than coming by 2 cycles later and just removing it because it doesn\u0027t work anymore. If you don\u0027t want this functionality to go away until after Pike, then we shouldn\u0027t be deprecating it now.","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f618a4d7ccd37ae88fcb2febf14cfc8ec87d2f2b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# [*enable_uefi*]"},{"line_number":38,"context_line":"#  (optional) Allow introspection of machines with UEFI firmware."},{"line_number":39,"context_line":"#  The ability to disable UEFI is deprecated and will be removed later."},{"line_number":40,"context_line":"#  Defaults to false. Ignored unless $pxe_transfer_protocol\u003d\u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*debug*]"},{"line_number":43,"context_line":"#   (optional) Enable debug logging"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_07722b7b","line":40,"in_reply_to":"3a71b18c_d588ebc7","updated":"2016-12-05 15:36:13.000000000","message":"Not really as the warning seems to indicate deprecation, why not deprecate it correctly with all the things.  Since this is just a toggle flag, set this to undef (rather than os_service_default) and update the docs correctly.","commit_id":"3030c663d8b9a2d881dcbc3c11800d3098093ce4"}]}