)]}'
{"manifests/drivers/hardware_interface.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"418a481e5a7498be48162b381c7ca604d8ac59b1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#   Defaults to $::os_service_default"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"define ironic::drivers::hardware_interface ("},{"line_number":29,"context_line":"  $interface_type   \u003d $title,"},{"line_number":30,"context_line":"  $enabled_list     \u003d $::os_service_default,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if !is_service_default($enabled_list) and !empty($enabled_list){"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a430d35_987866c6","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":19},"updated":"2017-02-07 00:55:23.000000000","message":"extra space :)","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"418a481e5a7498be48162b381c7ca604d8ac59b1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"define ironic::drivers::hardware_interface ("},{"line_number":29,"context_line":"  $interface_type   \u003d $title,"},{"line_number":30,"context_line":"  $enabled_list     \u003d $::os_service_default,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if !is_service_default($enabled_list) and !empty($enabled_list){"},{"line_number":33,"context_line":"    validate_array($enabled_list)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a430d35_d882ee93","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":19},"updated":"2017-02-07 00:55:23.000000000","message":"same","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c5fba2e7fb2ddabee6229792e19f6eac33c0dc04","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"define ironic::drivers::hardware_interface ("},{"line_number":29,"context_line":"  $interface_type   \u003d $title,"},{"line_number":30,"context_line":"  $enabled_list     \u003d $::os_service_default,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  if !is_service_default($enabled_list) and !empty($enabled_list){"},{"line_number":33,"context_line":"    validate_array($enabled_list)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_de982a1e","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":19},"in_reply_to":"1a430d35_d882ee93","updated":"2017-03-08 15:46:19.000000000","message":"Done","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"}],"manifests/drivers/interfaces.pp":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"00b23f9328ae0698cfdd7056b95479ccbd4163be","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to $::os_service_default"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*enabled_network_interfaces*]"},{"line_number":43,"context_line":"#   (optional) Specify the list of network interfaces to load during"},{"line_number":44,"context_line":"#   service initialization."},{"line_number":45,"context_line":"#   Defaults to $::os_service_default"},{"line_number":46,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_3bb438f1","line":43,"updated":"2017-03-07 12:11:00.000000000","message":"\"Network interface\" is ambiguous, but I guess it\u0027s clear from context that you don\u0027t mean \"NIC\" :-)","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c5fba2e7fb2ddabee6229792e19f6eac33c0dc04","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to $::os_service_default"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*enabled_network_interfaces*]"},{"line_number":43,"context_line":"#   (optional) Specify the list of network interfaces to load during"},{"line_number":44,"context_line":"#   service initialization."},{"line_number":45,"context_line":"#   Defaults to $::os_service_default"},{"line_number":46,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_3e8a26c0","line":43,"in_reply_to":"9a30ddce_3bb438f1","updated":"2017-03-08 15:46:19.000000000","message":"Yeah, I\u0027m following the ironic wording.","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"418a481e5a7498be48162b381c7ca604d8ac59b1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#   service initialization."},{"line_number":60,"context_line":"#   Defaults to $::os_service_default"},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ironic::drivers::interfaces ("},{"line_number":64,"context_line":"  $enabled_boot_interfaces \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $enabled_console_interfaces \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a430d35_b85a824e","line":62,"updated":"2017-02-07 00:55:23.000000000","message":"The extra line, should be removed :)","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c5fba2e7fb2ddabee6229792e19f6eac33c0dc04","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#   service initialization."},{"line_number":60,"context_line":"#   Defaults to $::os_service_default"},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ironic::drivers::interfaces ("},{"line_number":64,"context_line":"  $enabled_boot_interfaces \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $enabled_console_interfaces \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_5e851aab","line":62,"in_reply_to":"1a430d35_b85a824e","updated":"2017-03-08 15:46:19.000000000","message":"Done","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"00b23f9328ae0698cfdd7056b95479ccbd4163be","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ironic::drivers::interfaces ("},{"line_number":64,"context_line":"  $enabled_boot_interfaces \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $enabled_console_interfaces \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $enabled_deploy_interfaces \u003d $::os_service_default,"},{"line_number":67,"context_line":"  $enabled_inspect_interfaces \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_bb4908d3","line":64,"updated":"2017-03-07 12:11:00.000000000","message":"Do we want separate variables for each interface type, or a big dictionary `$enabled_interfaces { \u0027boot\u0027 \u003d\u003e [...], \u0027console\u0027 \u003d\u003e [...] }`. I guess individual variables are easier to override individually?","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0fde727a2990ebb0e4a77004acd604dcb1917048","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ironic::drivers::interfaces ("},{"line_number":64,"context_line":"  $enabled_boot_interfaces \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $enabled_console_interfaces \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $enabled_deploy_interfaces \u003d $::os_service_default,"},{"line_number":67,"context_line":"  $enabled_inspect_interfaces \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_96ac1bef","line":64,"in_reply_to":"9a30ddce_bb4908d3","updated":"2017-03-07 12:23:13.000000000","message":"yeah, one dict would be difficult to update IMO","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"418a481e5a7498be48162b381c7ca604d8ac59b1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ironic::drivers::interfaces ("},{"line_number":64,"context_line":"  $enabled_boot_interfaces \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $enabled_console_interfaces \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $enabled_deploy_interfaces \u003d $::os_service_default,"},{"line_number":67,"context_line":"  $enabled_inspect_interfaces \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $enabled_management_interfaces \u003d $::os_service_default,"},{"line_number":69,"context_line":"  $enabled_network_interfaces \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $enabled_power_interfaces \u003d $::os_service_default,"},{"line_number":71,"context_line":"  $enabled_raid_interfaces \u003d $::os_service_default,"},{"line_number":72,"context_line":"  $enabled_vendor_interfaces \u003d $::os_service_default,"},{"line_number":73,"context_line":") {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  ironic::drivers::hardware_interface { \u0027boot\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a430d35_58451e6e","line":72,"range":{"start_line":64,"start_character":2,"end_line":72,"end_character":53},"updated":"2017-02-07 00:55:23.000000000","message":"Should be aligned :)","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c5fba2e7fb2ddabee6229792e19f6eac33c0dc04","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ironic::drivers::interfaces ("},{"line_number":64,"context_line":"  $enabled_boot_interfaces \u003d $::os_service_default,"},{"line_number":65,"context_line":"  $enabled_console_interfaces \u003d $::os_service_default,"},{"line_number":66,"context_line":"  $enabled_deploy_interfaces \u003d $::os_service_default,"},{"line_number":67,"context_line":"  $enabled_inspect_interfaces \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $enabled_management_interfaces \u003d $::os_service_default,"},{"line_number":69,"context_line":"  $enabled_network_interfaces \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $enabled_power_interfaces \u003d $::os_service_default,"},{"line_number":71,"context_line":"  $enabled_raid_interfaces \u003d $::os_service_default,"},{"line_number":72,"context_line":"  $enabled_vendor_interfaces \u003d $::os_service_default,"},{"line_number":73,"context_line":") {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  ironic::drivers::hardware_interface { \u0027boot\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_bebc566d","line":72,"range":{"start_line":64,"start_character":2,"end_line":72,"end_character":53},"in_reply_to":"1a430d35_58451e6e","updated":"2017-03-08 15:46:19.000000000","message":"Done","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"38ca37ba19b0f768e16a07c2ba3f35aff36316c9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  ironic::drivers::hardware_interface { \u0027vendor\u0027:"},{"line_number":108,"context_line":"    enabled_list \u003d\u003e $enabled_vendor_interfaces,"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa31d9ce_5eb9f52d","line":110,"updated":"2017-02-09 22:28:52.000000000","message":"A better way to do this would be something like...\n\n  $interfaces \u003d {\n   \u0027boot\u0027   \u003d\u003e { \u0027enabled_list\u0027 \u003d\u003e $enabled_boot_interfaces },\n   \u0027console \u003d\u003e { \u0027enabled_list\u0027 \u003d\u003e $enabled_console_interfaces },\n   ...\n   \u0027vendor\u0027 \u003d\u003e { \u0027enabled_list\u0027 \u003d\u003e $enabled_vendor_interfaces },\n  }\n\n  create_resource(ironic::drivers::hardware_interface, $interfaces)\n\n\nAlso please cover with tests.","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c5fba2e7fb2ddabee6229792e19f6eac33c0dc04","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  ironic::drivers::hardware_interface { \u0027vendor\u0027:"},{"line_number":108,"context_line":"    enabled_list \u003d\u003e $enabled_vendor_interfaces,"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a30ddce_19ce5cb4","line":110,"in_reply_to":"fa31d9ce_5eb9f52d","updated":"2017-03-08 15:46:19.000000000","message":"Done","commit_id":"b844c753cf6cb02f84d35ed7cb79d281a14c560f"}]}
