)]}'
{"manifests/init.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"96f5fb37c45eaf0f89848c6fb95d0580eddc808a","unresolved":false,"context_lines":[{"line_number":393,"context_line":"      name   \u003d\u003e $::ironic::params::common_package_name,"},{"line_number":394,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],"},{"line_number":395,"context_line":"    }"},{"line_number":396,"context_line":"  }"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"  package { \u0027ironic-lib\u0027:"},{"line_number":399,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da36d5c6_16949889","line":396,"updated":"2017-02-20 19:51:01.000000000","message":"maybe worth moving it to a new small manifest and just include it where needed?","commit_id":"89c9863d02272d717cd373c6498c645ed2c5c18f"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"e34432e027f11fe3daaae6e05c07727f95dd55a6","unresolved":false,"context_lines":[{"line_number":393,"context_line":"      name   \u003d\u003e $::ironic::params::common_package_name,"},{"line_number":394,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],"},{"line_number":395,"context_line":"    }"},{"line_number":396,"context_line":"  }"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"  package { \u0027ironic-lib\u0027:"},{"line_number":399,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da36d5c6_740f7e2e","line":396,"in_reply_to":"da36d5c6_16949889","updated":"2017-02-21 08:46:55.000000000","message":"not sure about additional manifest but definitly better to use ensure_resource function - example: https://github.com/openstack/puppet-aodh/blob/master/manifests/listener.pp#L25","commit_id":"89c9863d02272d717cd373c6498c645ed2c5c18f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"741d9aa58e45919950ac99a84de78e8fcdd65fc4","unresolved":false,"context_lines":[{"line_number":386,"context_line":"ironic::glance::api_insecure and ironic::glance::num_retries accordingly\")"},{"line_number":387,"context_line":"  }"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"  ensure_resource( \u0027package\u0027, [$::ironic::params::common_package_name],"},{"line_number":390,"context_line":"    { ensure \u003d\u003e $package_ensure,"},{"line_number":391,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027] }"},{"line_number":392,"context_line":"  )"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  package { \u0027ironic-lib\u0027:"},{"line_number":395,"context_line":"    ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da36d5c6_cdb4fdd2","line":392,"range":{"start_line":389,"start_character":0,"end_line":392,"end_character":3},"updated":"2017-02-21 23:12:24.000000000","message":"to make this seamless it needs to be:\n\nensure_resource(\u0027package\u0027, \u0027ironic-common\u0027, {\n  ensure \u003d\u003e $package_ensure,\n  name   \u003d\u003e $::ironic::params::common_package_name,\n  tag    \u003d\u003e [\u0027openstack\u0027, \u0027ironic-package\u0027],})","commit_id":"16373c41bb5a1766db4308bffd5d85c5eb57819d"}]}
