)]}'
{"manifests/inspector.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc827acd2c077663a546459a5063f2fb920e45c","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"  if $dnsmasq_ip_range {"},{"line_number":251,"context_line":"    warning(\u0027dnsmasq_ip_range is deprecated, replaced by dnsmasq_ip_subnets\u0027)"},{"line_number":252,"context_line":"  }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  if $enable_uefi \u003d\u003d undef {"},{"line_number":255,"context_line":"    warning(\u0027UEFI will be enabled by default starting with Pike\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba2be162_fb6f74f9","line":252,"updated":"2017-03-03 11:16:07.000000000","message":"we should convert this value on fly to dnsmasq_ip_subnets format, and append to it, and drop it from the templates.","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"91558ae796b9092e62075fa75e6411d3b66c6c32","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"  if $dnsmasq_ip_range {"},{"line_number":251,"context_line":"    warning(\u0027dnsmasq_ip_range is deprecated, replaced by dnsmasq_ip_subnets\u0027)"},{"line_number":252,"context_line":"  }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  if $enable_uefi \u003d\u003d undef {"},{"line_number":255,"context_line":"    warning(\u0027UEFI will be enabled by default starting with Pike\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba2be162_50cdabb5","line":252,"in_reply_to":"ba2be162_fb6f74f9","updated":"2017-03-03 17:05:41.000000000","message":"Done","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[{"line_number":251,"context_line":"  }"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  # Need to add _dnsmasq_ip_subnets variable to avoid"},{"line_number":254,"context_line":"  #   Evaluation Error: Cannot reassign variable"},{"line_number":255,"context_line":"  if $dnsmasq_ip_range {"},{"line_number":256,"context_line":"    warning(\u0027dnsmasq_ip_range is deprecated, replaced by dnsmasq_ip_subnets\u0027)"},{"line_number":257,"context_line":"    $_dnsmasq_ip_subnets \u003d concat($dnsmasq_ip_subnets,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a30ddce_5fae9d98","line":254,"updated":"2017-03-10 12:29:42.000000000","message":"nit: this is just how puppet works, I don\u0027t think we need an explicit comment","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[{"line_number":251,"context_line":"  }"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  # Need to add _dnsmasq_ip_subnets variable to avoid"},{"line_number":254,"context_line":"  #   Evaluation Error: Cannot reassign variable"},{"line_number":255,"context_line":"  if $dnsmasq_ip_range {"},{"line_number":256,"context_line":"    warning(\u0027dnsmasq_ip_range is deprecated, replaced by dnsmasq_ip_subnets\u0027)"},{"line_number":257,"context_line":"    $_dnsmasq_ip_subnets \u003d concat($dnsmasq_ip_subnets,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a30ddce_20d60e28","line":254,"in_reply_to":"9a30ddce_5fae9d98","updated":"2017-03-11 12:10:32.000000000","message":"Done","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[{"line_number":255,"context_line":"  if $dnsmasq_ip_range {"},{"line_number":256,"context_line":"    warning(\u0027dnsmasq_ip_range is deprecated, replaced by dnsmasq_ip_subnets\u0027)"},{"line_number":257,"context_line":"    $_dnsmasq_ip_subnets \u003d concat($dnsmasq_ip_subnets,"},{"line_number":258,"context_line":"                                  {\u0027ip_range\u0027 \u003d\u003e $dnsmasq_ip_range})"},{"line_number":259,"context_line":"  } else {"},{"line_number":260,"context_line":"    $_dnsmasq_ip_subnets \u003d $dnsmasq_ip_subnets"},{"line_number":261,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a30ddce_7f97e147","line":258,"updated":"2017-03-10 12:29:42.000000000","message":"we usually name new variables as $OLDVAR_real in such cases\n\nmore important issue: currently we don\u0027t validate that $dnsmasq_ip_subnets is a list at all. I think we should start doing it, as this code assumes it\u0027s a list.","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[{"line_number":255,"context_line":"  if $dnsmasq_ip_range {"},{"line_number":256,"context_line":"    warning(\u0027dnsmasq_ip_range is deprecated, replaced by dnsmasq_ip_subnets\u0027)"},{"line_number":257,"context_line":"    $_dnsmasq_ip_subnets \u003d concat($dnsmasq_ip_subnets,"},{"line_number":258,"context_line":"                                  {\u0027ip_range\u0027 \u003d\u003e $dnsmasq_ip_range})"},{"line_number":259,"context_line":"  } else {"},{"line_number":260,"context_line":"    $_dnsmasq_ip_subnets \u003d $dnsmasq_ip_subnets"},{"line_number":261,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a30ddce_4095c230","line":258,"in_reply_to":"9a30ddce_7f97e147","updated":"2017-03-11 12:10:32.000000000","message":"Done\n\nI added a validation, and fail(\u0027Invalid data type ...)","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"}],"releasenotes/notes/deprecate-dnsmasq_ip_range-bf4cf6923b60e9d0.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc827acd2c077663a546459a5063f2fb920e45c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - With support for multiple subnets in Ironic Inspector dnsmasq"},{"line_number":4,"context_line":"    a new parameter \u0027dnsmasq_ip_subnets\u0027 was added. The"},{"line_number":5,"context_line":"    \u0027dnsmasq_ip_range\u0027 parameter is redundant."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_1b79a8c8","line":5,"updated":"2017-03-03 11:16:07.000000000","message":"please create an \"upgrade\" note explaining how to migrate from one parameter to the other (it\u0027s not obvious even to me)","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"91558ae796b9092e62075fa75e6411d3b66c6c32","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - With support for multiple subnets in Ironic Inspector dnsmasq"},{"line_number":4,"context_line":"    a new parameter \u0027dnsmasq_ip_subnets\u0027 was added. The"},{"line_number":5,"context_line":"    \u0027dnsmasq_ip_range\u0027 parameter is redundant."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_062dc8fd","line":5,"in_reply_to":"ba2be162_1b79a8c8","updated":"2017-03-03 17:05:41.000000000","message":"Done","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"}],"releasenotes/notes/routed-networks-ironic-inspector-7ccc2087fc83c052.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a30ddce_9f949543","updated":"2017-03-10 12:29:42.000000000","message":"just a note: be careful when updating release notes. you should not do it across a release boundary (fine in this case).","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a30ddce_e04876ce","in_reply_to":"9a30ddce_9f949543","updated":"2017-03-11 12:10:32.000000000","message":"Ok.","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Assigning additional subnets allow dnsmasq to serve dhcp request that came"},{"line_number":4,"context_line":"    in via dhcp relay/helper."},{"line_number":5,"context_line":"    Adds parameter \u0027dnsmasq_ip_subnets\u0027 and enable configuration of dhcp-range"},{"line_number":6,"context_line":"    and dhcp-option \u0027option:router\u0027 for additional subnets in dnsmasq."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_bf9dd967","line":3,"updated":"2017-03-10 12:29:42.000000000","message":"if you want to use advanced formatting, you do, use\n\n features:\n   - |\n     blah-blah","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Assigning additional subnets allow dnsmasq to serve dhcp request that came"},{"line_number":4,"context_line":"    in via dhcp relay/helper."},{"line_number":5,"context_line":"    Adds parameter \u0027dnsmasq_ip_subnets\u0027 and enable configuration of dhcp-range"},{"line_number":6,"context_line":"    and dhcp-option \u0027option:router\u0027 for additional subnets in dnsmasq."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_a0cd9e67","line":3,"in_reply_to":"9a30ddce_bf9dd967","updated":"2017-03-11 12:10:32.000000000","message":"Done","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Adds parameter \u0027dnsmasq_ip_subnets\u0027 and enable configuration of dhcp-range"},{"line_number":6,"context_line":"    and dhcp-option \u0027option:router\u0027 for additional subnets in dnsmasq."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Example"},{"line_number":9,"context_line":"    $dnsmasq_ip_subnets \u003d [{\u0027ip_range\u0027 \u003d\u003e \u0027192.168.0.100,192.168.0.120\u0027},"},{"line_number":10,"context_line":"                           {\u0027tag\u0027      \u003d\u003e \u0027subnet1\u0027,"},{"line_number":11,"context_line":"                            \u0027ip_range\u0027 \u003d\u003e \u0027192.168.1.100,192.168.1.200\u0027,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_df9a8d6d","line":8,"updated":"2017-03-10 12:29:42.000000000","message":"formatting:\n\n Example::\n\n   $dnsmasq_ip_subnets \u003d ...\n\nplease check rendered release notes at http://docs-draft.openstack.org/12/440812/4/check/gate-puppet-ironic-releasenotes/8744bce//releasenotes/build/html/unreleased.html or use `tox -ereleasenotes` locally to verify rendering.","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Adds parameter \u0027dnsmasq_ip_subnets\u0027 and enable configuration of dhcp-range"},{"line_number":6,"context_line":"    and dhcp-option \u0027option:router\u0027 for additional subnets in dnsmasq."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Example"},{"line_number":9,"context_line":"    $dnsmasq_ip_subnets \u003d [{\u0027ip_range\u0027 \u003d\u003e \u0027192.168.0.100,192.168.0.120\u0027},"},{"line_number":10,"context_line":"                           {\u0027tag\u0027      \u003d\u003e \u0027subnet1\u0027,"},{"line_number":11,"context_line":"                            \u0027ip_range\u0027 \u003d\u003e \u0027192.168.1.100,192.168.1.200\u0027,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_8037ba4b","line":8,"in_reply_to":"9a30ddce_df9a8d6d","updated":"2017-03-11 12:10:32.000000000","message":"Done","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[{"line_number":19,"context_line":"deprecations:"},{"line_number":20,"context_line":"  - With support for multiple subnets in Ironic Inspector dnsmasq"},{"line_number":21,"context_line":"    a new parameter \u0027dnsmasq_ip_subnets\u0027 was added. The"},{"line_number":22,"context_line":"    \u0027dnsmasq_ip_range\u0027 parameter is redundant."},{"line_number":23,"context_line":"upgrade:"},{"line_number":24,"context_line":"  - Whit the \u0027dnsmasq_ip_range\u0027 parameter deprecated the minimum change"},{"line_number":25,"context_line":"    required on upgrade is as follows"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_ff891127","line":22,"updated":"2017-03-10 12:29:42.000000000","message":"let\u0027s shorten it to \"The ironic::inspector::dnsmasq_ip_range parameter was deprecated in favor of ironic::inspector::dnsmasq_ip_subnets\"","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[{"line_number":19,"context_line":"deprecations:"},{"line_number":20,"context_line":"  - With support for multiple subnets in Ironic Inspector dnsmasq"},{"line_number":21,"context_line":"    a new parameter \u0027dnsmasq_ip_subnets\u0027 was added. The"},{"line_number":22,"context_line":"    \u0027dnsmasq_ip_range\u0027 parameter is redundant."},{"line_number":23,"context_line":"upgrade:"},{"line_number":24,"context_line":"  - Whit the \u0027dnsmasq_ip_range\u0027 parameter deprecated the minimum change"},{"line_number":25,"context_line":"    required on upgrade is as follows"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_00a82a76","line":22,"in_reply_to":"9a30ddce_ff891127","updated":"2017-03-11 12:10:32.000000000","message":"Done","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    a new parameter \u0027dnsmasq_ip_subnets\u0027 was added. The"},{"line_number":22,"context_line":"    \u0027dnsmasq_ip_range\u0027 parameter is redundant."},{"line_number":23,"context_line":"upgrade:"},{"line_number":24,"context_line":"  - Whit the \u0027dnsmasq_ip_range\u0027 parameter deprecated the minimum change"},{"line_number":25,"context_line":"    required on upgrade is as follows"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Replace $dnsmasq_ip_range \u003d \u0027192.168.0.100,192.168.0.200\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_1f8fc52a","line":24,"updated":"2017-03-10 12:29:42.000000000","message":"I think you meant s/Whit/With/","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    a new parameter \u0027dnsmasq_ip_subnets\u0027 was added. The"},{"line_number":22,"context_line":"    \u0027dnsmasq_ip_range\u0027 parameter is redundant."},{"line_number":23,"context_line":"upgrade:"},{"line_number":24,"context_line":"  - Whit the \u0027dnsmasq_ip_range\u0027 parameter deprecated the minimum change"},{"line_number":25,"context_line":"    required on upgrade is as follows"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Replace $dnsmasq_ip_range \u003d \u0027192.168.0.100,192.168.0.200\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_20b9aecc","line":24,"in_reply_to":"9a30ddce_1f8fc52a","updated":"2017-03-11 12:10:32.000000000","message":"Done","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b541dba7892340f71656872fb356634e62fba377","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    required on upgrade is as follows"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Replace $dnsmasq_ip_range \u003d \u0027192.168.0.100,192.168.0.200\u0027"},{"line_number":28,"context_line":"    With $dnsmasq_ip_subnets \u003d [{\u0027ip_range\u0027 \u003d\u003e \u0027192.168.0.100,192.168.0.200\u0027}]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_3f8009f7","line":28,"updated":"2017-03-10 12:29:42.000000000","message":"formatting (and shortening):\n\n upgrade:\n   - |\n     Replace usage of ``ironic::inspector::dnsmasq_ip_range`` with ``ironic::inspector::dnsmasq_ip_subnets``. For example, if you have::\n\n       $dnsmasq_ip_range \u003d \u0027192.168.0.100,192.168.0.200\u0027\n\n     replace it with\n\n       $dnsmasq_ip_subnets \u003d [{...}]","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0a2713f6a0be340fdbf9e2848e279f27bcb86273","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    required on upgrade is as follows"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Replace $dnsmasq_ip_range \u003d \u0027192.168.0.100,192.168.0.200\u0027"},{"line_number":28,"context_line":"    With $dnsmasq_ip_subnets \u003d [{\u0027ip_range\u0027 \u003d\u003e \u0027192.168.0.100,192.168.0.200\u0027}]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_60fd666d","line":28,"in_reply_to":"9a30ddce_3f8009f7","updated":"2017-03-11 12:10:32.000000000","message":"Done","commit_id":"55181c243620aef4c631e6d8e00da523eeb85ed9"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"69b2e3d177d871072d7d434047fff85e1619f728","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    Replace usage of \"ironic::inspector::dnsmasq_ip_range\" with"},{"line_number":27,"context_line":"    \"ironic::inspector::dnsmasq_ip_subnets\". For example, if you have::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"      $dnsmasq_ip_range \u003d \u0027192.168.0.100,192.168.0.200\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    replace with::"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a30ddce_429926c3","line":29,"range":{"start_line":29,"start_character":41,"end_line":29,"end_character":54},"updated":"2017-03-13 15:14:35.000000000","message":"Should be 192.168.0.120 to match example above and replacement \"dnsmasq_ip_subnets\" below.","commit_id":"a9d1e55a49c0fe6ab8077001e89af0aee2ee3b13"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"eb1c3e4e62fdbf3274761455b41d268b5d0f5dfe","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    Replace usage of \"ironic::inspector::dnsmasq_ip_range\" with"},{"line_number":27,"context_line":"    \"ironic::inspector::dnsmasq_ip_subnets\". For example, if you have::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"      $dnsmasq_ip_range \u003d \u0027192.168.0.100,192.168.0.200\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    replace with::"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a30ddce_b6d5c31c","line":29,"range":{"start_line":29,"start_character":41,"end_line":29,"end_character":54},"in_reply_to":"9a30ddce_429926c3","updated":"2017-03-13 15:29:28.000000000","message":"Yes, thanks Bob. I will push another patch set once rspec test run has completed.","commit_id":"a9d1e55a49c0fe6ab8077001e89af0aee2ee3b13"}],"spec/classes/ironic_inspector_spec.rb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc827acd2c077663a546459a5063f2fb920e45c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      :swift_username        \u003d\u003e \u0027ironic\u0027,"},{"line_number":46,"context_line":"      :swift_tenant_name     \u003d\u003e \u0027services\u0027,"},{"line_number":47,"context_line":"      :swift_auth_url        \u003d\u003e \u0027http://127.0.0.1:5000/v2.0\u0027,"},{"line_number":48,"context_line":"      :dnsmasq_ip_range      \u003d\u003e false,"},{"line_number":49,"context_line":"      :dnsmasq_ip_subnets    \u003d\u003e [ { \u0027tag\u0027      \u003d\u003e \u0027subnet1\u0027,"},{"line_number":50,"context_line":"                                    \u0027ip_range\u0027 \u003d\u003e \u0027192.168.1.100,192.168.1.200\u0027,"},{"line_number":51,"context_line":"                                    \u0027netmask\u0027  \u003d\u003e \u0027255.255.255.0\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ba2be162_7b7c64b5","line":48,"updated":"2017-03-03 11:16:07.000000000","message":"should be dropped or set to undef","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"91558ae796b9092e62075fa75e6411d3b66c6c32","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      :swift_username        \u003d\u003e \u0027ironic\u0027,"},{"line_number":46,"context_line":"      :swift_tenant_name     \u003d\u003e \u0027services\u0027,"},{"line_number":47,"context_line":"      :swift_auth_url        \u003d\u003e \u0027http://127.0.0.1:5000/v2.0\u0027,"},{"line_number":48,"context_line":"      :dnsmasq_ip_range      \u003d\u003e false,"},{"line_number":49,"context_line":"      :dnsmasq_ip_subnets    \u003d\u003e [ { \u0027tag\u0027      \u003d\u003e \u0027subnet1\u0027,"},{"line_number":50,"context_line":"                                    \u0027ip_range\u0027 \u003d\u003e \u0027192.168.1.100,192.168.1.200\u0027,"},{"line_number":51,"context_line":"                                    \u0027netmask\u0027  \u003d\u003e \u0027255.255.255.0\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ba2be162_665da478","line":48,"in_reply_to":"ba2be162_7b7c64b5","updated":"2017-03-03 17:05:41.000000000","message":"Done","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"}],"templates/inspector_dnsmasq_http.erb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc827acd2c077663a546459a5063f2fb920e45c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003c% end -%\u003e"},{"line_number":10,"context_line":"\u003c% if @dnsmasq_ip_range -%\u003e"},{"line_number":11,"context_line":"dhcp-range\u003d\u003c%\u003d @dnsmasq_ip_range %\u003e,29"},{"line_number":12,"context_line":"\u003c% end -%\u003e"},{"line_number":13,"context_line":"dhcp-sequential-ip"},{"line_number":14,"context_line":"dhcp-match\u003dipxe,175"},{"line_number":15,"context_line":"\u003c% if @enable_uefi -%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"ba2be162_3b766cd7","line":12,"updated":"2017-03-03 11:16:07.000000000","message":"this has to be removed at all, see above","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"91558ae796b9092e62075fa75e6411d3b66c6c32","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003c% end -%\u003e"},{"line_number":10,"context_line":"\u003c% if @dnsmasq_ip_range -%\u003e"},{"line_number":11,"context_line":"dhcp-range\u003d\u003c%\u003d @dnsmasq_ip_range %\u003e,29"},{"line_number":12,"context_line":"\u003c% end -%\u003e"},{"line_number":13,"context_line":"dhcp-sequential-ip"},{"line_number":14,"context_line":"dhcp-match\u003dipxe,175"},{"line_number":15,"context_line":"\u003c% if @enable_uefi -%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"ba2be162_66ebe478","line":12,"in_reply_to":"ba2be162_3b766cd7","updated":"2017-03-03 17:05:41.000000000","message":"Done","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"}],"templates/inspector_dnsmasq_tftp.erb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc827acd2c077663a546459a5063f2fb920e45c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003c% end -%\u003e"},{"line_number":10,"context_line":"\u003c% if @dnsmasq_ip_range -%\u003e"},{"line_number":11,"context_line":"dhcp-range\u003d\u003c%\u003d @dnsmasq_ip_range %\u003e,29"},{"line_number":12,"context_line":"\u003c% end -%\u003e"},{"line_number":13,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,\u003c%\u003d @dnsmasq_local_ip %\u003e"},{"line_number":14,"context_line":"dhcp-sequential-ip"}],"source_content_type":"application/x-erb","patch_set":1,"id":"ba2be162_5b7fa0aa","line":12,"updated":"2017-03-03 11:16:07.000000000","message":"ditto","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"91558ae796b9092e62075fa75e6411d3b66c6c32","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003c% end -%\u003e"},{"line_number":10,"context_line":"\u003c% if @dnsmasq_ip_range -%\u003e"},{"line_number":11,"context_line":"dhcp-range\u003d\u003c%\u003d @dnsmasq_ip_range %\u003e,29"},{"line_number":12,"context_line":"\u003c% end -%\u003e"},{"line_number":13,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,\u003c%\u003d @dnsmasq_local_ip %\u003e"},{"line_number":14,"context_line":"dhcp-sequential-ip"}],"source_content_type":"application/x-erb","patch_set":1,"id":"ba2be162_c6fad042","line":12,"in_reply_to":"ba2be162_5b7fa0aa","updated":"2017-03-03 17:05:41.000000000","message":"Done","commit_id":"e23ea223d4bcf3d7f66593b1fb4aae7e8f194d22"}]}