)]}'
{"manifests/conductor.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e52e75aa42460780803d64d5637081dd0a7b9556","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    \u0027conductor/configdrive_swift_container\u0027:      value \u003d\u003e $configdrive_swift_container;"},{"line_number":249,"context_line":"    \u0027deploy/default_boot_option\u0027:                 value \u003d\u003e $default_boot_option;"},{"line_number":250,"context_line":"  }"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  if $cleaning_network_real {"},{"line_number":253,"context_line":"    ironic_config {"},{"line_number":254,"context_line":"      \u0027neutron/cleaning_network\u0027: value \u003d\u003e $cleaning_network_real;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_734f86bd","line":251,"updated":"2017-03-24 15:06:05.000000000","message":"We need a check to make sure that the *_network_name and *_network are not both defined otherwise this will fail.","commit_id":"1051a4c809d53bdcd313996795f2df63fdce68a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5abd348b85561df7ae8fe384ad6d1dd4dc82ac01","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    \u0027conductor/configdrive_swift_container\u0027:      value \u003d\u003e $configdrive_swift_container;"},{"line_number":249,"context_line":"    \u0027deploy/default_boot_option\u0027:                 value \u003d\u003e $default_boot_option;"},{"line_number":250,"context_line":"  }"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  if $cleaning_network_real {"},{"line_number":253,"context_line":"    ironic_config {"},{"line_number":254,"context_line":"      \u0027neutron/cleaning_network\u0027: value \u003d\u003e $cleaning_network_real;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_85763dd8","line":251,"in_reply_to":"ffe62b97_734f86bd","updated":"2017-03-24 15:23:01.000000000","message":"Done","commit_id":"1051a4c809d53bdcd313996795f2df63fdce68a6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3f666d8c6cd333d540b20b2325367561757cc7f5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"# [*cleaning_network_name*]"},{"line_number":104,"context_line":"#   (optional) If provided the name will be converted to UUID and set"},{"line_number":105,"context_line":"#   as value of neutron/cleaning_network option in ironic.conf"},{"line_number":106,"context_line":"#   Defaults to undef, which leaves the configuration intact"},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"# [*provisioning_network_name*]"},{"line_number":109,"context_line":"#   (optional) If provided the name will be converted to UUID and set"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ffe62b97_db32e8a7","line":106,"updated":"2017-03-24 15:56:32.000000000","message":"should mention that you cannot specify this and cleaning_network here","commit_id":"2b9e1b973b5c45f7216e9fa9347767e5d3ebca3d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3f666d8c6cd333d540b20b2325367561757cc7f5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"# [*provisioning_network_name*]"},{"line_number":109,"context_line":"#   (optional) If provided the name will be converted to UUID and set"},{"line_number":110,"context_line":"#   as value of neutron/provisioning_network option in ironic.conf"},{"line_number":111,"context_line":"#   Defaults to undef, which leaves the configuration intact"},{"line_number":112,"context_line":"#"},{"line_number":113,"context_line":"# DEPRECATED"},{"line_number":114,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ffe62b97_5b1ed80c","line":111,"updated":"2017-03-24 15:56:32.000000000","message":"same here, please mention you can\u0027t specify provisioning_network and this","commit_id":"2b9e1b973b5c45f7216e9fa9347767e5d3ebca3d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3f666d8c6cd333d540b20b2325367561757cc7f5","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  $cleaning_network_real \u003d pick($cleaning_network_uuid, $cleaning_network)"},{"line_number":182,"context_line":"  $provisioning_network_real \u003d pick($provisioning_network_uuid, $provisioning_network)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if ($cleaning_network_name and $cleaning_network_real !\u003d $::os_service_default) {"},{"line_number":185,"context_line":"    fail(\"cleaning_network_name and cleaning_network or cleaning_network_uuid can not be \\"},{"line_number":186,"context_line":"specified in the same time.\")"},{"line_number":187,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ffe62b97_5b0ff82d","line":184,"range":{"start_line":184,"start_character":33,"end_line":184,"end_character":80},"updated":"2017-03-24 15:56:32.000000000","message":"You can just use !is_service_default($cleaning_network_real) as we have a helper function for this check","commit_id":"2b9e1b973b5c45f7216e9fa9347767e5d3ebca3d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3f666d8c6cd333d540b20b2325367561757cc7f5","unresolved":false,"context_lines":[{"line_number":186,"context_line":"specified in the same time.\")"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  if ($provisioning_network_name and $provisioning_network_real !\u003d $::os_service_default) {"},{"line_number":190,"context_line":"    fail(\"provisioning_network_name and provisioning_network or provisioning_network_uuid can not be \\"},{"line_number":191,"context_line":"specified in the same time.\")"},{"line_number":192,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ffe62b97_fb836c55","line":189,"updated":"2017-03-24 15:56:32.000000000","message":"same","commit_id":"2b9e1b973b5c45f7216e9fa9347767e5d3ebca3d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3f666d8c6cd333d540b20b2325367561757cc7f5","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    \u0027deploy/default_boot_option\u0027:                 value \u003d\u003e $default_boot_option;"},{"line_number":260,"context_line":"  }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  if $cleaning_network_real !\u003d $::os_service_default {"},{"line_number":263,"context_line":"    ironic_config {"},{"line_number":264,"context_line":"      \u0027neutron/cleaning_network\u0027: value \u003d\u003e $cleaning_network_real;"},{"line_number":265,"context_line":"    }"},{"line_number":266,"context_line":"  }"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"  if $provisioning_network_real !\u003d $::os_service_default {"},{"line_number":269,"context_line":"    ironic_config {"},{"line_number":270,"context_line":"      \u0027neutron/provisioning_network\u0027: value \u003d\u003e $provisioning_network_real;"},{"line_number":271,"context_line":"    }"},{"line_number":272,"context_line":"  }"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"  if $cleaning_network_name {"},{"line_number":275,"context_line":"    ironic_config {"},{"line_number":276,"context_line":"      \u0027neutron/cleaning_network\u0027: value \u003d\u003e $cleaning_network_name, transform_to \u003d\u003e \u0027net_uuid\u0027;"},{"line_number":277,"context_line":"    }"},{"line_number":278,"context_line":"  }"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"  if $provisioning_network_name {"},{"line_number":281,"context_line":"    ironic_config {"},{"line_number":282,"context_line":"      \u0027neutron/provisioning_network\u0027: value \u003d\u003e $provisioning_network_name, transform_to \u003d\u003e \u0027net_uuid\u0027;"},{"line_number":283,"context_line":"    }"},{"line_number":284,"context_line":"  }"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"  # Install package"},{"line_number":287,"context_line":"  if $::ironic::params::conductor_package {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ffe62b97_1b6050ce","line":284,"range":{"start_line":262,"start_character":0,"end_line":284,"end_character":3},"updated":"2017-03-24 15:56:32.000000000","message":"I think we want...\n\nif $cleaning_network_name { \n  ironic_config {\n    \u0027neutron/cleaning_network\u0027: value \u003d\u003e $cleaning_network_name, transform_to \u003d\u003e \u0027net_uuid\u0027;\n  }\n} else {\n  ironic_config {\n    \u0027neutron/cleaning_network\u0027: value \u003d\u003e $cleaning_network_real;\n  }\n}\n\nif $provisioning_network_name { \n  ironic_config {\n    \u0027neutron/provisioning_network\u0027: value \u003d\u003e $provisioning_network_name, transform_to \u003d\u003e \u0027net_uuid\u0027;\n  }\n} else {\n  ironic_config {\n    \u0027neutron/provisioning_network\u0027: value \u003d\u003e $provisioning_network_real;\n  }\n}\n\nSince we check that both cannot be specified this will allow the proper configurations to be set. We want to allow $::os_service_default because it will remove the option from the config file so we don\u0027t want to exclude it from being set.","commit_id":"2b9e1b973b5c45f7216e9fa9347767e5d3ebca3d"}],"releasenotes/notes/add_net_name_to_uuid_transformation-81a91758991935d0.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3921073ad09e70bac0b8a26918f12c9f7625af35","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add the ability to specify the a name string for the provisioning_network in"},{"line_number":4,"context_line":"    ironic_config using the transform_to argument."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a1ced50_740a6827","line":3,"updated":"2017-03-23 10:17:59.000000000","message":"and cleaning_network as well, right?","commit_id":"275613cbd60c3ee35bcdd3ae5a7c44e3d17a5f00"}]}
