)]}'
{"manifests/inspector.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23524d074b2def0f0bb2000c898c8c874b77608d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# [*add_ports*]"},{"line_number":59,"context_line":"#   (optional)  Which MAC addresses to add as ports during introspection."},{"line_number":60,"context_line":"#   Allowed values: all, active, pxe."},{"line_number":61,"context_line":"#   Defaults to \u0027pxe\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*keep_ports*]"},{"line_number":64,"context_line":"#   (optional) Which ports to keep after introspection"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5ff73747_3b774ea3","line":61,"updated":"2017-04-26 11:22:29.000000000","message":"+1 to os_service_default","commit_id":"76a133a67093ab778037763a29773b49032570e5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"e890e406f6b968a8e4772c81ee749b4e3170fa7c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# [*add_ports*]"},{"line_number":59,"context_line":"#   (optional)  Which MAC addresses to add as ports during introspection."},{"line_number":60,"context_line":"#   Allowed values: all, active, pxe."},{"line_number":61,"context_line":"#   Defaults to \u0027pxe\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*keep_ports*]"},{"line_number":64,"context_line":"#   (optional) Which ports to keep after introspection"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5ff73747_b3782c2a","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":21},"updated":"2017-04-26 08:57:39.000000000","message":"os_service_default it should be","commit_id":"76a133a67093ab778037763a29773b49032570e5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9416d1fc4be70a92104a8dd480e60ed7bc8bf054","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# [*add_ports*]"},{"line_number":59,"context_line":"#   (optional)  Which MAC addresses to add as ports during introspection."},{"line_number":60,"context_line":"#   Allowed values: all, active, pxe."},{"line_number":61,"context_line":"#   Defaults to \u0027pxe\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*keep_ports*]"},{"line_number":64,"context_line":"#   (optional) Which ports to keep after introspection"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5ff73747_c56ac9b1","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":21},"in_reply_to":"5ff73747_ae08bf2b","updated":"2017-04-26 10:21:54.000000000","message":"yeah, I see but default value of this parameter in ironic is pxe http://git.openstack.org/cgit/openstack/ironic-inspector/tree/ironic_inspector/conf.py#n58, so we can safely put os_service_default here and modify the check accordingly","commit_id":"76a133a67093ab778037763a29773b49032570e5"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"e1a2d804134b5290dfbc25593dc8d90d95a226ee","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# [*add_ports*]"},{"line_number":59,"context_line":"#   (optional)  Which MAC addresses to add as ports during introspection."},{"line_number":60,"context_line":"#   Allowed values: all, active, pxe."},{"line_number":61,"context_line":"#   Defaults to \u0027pxe\u0027"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*keep_ports*]"},{"line_number":64,"context_line":"#   (optional) Which ports to keep after introspection"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5ff73747_ae08bf2b","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":21},"in_reply_to":"5ff73747_b3782c2a","updated":"2017-04-26 09:44:42.000000000","message":"please see #line 285, it will do parameter validation to check the correct of value.","commit_id":"76a133a67093ab778037763a29773b49032570e5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23524d074b2def0f0bb2000c898c8c874b77608d","unresolved":false,"context_lines":[{"line_number":283,"context_line":"  }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":286,"context_line":"    fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":287,"context_line":"  }"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"  warning(\"After Newton cycle ::ironic::inspector won\u0027t provide \\"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5ff73747_1b7a5287","line":286,"updated":"2017-04-26 11:22:29.000000000","message":"I\u0027d vote to leave out this check, and rely on oslo.config to validate it.","commit_id":"76a133a67093ab778037763a29773b49032570e5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61923d5690fe787966f2758c0bb5ad1a4c956d73","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    $dnsmasq_ip_subnets_real \u003d $dnsmasq_ip_subnets"},{"line_number":283,"context_line":"  }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  if $add_ports !\u003d $::os_service_default {"},{"line_number":286,"context_line":"    if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":287,"context_line":"      fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":288,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5ff73747_6e6952f7","line":285,"updated":"2017-04-27 22:23:32.000000000","message":"by the way there is a helper function called is_service_default. So !is_service_default($add_ports)","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"e0440f8aa901f5be5ed010471e318e73ba18d7c3","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    $dnsmasq_ip_subnets_real \u003d $dnsmasq_ip_subnets"},{"line_number":283,"context_line":"  }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  if $add_ports !\u003d $::os_service_default {"},{"line_number":286,"context_line":"    if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":287,"context_line":"      fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":288,"context_line":"    }"},{"line_number":289,"context_line":"  }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"  warning(\"After Newton cycle ::ironic::inspector won\u0027t provide \\"},{"line_number":292,"context_line":"tftpboot and httpboot setup, please include ::ironic::pxe\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5ff73747_0a809abf","line":289,"range":{"start_line":285,"start_character":0,"end_line":289,"end_character":3},"updated":"2017-04-27 08:00:01.000000000","message":"I tend to agree that we needn\u0027t this check and let python code to decide if it\u0027s correct or not, so we don\u0027t need to maintain all possible values for this option. other thought?","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d53cc09e66fe08f65fce9427c7da300591f4a537","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":287,"context_line":"      fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":288,"context_line":"    }"},{"line_number":289,"context_line":"  }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"  warning(\"After Newton cycle ::ironic::inspector won\u0027t provide \\"},{"line_number":292,"context_line":"tftpboot and httpboot setup, please include ::ironic::pxe\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5ff73747_656191d3","line":289,"updated":"2017-04-27 08:14:25.000000000","message":"we don\u0027t do it for keep_ports, so I don\u0027t see a point in doing it for add_ports","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"81840623c9c05db19317cc3b2d03510200927e22","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":287,"context_line":"      fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":288,"context_line":"    }"},{"line_number":289,"context_line":"  }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"  warning(\"After Newton cycle ::ironic::inspector won\u0027t provide \\"},{"line_number":292,"context_line":"tftpboot and httpboot setup, please include ::ironic::pxe\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f044301_0ceea387","line":289,"in_reply_to":"3f044301_2d0e083b","updated":"2017-05-08 14:23:53.000000000","message":"I\u0027d prefer that we not add more logic for validation of settings within the openstack services to the puppet modules. The reason why we went with $::os_service_default, etc was to try and move away from having duplicated logic within puppet. The problem really comes with having to maintain the logic within puppet that matches the upstream service. If the service changes (and it will), we end up causing ourselves or the end user pain because they then have to patch the module with the new values. We do not have the active community to rely on and it\u0027s more likely to cause us issues down the road then be a benefit to anyone.","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"80bfdc1e56cc804a8ad1ea56941cf715c32e94b6","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":287,"context_line":"      fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":288,"context_line":"    }"},{"line_number":289,"context_line":"  }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"  warning(\"After Newton cycle ::ironic::inspector won\u0027t provide \\"},{"line_number":292,"context_line":"tftpboot and httpboot setup, please include ::ironic::pxe\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f044301_2d0e083b","line":289,"in_reply_to":"3f044301_4e4ab527","updated":"2017-05-08 01:26:40.000000000","message":"Sorry for my arbitrary conclusion about \"most\".\nBenefit from some puppet modules(for example, https://github.com/puppetlabs/puppetlabs-apache/blob/master/manifests/init.pp) which is doing strict the input value of params validation, it reduce the possibility of misconfiguration for end user.\nBesides that, in some situation of using Puppet C/S mode and hiera, param type error or misconfige will add the difficulty to troubleshooting.\nSo not special, but just start to add validation logic in new adding params.","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d3847ea9633ecc9625aa0fc36de9ca6a4c4b0e1","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":287,"context_line":"      fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":288,"context_line":"    }"},{"line_number":289,"context_line":"  }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"  warning(\"After Newton cycle ::ironic::inspector won\u0027t provide \\"},{"line_number":292,"context_line":"tftpboot and httpboot setup, please include ::ironic::pxe\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f044301_4e4ab527","line":289,"in_reply_to":"3f044301_79666054","updated":"2017-05-04 08:17:58.000000000","message":"Not sure about \"most\" of puppet modules, but we don\u0027t do it here, so I\u0027m not sure why this parameter is so special.","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"e66e3528d69a131b346d1d86f623343df8a06988","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    if !member([\u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027], $add_ports) {"},{"line_number":287,"context_line":"      fail(\"Invalid value, parameter add_ports must be in \u0027all\u0027,\u0027active\u0027,\u0027pxe\u0027\")"},{"line_number":288,"context_line":"    }"},{"line_number":289,"context_line":"  }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"  warning(\"After Newton cycle ::ironic::inspector won\u0027t provide \\"},{"line_number":292,"context_line":"tftpboot and httpboot setup, please include ::ironic::pxe\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f044301_79666054","line":289,"in_reply_to":"5ff73747_656191d3","updated":"2017-05-04 03:25:29.000000000","message":"yes, but in most of puppetlabs modules, they dit this to reduce the error rate of misconfiguration.\n\n I really do think it\u0027s important to improve the robustness of openstack modules.  Any thoughts ?","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"}],"spec/classes/ironic_inspector_spec.rb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d53cc09e66fe08f65fce9427c7da300591f4a537","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      :auth_strategy         \u003d\u003e \u0027keystone\u0027,"},{"line_number":33,"context_line":"      :dnsmasq_interface     \u003d\u003e \u0027br-ctlplane\u0027,"},{"line_number":34,"context_line":"      :ramdisk_logs_dir      \u003d\u003e \u0027/var/log/ironic-inspector/ramdisk/\u0027,"},{"line_number":35,"context_line":"      :add_ports             \u003d\u003e \u0027pxe\u0027,"},{"line_number":36,"context_line":"      :keep_ports            \u003d\u003e \u0027all\u0027,"},{"line_number":37,"context_line":"      :store_data            \u003d\u003e \u0027none\u0027,"},{"line_number":38,"context_line":"      :ironic_auth_type      \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5ff73747_455e9512","line":35,"updated":"2017-04-27 08:14:25.000000000","message":"this is not the default now","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d53cc09e66fe08f65fce9427c7da300591f4a537","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027firewall/dnsmasq_interface\u0027).with_value(p[:dnsmasq_interface])"},{"line_number":106,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027processing/ramdisk_logs_dir\u0027).with_value(p[:ramdisk_logs_dir])"},{"line_number":107,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027processing/enable_setting_ipmi_credentials\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":108,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027processing/add_ports\u0027).with_value(p[:add_ports])"},{"line_number":109,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027processing/keep_ports\u0027).with_value(p[:keep_ports])"},{"line_number":110,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027processing/store_data\u0027).with_value(p[:store_data])"},{"line_number":111,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027ironic/auth_type\u0027).with_value(p[:ironic_auth_type])"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5ff73747_259dc9bb","line":108,"updated":"2017-04-27 08:14:25.000000000","message":"has to be \u003cSERVICE DEFAULT\u003e","commit_id":"ba58f8fccdc4c577f7edf81f580c0f61d7fa6678"}]}
