)]}'
{"spec/classes/ironic_inspector_cors_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"035ea7624115d5d655c469863eb46c4a257ac66a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  shared_examples_for \u0027ironic inspector cors\u0027 do"},{"line_number":6,"context_line":"    it \u0027configure cors default params\u0027 do"},{"line_number":7,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027cors/allowed_origin\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":8,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027cors/allow_credentials\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":9,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027cors/expose_headers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":10,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027cors/max_age\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":11,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027cors/allow_methods\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":12,"context_line":"      is_expected.to contain_ironic_inspector_config(\u0027cors/allow_headers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":13,"context_line":"    end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    context \u0027with specific parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df140735_c36b11ef","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":106},"updated":"2017-06-07 18:50:58.000000000","message":"So you\u0027re going to hate me, but the example i gave you wasn\u0027t a good one. What we should be testing here is the oslo::cors call. There\u0027s been some work to correct this over time but we\u0027ve missed some spots evidently.\n\nThis really should be:\n\n  is_expected.to contain_oslo__cors(\u0027ironic_inspector_config\u0027).with(\n    :allowed_origin    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,\n    :allow_credentials \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,\n    :expose_headers    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,\n    :max_age           \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,\n    :allow_methods     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,\n    :allow_headers     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)\n\n\nThe problem with this is techincally you\u0027re testing what oslo::cors does which isn\u0027t the right thing to be testing with these tests. We just want to make sure we\u0027re calling the right thing in ironic::inspector::cors and to let the testing in puppet-oslo ensure the appropriate action is occuring for those resources.","commit_id":"f13fade163f8cef02b48ed9ffa1402625cb7f95d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"035ea7624115d5d655c469863eb46c4a257ac66a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      end"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"      it \u0027configure cors params\u0027 do"},{"line_number":27,"context_line":"        is_expected.to contain_ironic_inspector_config(\u0027cors/allowed_origin\u0027).with_value(\u0027*\u0027)"},{"line_number":28,"context_line":"        is_expected.to contain_ironic_inspector_config(\u0027cors/allow_credentials\u0027).with_value(true)"},{"line_number":29,"context_line":"        is_expected.to contain_ironic_inspector_config(\u0027cors/expose_headers\u0027).with_value(\u0027Content-Language,Expires\u0027)"},{"line_number":30,"context_line":"        is_expected.to contain_ironic_inspector_config(\u0027cors/max_age\u0027).with_value(3600)"},{"line_number":31,"context_line":"        is_expected.to contain_ironic_inspector_config(\u0027cors/allow_methods\u0027).with_value(\u0027GET,POST,PUT,DELETE,OPTIONS\u0027)"},{"line_number":32,"context_line":"        is_expected.to contain_ironic_inspector_config(\u0027cors/allow_headers\u0027).with_value(\u0027Content-Type,Cache-Control\u0027)"},{"line_number":33,"context_line":"      end"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df140735_2321aca0","line":32,"range":{"start_line":27,"start_character":8,"end_line":32,"end_character":117},"updated":"2017-06-07 18:50:58.000000000","message":"And this bit would just be\n\n  is_expected.to contain_oslo__cors(\u0027ironic_inspector_config\u0027).with(\n    :allowed_origin    \u003d\u003e \u0027*\u0027,\n    :allow_credentials \u003d\u003e true,\n    :expose_headers    \u003d\u003e \u0027Content-Language,Expires\u0027,\n    :max_age           \u003d\u003e 3600,\n    :allow_methods     \u003d\u003e \u0027GET,POST,PUET,DELETE,OPTIONS\u0027,\n    :allow_headers     \u003d\u003e \u0027Content-Type,Cache-Control\u0027)","commit_id":"f13fade163f8cef02b48ed9ffa1402625cb7f95d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a14193145fc5291f6e9f4f46ec2ad9fdac7b5e49","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  shared_examples_for \u0027ironic inspector cors\u0027 do"},{"line_number":6,"context_line":"    it \u0027configure cors default params\u0027 do"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  is_expected.to contain_oslo__cors(\u0027ironic_inspector_config\u0027).with("},{"line_number":9,"context_line":"      :allowed_origin    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":10,"context_line":"      :allow_credentials \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":11,"context_line":"      :expose_headers    \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"bf091321_5b701073","line":8,"updated":"2017-06-08 17:40:20.000000000","message":"nit: formatting add some more spaces in front","commit_id":"eeeafcfbac819c7f882d46a41e6c8e5c11bee92c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c05fd4cc16edd7f4651b6aa2f4c4b0cac0708f03","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        :allow_credentials \u003d\u003e true,"},{"line_number":32,"context_line":"        :expose_headers    \u003d\u003e \u0027Content-Language,Expires\u0027,"},{"line_number":33,"context_line":"        :max_age           \u003d\u003e 3600,"},{"line_number":34,"context_line":"        :allow_methods     \u003d\u003e \u0027GET,POST,PUET,DELETE,OPTIONS\u0027,"},{"line_number":35,"context_line":"        :allow_headers     \u003d\u003e \u0027Content-Type,Cache-Control\u0027)"},{"line_number":36,"context_line":"      end"},{"line_number":37,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"bf091321_b1598bff","line":34,"range":{"start_line":34,"start_character":40,"end_line":34,"end_character":44},"updated":"2017-06-08 18:46:19.000000000","message":"copy-pasta error, should be PUT","commit_id":"eeeafcfbac819c7f882d46a41e6c8e5c11bee92c"}]}
