)]}'
{"manifests/wsgi/apache.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9bb0bf5c697ab9527590be1f3a348f3b04245c92","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"#   [*access_log_file*]"},{"line_number":70,"context_line":"#     The log file name for the virtualhost."},{"line_number":71,"context_line":"#     Optional. Defaults to false."},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"#   [*access_log_format*]"},{"line_number":74,"context_line":"#     The log format for the virtualhost."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_6f02bab6","line":71,"updated":"2017-10-06 13:39:22.000000000","message":"\"It\u0027s done this way somewhere else is not an answer\" ;) I see that these are the defaults in openstacklib, so I guess it\u0027s fine (though weird). Please only add a release note then.","commit_id":"b100bbd954558b1026af66e498b265e23cb76200"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbe270fba1b4657e8e22775605f10ef31e47140c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"#   [*access_log_file*]"},{"line_number":70,"context_line":"#     The log file name for the virtualhost."},{"line_number":71,"context_line":"#     Optional. Defaults to false."},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"#   [*access_log_format*]"},{"line_number":74,"context_line":"#     The log format for the virtualhost."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_ef7d8a6e","line":71,"updated":"2017-10-06 13:35:08.000000000","message":"what\u0027s the meaning of \"false\" here? why not set it to \"undef\"?","commit_id":"b100bbd954558b1026af66e498b265e23cb76200"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e7758ced837d954b5a7bd60a89148ee88d853f9c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"#   [*access_log_file*]"},{"line_number":70,"context_line":"#     The log file name for the virtualhost."},{"line_number":71,"context_line":"#     Optional. Defaults to false."},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"#   [*access_log_format*]"},{"line_number":74,"context_line":"#     The log format for the virtualhost."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_eff22a06","line":71,"in_reply_to":"7f515b1d_ef7d8a6e","updated":"2017-10-06 13:36:09.000000000","message":"It\u0027s the way it was done in keystone. So kept it like this for uniformity.","commit_id":"b100bbd954558b1026af66e498b265e23cb76200"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c95a0fa2b78b19181f03eeb1b910b186c7273ea0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"#   [*access_log_file*]"},{"line_number":70,"context_line":"#     The log file name for the virtualhost."},{"line_number":71,"context_line":"#     Optional. Defaults to false."},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"#   [*access_log_format*]"},{"line_number":74,"context_line":"#     The log format for the virtualhost."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_4fba5e0a","line":71,"in_reply_to":"7f515b1d_eff22a06","updated":"2017-10-06 13:37:03.000000000","message":"Actually, this even is the default from puppetlabs-apache.","commit_id":"b100bbd954558b1026af66e498b265e23cb76200"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbe270fba1b4657e8e22775605f10ef31e47140c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"#   [*access_log_format*]"},{"line_number":74,"context_line":"#     The log format for the virtualhost."},{"line_number":75,"context_line":"#     Optional. Defaults to false."},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"#   [*error_log_file*]"},{"line_number":78,"context_line":"#     The error log file name for the virtualhost."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_cf808e49","line":75,"updated":"2017-10-06 13:35:08.000000000","message":"ditto","commit_id":"b100bbd954558b1026af66e498b265e23cb76200"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e7758ced837d954b5a7bd60a89148ee88d853f9c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"#   [*access_log_format*]"},{"line_number":74,"context_line":"#     The log format for the virtualhost."},{"line_number":75,"context_line":"#     Optional. Defaults to false."},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"#   [*error_log_file*]"},{"line_number":78,"context_line":"#     The error log file name for the virtualhost."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_afdc3274","line":75,"in_reply_to":"7f515b1d_cf808e49","updated":"2017-10-06 13:36:09.000000000","message":"same answer.","commit_id":"b100bbd954558b1026af66e498b265e23cb76200"}],"releasenotes/notes/configure-access-and-error-log-files-0181077a3d0e9d20.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ecabe0e70221ce4fcff7e0bb258939b45bd63936","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    it is now possible to configure the access log (through the access_log_file"},{"line_number":5,"context_line":"    and access_log_format variables) and the error log file path (through the"},{"line_number":6,"context_line":"    error_log_file variable) in the apache vhost."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_6f775a3c","line":4,"updated":"2017-10-06 13:44:37.000000000","message":"nit: It","commit_id":"c0c1bf876a510937c9c48639e66c18f684540855"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ecabe0e70221ce4fcff7e0bb258939b45bd63936","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    it is now possible to configure the access log (through the access_log_file"},{"line_number":5,"context_line":"    and access_log_format variables) and the error log file path (through the"},{"line_number":6,"context_line":"    error_log_file variable) in the apache vhost."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_4f725e4b","line":5,"updated":"2017-10-06 13:44:37.000000000","message":"nit: `` around variable names","commit_id":"c0c1bf876a510937c9c48639e66c18f684540855"}]}
