)]}'
{"manifests/drivers/ipmi.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"24edf9baec925b46f410fee4f28b747064450f1c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# [*command_retry_timeout*]"},{"line_number":23,"context_line":"#   (optional) Maximum time in seconds to retry IPMI operations."},{"line_number":24,"context_line":"#   Should be an interger value"},{"line_number":25,"context_line":"#   Defaults to \u002710\u0027."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_283a4bcb","line":25,"updated":"2017-11-27 12:50:57.000000000","message":"please switch to os_service_defaults while you\u0027re on it. the value of 10 does not match the upstream default.","commit_id":"aa83dd6988cf9eaa5e90fc5866d7e749971afc33"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"24edf9baec925b46f410fee4f28b747064450f1c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if $retry_timeout {"},{"line_number":43,"context_line":"    warning(\u0027retry_timeout parameter is replaced by command_retry_timeout and will be removed in the future.\u0027)"},{"line_number":44,"context_line":"    $command_retry_timeout \u003d $retry_timeout"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  # Configure ironic.conf"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_c832bff2","line":44,"updated":"2017-11-27 12:50:57.000000000","message":"huh, I thought one cannot override variables in puppet...","commit_id":"aa83dd6988cf9eaa5e90fc5866d7e749971afc33"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"df1eb43f91ecdd4704f713e0cca6520bb960cae5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class ironic::drivers::ipmi ("},{"line_number":35,"context_line":"  $command_retry_timeout \u003d $::os_service_default,"},{"line_number":36,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":37,"context_line":"  $retry_timeout \u003d undef"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::ironic::deps"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"df87a7cf_9e2d6c48","line":37,"updated":"2017-12-01 21:57:08.000000000","message":"nit: we usually align the \u003d in param lists.","commit_id":"6183b17fc387ac1eb9e1bf41cf9d2dc83f5bcb7b"}]}
