)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ecddc8165d724ebd9a898b1f029d2ab3680db285","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-03-15 13:10:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"inspector: configure \"dnsmasq\" DHCP filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I056cdadc025f35d8b6fd22f510a7c0a8e259a1f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df7087c5_546cd4cc","line":8,"updated":"2018-03-15 13:35:31.000000000","message":"please add yourself as\n\n Co-Authored-By: Name \u003cemail\u003e","commit_id":"24e508217fa63f72bea0a2f6db364dddc3d2a501"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"194000e245860a4267cfb4e08a51945d7444744b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-03-15 13:10:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"inspector: configure \"dnsmasq\" DHCP filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I056cdadc025f35d8b6fd22f510a7c0a8e259a1f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df7087c5_14aadc17","line":8,"in_reply_to":"df7087c5_546cd4cc","updated":"2018-03-15 13:54:01.000000000","message":"Done","commit_id":"24e508217fa63f72bea0a2f6db364dddc3d2a501"}],"manifests/inspector.pp":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"f4b9673c1fd9fa8c1b3a67bdf259ea6cb8208a5a","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:                      value \u003d\u003e $auth_strategy;"},{"line_number":352,"context_line":"    \u0027DEFAULT/timeout\u0027:                            value \u003d\u003e $timeout;"},{"line_number":353,"context_line":"    \u0027capabilities/boot_mode\u0027:                     value \u003d\u003e $detect_boot_mode;"},{"line_number":354,"context_line":"    \u0027iptables/dnsmasq_interface\u0027:                 value \u003d\u003e $dnsmasq_interface;"},{"line_number":355,"context_line":"    \u0027processing/ramdisk_logs_dir\u0027:                value \u003d\u003e $ramdisk_logs_dir;"},{"line_number":356,"context_line":"    \u0027processing/add_ports\u0027:                       value \u003d\u003e $add_ports;"},{"line_number":357,"context_line":"    \u0027processing/keep_ports\u0027:                      value \u003d\u003e $keep_ports;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ff82abbf_9cba76be","line":354,"range":{"start_line":354,"start_character":5,"end_line":354,"end_character":13},"updated":"2017-11-29 17:27:07.000000000","message":"I\u0027m not sure how to do it but I guess we need to add:\n\n  [pxe_filter]\n  driver\u003ddnsmasq\n\nas the default is iptables still","commit_id":"0ab8a4e6adacd492b816488b50bb5608588a12f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a88bbd21fae5e9d04287300a91dd0174169047a8","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:                      value \u003d\u003e $auth_strategy;"},{"line_number":352,"context_line":"    \u0027DEFAULT/timeout\u0027:                            value \u003d\u003e $timeout;"},{"line_number":353,"context_line":"    \u0027capabilities/boot_mode\u0027:                     value \u003d\u003e $detect_boot_mode;"},{"line_number":354,"context_line":"    \u0027iptables/dnsmasq_interface\u0027:                 value \u003d\u003e $dnsmasq_interface;"},{"line_number":355,"context_line":"    \u0027processing/ramdisk_logs_dir\u0027:                value \u003d\u003e $ramdisk_logs_dir;"},{"line_number":356,"context_line":"    \u0027processing/add_ports\u0027:                       value \u003d\u003e $add_ports;"},{"line_number":357,"context_line":"    \u0027processing/keep_ports\u0027:                      value \u003d\u003e $keep_ports;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ff82abbf_b7d7534b","line":354,"range":{"start_line":354,"start_character":5,"end_line":354,"end_character":13},"in_reply_to":"ff82abbf_9cba76be","updated":"2017-11-29 17:27:53.000000000","message":"See pxe_filter.pp","commit_id":"0ab8a4e6adacd492b816488b50bb5608588a12f5"}],"releasenotes/notes/ironic-inspector-pxe-filter-dnsmasq-98af54c3cbf105c8.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ecddc8165d724ebd9a898b1f029d2ab3680db285","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support ``dnsmasq`` PXE filter driver in ironic-inspector."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_345da014","line":4,"updated":"2018-03-15 13:35:31.000000000","message":"nit: \"support for the\"","commit_id":"24e508217fa63f72bea0a2f6db364dddc3d2a501"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"194000e245860a4267cfb4e08a51945d7444744b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support ``dnsmasq`` PXE filter driver in ironic-inspector."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_943fcc85","line":4,"in_reply_to":"df7087c5_345da014","updated":"2018-03-15 13:54:01.000000000","message":"Done","commit_id":"24e508217fa63f72bea0a2f6db364dddc3d2a501"}],"spec/classes/ironic_inspector_pxe_filter_dnsmasq_spec.rb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ecddc8165d724ebd9a898b1f029d2ab3680db285","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  let :pre_condition do"},{"line_number":23,"context_line":"     \"class { \u0027ironic::inspector::authtoken\u0027:"},{"line_number":24,"context_line":"        password \u003d\u003e \u0027password\u0027,"},{"line_number":25,"context_line":"      }"},{"line_number":26,"context_line":"      class { \u0027ironic::inspector\u0027:"},{"line_number":27,"context_line":"        dnsmasq_dhcp_hostsdir \u003d\u003e \u0027/etc/ironic-inspector/dhcp-hostsdir\u0027,"},{"line_number":28,"context_line":"      }\""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"df7087c5_746798ea","line":25,"updated":"2018-03-15 13:35:31.000000000","message":"do we really need this? I don\u0027t remember it being used anywhere else","commit_id":"24e508217fa63f72bea0a2f6db364dddc3d2a501"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"194000e245860a4267cfb4e08a51945d7444744b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  let :pre_condition do"},{"line_number":23,"context_line":"     \"class { \u0027ironic::inspector::authtoken\u0027:"},{"line_number":24,"context_line":"        password \u003d\u003e \u0027password\u0027,"},{"line_number":25,"context_line":"      }"},{"line_number":26,"context_line":"      class { \u0027ironic::inspector\u0027:"},{"line_number":27,"context_line":"        dnsmasq_dhcp_hostsdir \u003d\u003e \u0027/etc/ironic-inspector/dhcp-hostsdir\u0027,"},{"line_number":28,"context_line":"      }\""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"df7087c5_7453186c","line":25,"in_reply_to":"df7087c5_746798ea","updated":"2018-03-15 13:54:01.000000000","message":"Without it tests fail with:\nFailure/Error: fail(\u0027Please set password for Ironic Inspector service user\u0027)","commit_id":"24e508217fa63f72bea0a2f6db364dddc3d2a501"}],"spec/classes/ironic_inspector_pxe_filter_spec.rb":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ecddc8165d724ebd9a898b1f029d2ab3680db285","unresolved":false,"context_lines":[{"line_number":23,"context_line":"     \"class { \u0027ironic::inspector::authtoken\u0027:"},{"line_number":24,"context_line":"        password \u003d\u003e \u0027password\u0027,"},{"line_number":25,"context_line":"      }\""},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  shared_examples_for \u0027ironic inspector pxe_filter\u0027 do"},{"line_number":29,"context_line":"    it \u0027configure pxe_filter default params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"df7087c5_1462dcd8","line":26,"updated":"2018-03-15 13:35:31.000000000","message":"ditto","commit_id":"24e508217fa63f72bea0a2f6db364dddc3d2a501"}]}
