)]}'
{"manifests/params.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41b62dd6bd61687d47679ae3b35210e217f21ded","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $client_package           \u003d \u0027python-ironicclient\u0027"},{"line_number":30,"context_line":"  $inspector_client_package \u003d \u0027python-ironic-inspector-client\u0027"},{"line_number":31,"context_line":"  $lib_package_name         \u003d \u0027python-ironic-lib\u0027"},{"line_number":32,"context_line":"  $group                    \u003d \u0027ironic\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  case $::osfamily {"},{"line_number":35,"context_line":"    \u0027RedHat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f96bb07_01733617","line":32,"updated":"2018-01-11 10:20:50.000000000","message":"nit: I think we tended to just hardcode \"ironic\" before..","commit_id":"373f2d98d01c8a0c73b07db1fb1368502ff1d9c0"}],"manifests/policy.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41b62dd6bd61687d47679ae3b35210e217f21ded","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   Defaults to empty hash."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*policy_path*]"},{"line_number":23,"context_line":"#   (optional) Path to the nova policy.json file"},{"line_number":24,"context_line":"#   Defaults to /etc/ironic/policy.json"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class ironic::policy ("}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f96bb07_a161223c","line":23,"updated":"2018-01-11 10:20:50.000000000","message":"s/nova/ironic/","commit_id":"373f2d98d01c8a0c73b07db1fb1368502ff1d9c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41b62dd6bd61687d47679ae3b35210e217f21ded","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  Openstacklib::Policy::Base {"},{"line_number":37,"context_line":"    file_path  \u003d\u003e $policy_path,"},{"line_number":38,"context_line":"    file_user  \u003d\u003e \u0027root\u0027,"},{"line_number":39,"context_line":"    file_group \u003d\u003e $::ironic::params::group,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f96bb07_c166ae52","line":38,"updated":"2018-01-11 10:20:50.000000000","message":"Why root? Ironic service is run as \"ironic\" user. It may be different when using mod_wsgi, but I think \"ironic\" is still the most generic case.","commit_id":"373f2d98d01c8a0c73b07db1fb1368502ff1d9c0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ef6dc12aeea1548c9913983d42ebcfddd68a5d1a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  Openstacklib::Policy::Base {"},{"line_number":37,"context_line":"    file_path  \u003d\u003e $policy_path,"},{"line_number":38,"context_line":"    file_user  \u003d\u003e \u0027root\u0027,"},{"line_number":39,"context_line":"    file_group \u003d\u003e $::ironic::params::group,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f96bb07_1832c4f2","line":38,"in_reply_to":"7f96bb07_c166ae52","updated":"2018-01-11 15:58:20.000000000","message":"So the existing (previous provided by rpms) were root:\u003cservice\u003e with 0640 perms. The policy file should not be modifiable by the service just readable.","commit_id":"373f2d98d01c8a0c73b07db1fb1368502ff1d9c0"}]}
