)]}'
{"manifests/conductor.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09b70c33a5b0815bee307e4a7b4cff081d558b67","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  $port_setup_delay                    \u003d $::os_service_default,"},{"line_number":177,"context_line":"  $cleaning_network_name               \u003d undef,"},{"line_number":178,"context_line":"  $provisioning_network_name           \u003d undef,"},{"line_number":179,"context_line":"  $power_state_change_timeout          \u003d 60,"},{"line_number":180,"context_line":"  # DEPRECATED"},{"line_number":181,"context_line":"  $cleaning_network_uuid               \u003d undef,"},{"line_number":182,"context_line":"  $provisioning_network_uuid           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_b2dbba1f","line":179,"updated":"2018-01-19 18:54:08.000000000","message":"this should not be changed here, but rather e.g. in tripleo. puppet modules should use upstream defaults when it\u0027s possible. this is where OoO does it: https://github.com/openstack/instack-undercloud/blob/master/elements/puppet-stack-config/puppet-stack-config.yaml.template#L507-L515","commit_id":"caec0e6486212cf77159967e9d04fe93e457bbff"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7f17fafe0d6d64f31762b281da996811927e3683","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  $port_setup_delay                    \u003d $::os_service_default,"},{"line_number":177,"context_line":"  $cleaning_network_name               \u003d undef,"},{"line_number":178,"context_line":"  $provisioning_network_name           \u003d undef,"},{"line_number":179,"context_line":"  $power_state_change_timeout          \u003d 60,"},{"line_number":180,"context_line":"  # DEPRECATED"},{"line_number":181,"context_line":"  $cleaning_network_uuid               \u003d undef,"},{"line_number":182,"context_line":"  $provisioning_network_uuid           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_b7515665","line":179,"in_reply_to":"7f96bb07_b2dbba1f","updated":"2018-01-21 21:56:03.000000000","message":"Fantastic.  I\u0027ll do it there.  I knew this was wrong but wasn\u0027t sure how to do it right","commit_id":"caec0e6486212cf77159967e9d04fe93e457bbff"}],"manifests/drivers/ipmi.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09b70c33a5b0815bee307e4a7b4cff081d558b67","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class ironic::drivers::ipmi ("},{"line_number":40,"context_line":"  $command_retry_timeout \u003d 120,"},{"line_number":41,"context_line":"  $min_command_interval \u003d 15,"},{"line_number":42,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"  $retry_timeout \u003d undef"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_d2e0c6cf","line":41,"updated":"2018-01-19 18:54:08.000000000","message":"is changing to explicit values temporary? in the final patch we should have os_service_default here","commit_id":"caec0e6486212cf77159967e9d04fe93e457bbff"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7f17fafe0d6d64f31762b281da996811927e3683","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class ironic::drivers::ipmi ("},{"line_number":40,"context_line":"  $command_retry_timeout \u003d 120,"},{"line_number":41,"context_line":"  $min_command_interval \u003d 15,"},{"line_number":42,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"  $retry_timeout \u003d undef"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_574ed2c1","line":41,"in_reply_to":"7f96bb07_d2e0c6cf","updated":"2018-01-21 21:56:03.000000000","message":"My plan is for it to be fixed before we merge I just didn\u0027t know how to do it right. I\u0027m pretty sure I do now.  Thanks!","commit_id":"caec0e6486212cf77159967e9d04fe93e457bbff"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"320d5f712568ae77189917d533b3c4fc5cf68408","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class ironic::drivers::ipmi ("},{"line_number":40,"context_line":"  $command_retry_timeout \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $min_command_interval \u003d $::os_service_default,"},{"line_number":42,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"  $retry_timeout \u003d undef"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3fa0c359_a624ce0e","line":41,"updated":"2018-02-05 23:04:47.000000000","message":"nit: align \u003d","commit_id":"1459e37722fdc8404844556d322c357bb6c04ea6"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2d9afee04d2d8d7ad5120319befb8a7c025e00c0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class ironic::drivers::ipmi ("},{"line_number":40,"context_line":"  $command_retry_timeout \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $min_command_interval \u003d $::os_service_default,"},{"line_number":42,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":43,"context_line":"  $retry_timeout \u003d undef"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3fa0c359_afaee12b","line":41,"in_reply_to":"3fa0c359_a624ce0e","updated":"2018-02-06 01:58:05.000000000","message":"Done","commit_id":"1459e37722fdc8404844556d322c357bb6c04ea6"}],"manifests/drivers/pxe.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cd215f7531be282febdeeddb931fdf34b9feb905","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":"  if $enable_ppc64le {"},{"line_number":129,"context_line":"    ironic_config {"},{"line_number":130,"context_line":"      \u0027pxe/pxe_config_template_by_arch\u0027: value \u003d\u003e \u0027ppc64le:$pybasedir/drivers/modules/pxe_config.template\u0027;"},{"line_number":131,"context_line":"      \u0027pxe/pxe_bootfile_name_by_arch\u0027: value   \u003d\u003e \u0027ppc64le:config\u0027;"},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":"  }"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f93b717_50b7d587","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":67},"updated":"2018-01-25 00:00:02.000000000","message":"do we really want to hardcode it?","commit_id":"bbfe3904510a5d1c7d9e73e031a1ff16dab856a0"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7be9d97a733a41280cf04c9f214fde86b8317abc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":"  if $enable_ppc64le {"},{"line_number":129,"context_line":"    ironic_config {"},{"line_number":130,"context_line":"      \u0027pxe/pxe_config_template_by_arch\u0027: value \u003d\u003e \u0027ppc64le:$pybasedir/drivers/modules/pxe_config.template\u0027;"},{"line_number":131,"context_line":"      \u0027pxe/pxe_bootfile_name_by_arch\u0027: value   \u003d\u003e \u0027ppc64le:config\u0027;"},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":"  }"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f93b717_b0509934","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":67},"in_reply_to":"5f93b717_50b7d587","updated":"2018-01-25 00:05:19.000000000","message":"Hmm actually I could use pxe_config_template_real and build it up in a nicer way.  That would be  slightly better.","commit_id":"bbfe3904510a5d1c7d9e73e031a1ff16dab856a0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"320d5f712568ae77189917d533b3c4fc5cf68408","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  if $enable_ppc64le {"},{"line_number":130,"context_line":"    # FXIME(tonyb): As these are really hash values it would beter to model"},{"line_number":131,"context_line":"    # them that way.  We can do that later, probably when we add another "},{"line_number":132,"context_line":"    # architecture"},{"line_number":133,"context_line":"    ironic_config {"},{"line_number":134,"context_line":"      # NOTE(tonyb): This first value shouldn\u0027t be needed but seems to be?"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3fa0c359_86275213","line":131,"updated":"2018-02-05 23:04:47.000000000","message":"nit: trailing space","commit_id":"1459e37722fdc8404844556d322c357bb6c04ea6"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2d9afee04d2d8d7ad5120319befb8a7c025e00c0","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  if $enable_ppc64le {"},{"line_number":130,"context_line":"    # FXIME(tonyb): As these are really hash values it would beter to model"},{"line_number":131,"context_line":"    # them that way.  We can do that later, probably when we add another "},{"line_number":132,"context_line":"    # architecture"},{"line_number":133,"context_line":"    ironic_config {"},{"line_number":134,"context_line":"      # NOTE(tonyb): This first value shouldn\u0027t be needed but seems to be?"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3fa0c359_6fa8d91e","line":131,"in_reply_to":"3fa0c359_86275213","updated":"2018-02-06 01:58:05.000000000","message":"Done","commit_id":"1459e37722fdc8404844556d322c357bb6c04ea6"}],"manifests/inspector.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09b70c33a5b0815bee307e4a7b4cff081d558b67","unresolved":false,"context_lines":[{"line_number":315,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_pxelinux_cfg.erb\u0027),"},{"line_number":316,"context_line":"      require \u003d\u003e Anchor[\u0027ironic-inspector::config::begin\u0027],"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"    file { \"${tftp_root_real}/ppc64le/default\":"},{"line_number":319,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":320,"context_line":"      seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":321,"context_line":"      owner   \u003d\u003e \u0027ironic-inspector\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_12c14e2f","line":318,"updated":"2018-01-19 18:54:08.000000000","message":"why do we need a new file if it\u0027s identical to the default one?","commit_id":"caec0e6486212cf77159967e9d04fe93e457bbff"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7f17fafe0d6d64f31762b281da996811927e3683","unresolved":false,"context_lines":[{"line_number":315,"context_line":"      content \u003d\u003e template(\u0027ironic/inspector_pxelinux_cfg.erb\u0027),"},{"line_number":316,"context_line":"      require \u003d\u003e Anchor[\u0027ironic-inspector::config::begin\u0027],"},{"line_number":317,"context_line":"    }"},{"line_number":318,"context_line":"    file { \"${tftp_root_real}/ppc64le/default\":"},{"line_number":319,"context_line":"      ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":320,"context_line":"      seltype \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":321,"context_line":"      owner   \u003d\u003e \u0027ironic-inspector\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_d75ae281","line":318,"in_reply_to":"7f96bb07_12c14e2f","updated":"2018-01-21 21:56:03.000000000","message":"the ppc64le firmware automatically looks in the same directory as the config file for and images mentioned.  So by placing this in a different directory we\u0027re also implicitly setting the path to the images themselves.","commit_id":"caec0e6486212cf77159967e9d04fe93e457bbff"}],"spec/classes/ironic_inspector_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"04fc0cca3c480815d4c428b6386447d690e86182","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        end"},{"line_number":263,"context_line":"      end"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"      context \u0027when enabling ppc64le support\u0027"},{"line_number":266,"context_line":"        before :each do"},{"line_number":267,"context_line":"          params.merge!("},{"line_number":268,"context_line":"            :enable_ppc64le \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3fa0c359_b0eccb29","line":265,"range":{"start_line":265,"start_character":6,"end_line":265,"end_character":45},"updated":"2018-02-07 17:10:38.000000000","message":"You forgot a \u0027do\u0027 at the end of this line","commit_id":"85b05d9306d03f75af69c4c3a0c15d8c9fed6f8f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"04bbe2d6dc9cce1d99ad20aaae9ec1f2c812a2fa","unresolved":false,"context_lines":[{"line_number":282,"context_line":"          \u0027group\u0027   \u003d\u003e \u0027ironic-inspector\u0027,"},{"line_number":283,"context_line":"          \u0027seltype\u0027 \u003d\u003e \u0027tftpdir_t\u0027,"},{"line_number":284,"context_line":"          \u0027ensure\u0027  \u003d\u003e \u0027present\u0027,"},{"line_number":285,"context_line":"          \u0027require\u0027 \u003d\u003e \u0027[Anchor[ironic-inspector::config::begin], Class[ironic::pxe]]\u0027,"},{"line_number":286,"context_line":"          \u0027content\u0027 \u003d\u003e /default/,"},{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":"        is_expected.to contain_file(\u0027/tftpboot/ppc64le/default\u0027).with_content("}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5f7c97a3_6507f718","line":285,"updated":"2018-07-06 15:54:50.000000000","message":"And like the other change, this should be:\n\n  \u0027require\u0027 \u003d\u003e [\u0027Anchor[ironic-inspector::config::begin]\u0027, \u0027Class[Ironic::Pxe]\u0027],","commit_id":"395b234aef4ab4c484ad7f79a46f85f7c083ead6"}],"templates/inspector_dnsmasq_tftp.erb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cd215f7531be282febdeeddb931fdf34b9feb905","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003c% end -%\u003e"},{"line_number":24,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,\u003c%\u003d @dnsmasq_local_ip %\u003e"},{"line_number":25,"context_line":"dhcp-sequential-ip"},{"line_number":26,"context_line":"# Client is ppc64le (OPAL) box and doesn\u0027t need a chain loader, but does need a custom config"},{"line_number":27,"context_line":"dhcp-match\u003dset:ppc64le,option:client-arch,14"},{"line_number":28,"context_line":"dhcp-boot\u003dtag:ppc64le,"},{"line_number":29,"context_line":"dhcp-option\u003dtag:ppc64le, 210,\u003c%\u003d @tftp_root_real %\u003e/ppc64le/"},{"line_number":30,"context_line":"dhcp-option\u003dtag:ppc64le, 209,default"}],"source_content_type":"application/x-erb","patch_set":5,"id":"5f93b717_30aec92e","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":36},"updated":"2018-01-25 00:00:02.000000000","message":"should we put that in a conditional or include this config ALL the times?","commit_id":"bbfe3904510a5d1c7d9e73e031a1ff16dab856a0"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7be9d97a733a41280cf04c9f214fde86b8317abc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003c% end -%\u003e"},{"line_number":24,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,\u003c%\u003d @dnsmasq_local_ip %\u003e"},{"line_number":25,"context_line":"dhcp-sequential-ip"},{"line_number":26,"context_line":"# Client is ppc64le (OPAL) box and doesn\u0027t need a chain loader, but does need a custom config"},{"line_number":27,"context_line":"dhcp-match\u003dset:ppc64le,option:client-arch,14"},{"line_number":28,"context_line":"dhcp-boot\u003dtag:ppc64le,"},{"line_number":29,"context_line":"dhcp-option\u003dtag:ppc64le, 210,\u003c%\u003d @tftp_root_real %\u003e/ppc64le/"},{"line_number":30,"context_line":"dhcp-option\u003dtag:ppc64le, 209,default"}],"source_content_type":"application/x-erb","patch_set":5,"id":"5f93b717_300a4926","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":36},"in_reply_to":"5f93b717_30aec92e","updated":"2018-01-25 00:05:19.000000000","message":"Well it wont hurt if it\u0027s there all the time as only ppc64le machines will match the client-arch but I can wrap it in a conditional.","commit_id":"bbfe3904510a5d1c7d9e73e031a1ff16dab856a0"}]}